-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update eslint related packages #48513
Conversation
💔 Build Failed |
PR has been edited👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description. |
💔 Build Failed |
@@ -622,7 +641,6 @@ module.exports = { | |||
// will introduced after the other warns are fixed | |||
// 'react/sort-comp': 'error', | |||
'react/void-dom-elements-no-children': 'error', | |||
'react/jsx-boolean-value': ['error', 'warn'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This configuration is invalid, which caused this to be a noop, so I removed it.
@@ -40,6 +40,7 @@ bower_components | |||
/x-pack/legacy/plugins/infra/public/graphql/types.ts | |||
/x-pack/legacy/plugins/infra/server/graphql/types.ts | |||
/x-pack/legacy/plugins/apm/cypress/**/snapshots.js | |||
/src/legacy/plugin_discovery/plugin_pack/__tests__/fixtures/plugins/broken |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The globbing has been improved a little so the code in this directory was being tested now.
@@ -18,4 +18,4 @@ | |||
*/ | |||
|
|||
// eslint-disable-next-line import/no-default-export | |||
export default function(selector: string): string; | |||
export default function kbnTestSubjSelector(selector: string): string; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Named this to avoid typescript-eslint/typescript-eslint#1078
@@ -71,7 +71,7 @@ export class PluginWrapper< | |||
private instance?: Plugin<TSetup, TStart, TPluginsSetup, TPluginsStart>; | |||
|
|||
constructor( | |||
readonly discoveredPlugin: DiscoveredPlugin, | |||
public readonly discoveredPlugin: DiscoveredPlugin, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This and other instances of adding public
modifiers are necessary because of typescript-eslint/typescript-eslint#857, which prevented property parameters created using the readonly
keyword from being validated like normal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
APM-related stuff looks good! 👍
@@ -20,16 +20,16 @@ | |||
const os = require('os'); | |||
const path = require('path'); | |||
|
|||
function useBat(bin) { | |||
function maybeUseBat(bin) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This triggers React hooks checks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apm changes lgtm
EDIT: nvm @smith already approved :)
💔 Build Failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Platform changes LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kibana App changes look good to me. Skimmed over the rest, that also looks good so far.
💚 Build Succeeded |
I don't think the changes justify waiting for more LGTMs, and this is at pretty high risk of reaching conflict hell. @elastic/kibana-canvas @elastic/kibana-stack-services @elastic/logs-metrics-ui @elastic/kibana-operations I'm going to merge this in an hour or so, if you want to take a look first please do. |
* Update eslint related packages * add errorMessage to no-restricted-paths validation * add license to eslintrc file * ignore broken plugin fixture * upgrade tangled peer deps * give name to unnamed func to avoid typescript-eslint/typescript-eslint#1078 * migrate away from removed prefer-interface * migrate away from removed no-angle-bracket-type-assertions rule * migrate away from removed no-triple-slash-reference rule * old config was invalid and made this rule a noop * fix array-type rule config * fix readonly paramProperties that weren't being checked * fix propType ordering * remove references to non-existent rules * remove unnecessary disable that is improperly formatted * fix comment-related spacing * fix typo/invalid namespace overrides * rename fn to avoid hook-alike behavior * remove reference to old removed rule * use caret version for prettier * reference babel-eslint with absolute path
* Update eslint related packages * add errorMessage to no-restricted-paths validation * add license to eslintrc file * ignore broken plugin fixture * upgrade tangled peer deps * give name to unnamed func to avoid typescript-eslint/typescript-eslint#1078 * migrate away from removed prefer-interface * migrate away from removed no-angle-bracket-type-assertions rule * migrate away from removed no-triple-slash-reference rule * old config was invalid and made this rule a noop * fix array-type rule config * fix readonly paramProperties that weren't being checked * fix propType ordering * remove references to non-existent rules * remove unnecessary disable that is improperly formatted * fix comment-related spacing * fix typo/invalid namespace overrides * rename fn to avoid hook-alike behavior * remove reference to old removed rule * use caret version for prettier * reference babel-eslint with absolute path
7.x/7.6: 0bed689 |
This PR contains the following updates:
^4.16.8
->^6.1.2
5.16.0
->6.5.1
5.16.0
->6.5.1
6.3.0
->6.4.0
^2.6.1
->^2.7.0
9.2.0
->10.0.0
Release Notes
eslint/eslint
v6.5.1
Compare Source
0d3d7d9
Docs: fix typo in no-magic-numbers (#12345) (Josiah Rooney)447ac87
Fix: no-useless-rename handles ExperimentalRestProperty (fixes #12335) (#12339) (Kai Cataldo)b6ff73c
Sponsors: Sync README with website (ESLint Jenkins)v6.5.0
Compare Source
73596cb
Update: Add enforceForSwitchCase option to use-isnan (#12106) (Milos Djermanovic)d592a24
Fix: exclude\u000d
so new line won't convert to text (fixes #12027) (#12031) (zamboney)e85d27a
Fix: no-regex-spaces false positives and invalid autofix (fixes #12226) (#12231) (Milos Djermanovic)b349bf7
Fix: prefer-named-capture-group incorrect locations (fixes #12233) (#12247) (Milos Djermanovic)7dc1ea9
Fix: no-useless-return autofix removes comments (#12292) (Milos Djermanovic)0e68677
Fix: no-extra-bind autofix removes comments (#12293) (Milos Djermanovic)6ad7e86
Fix: no-extra-label autofix removes comments (#12298) (Milos Djermanovic)acec201
Fix: no-undef-init autofix removes comments (#12299) (Milos Djermanovic)d89390b
Fix: use async reading of stdin in bin/eslint.js (fixes #12212) (#12230) (Barrie Treloar)334ca7c
Update: no-useless-rename also reports default values (fixes #12301) (#12322) (Kai Cataldo)41bfe91
Update: Fix handling of chained new expressions in new-parens (#12303) (Milos Djermanovic)160b7c4
Chore: add autofix npm script (#12330) (Kai Cataldo)04b6adb
Chore: enable eslint-plugin-jsdoc (refs #11146) (#12332) (Kai Cataldo)9b86167
Docs: Add new ES environments to Configuring ESLint (#12289) (Milos Djermanovic)c9aeab2
Docs: Add supported ECMAScript version to README (#12290) (Milos Djermanovic)8316e7b
Fix: no-useless-rename autofix removes comments (#12300) (Milos Djermanovic)29c12f1
Chore: cache results in runtime-info (#12320) (Kai Cataldo)f5537b2
Fix: prefer-numeric-literals autofix removes comments (#12313) (Milos Djermanovic)11ae6fc
Update: Fix call, new and member expressions in no-extra-parens (#12302) (Milos Djermanovic)a7894eb
New: add --env-info flag to CLI (#12270) (Kai Cataldo)61392ff
Sponsors: Sync README with website (ESLint Jenkins)2c6bf8e
Docs: English fix (#12306) (Daniel Nixon)6f11877
Sponsors: Sync README with website (ESLint Jenkins)2e202ca
Docs: fix links in array-callback-return (#12288) (Milos Djermanovic)e39c631
Docs: add example for CLIEngine#executeOnText 3rd arg (#12286) (Kai Cataldo)d4f9a16
Update: add support for JSXFragments in indent rule (fixes #12208) (#12210) (Kai Cataldo)c6af95f
Sponsors: Sync README with website (ESLint Jenkins)8cadd52
Sponsors: Sync README with website (ESLint Jenkins)f9fc695
Chore: enable default-param-last (#12244) (薛定谔的猫)9984c3e
Docs: Update README team and sponsors (ESLint Jenkins)v6.4.0
Compare Source
e915fff
Docs: Improve examples and clarify default option (#12067) (Yuping Zuo)540296f
Update: enforceForClassMembers option to accessor-pairs (fixes #12063) (#12192) (Milos Djermanovic)d3c2334
Update: flag nested block with declaration as error (#12193) (David Waller)b2498d2
Update: Fix handling of property names in no-self-assign (#12105) (Milos Djermanovic)1ee61b0
Update: enforceForClassMembers computed-property-spacing (fixes #12049) (#12214) (Milos Djermanovic)520c922
Docs: Added naming convention details to plugin usage (#12202) (Henrique Barcelos)f826eab
Fix: Allow line comment exception in object-curly-spacing (fixes #11902) (#12216) (Milos Djermanovic)db2a29b
Update: indentation of comment followed by semicolon (fixes #12232) (#12243) (Kai Cataldo)ae17d1c
Fix: no-sequences is reporting incorrect locations (#12241) (Milos Djermanovic)365331a
Fix: object-shorthand providing invalid fixes for typescript (#12260) (Brad Zacher)1c921c6
New: add no-import-assign (fixes #12237) (#12252) (Toru Nagashima)3be04fd
New: Add prefer-regex-literals rule (fixes #12238) (#12254) (Milos Djermanovic)37c0fde
Update: Report global Atomics calls in no-obj-calls (fixes #12234) (#12258) (Milos Djermanovic)985c9e5
Fix: space-before-function-paren autofix removes comments (fixes #12259) (#12264) (Milos Djermanovic)01da7d0
Fix: eqeqeq rule reports incorrect locations (#12265) (Milos Djermanovic)319e4d8
Docs: adding finally example (#12256) (Jens Melgaard)d52328f
Docs: fix no-sequenceswith
examples (#12239) (Milos Djermanovic)a41fdc0
Fix: Remove autofixer for no-unsafe-negation (#12157) (Milos Djermanovic)e38f5fd
Update: fix no-octal-escape false negatives after \0 (#12079) (Milos Djermanovic)9418fbe
Sponsors: Sync README with website (ESLint Jenkins)acc5ec5
Sponsors: Sync README with website (ESLint Jenkins)460c5ad
Sponsors: Sync README with website (ESLint Jenkins)0313441
New: add rule default-param-last (fixes #11361) (#12188) (Chiawen Chen)7621f5d
Update: add more specific linting messages to space-in-parens (#11121) (Che Fisher)21eb904
Fix: basePath of OverrideTester (fixes #12032) (#12205) (Toru Nagashima)86e5e65
Sponsors: Sync README with website (ESLint Jenkins)2b1a13f
Fix: no-extra-boolean-cast reports wrong negation node (fixes #11324) (#12197) (Milos Djermanovic)ba8c2aa
Sponsors: Sync README with website (ESLint Jenkins)a0a9746
Docs: Fix link in no-irregular-whitespace.md (#12196) (Timo Tijhof)e10eeba
Fix: quotes autofix produces syntax error with octal escape sequences (#12118) (Milos Djermanovic)v6.3.0
Compare Source
0acdefb
Chore: refactor code (#12113) (James George)52e2cf5
New: reportUnusedDisableDirectives in config (refs eslint/rfcs#22) (#12151) (Toru Nagashima)020f952
Update: enforceForSequenceExpressions to no-extra-parens (fixes #11916) (#12142) (Milos Djermanovic)aab1b84
Fix: reset to the default color (#12174) (Ricardo Gobbo de Souza)4009d39
Fix: yoda rule produces invalid autofix with preceding yield (#12166) (Milos Djermanovic)febb660
Fix: no-extra-boolean-cast invalid autofix with yield before negation (#12164) (Milos Djermanovic)4c0b70b
New: support TypeScript at config initializer (fixes #11789) (#12172) (Pig Fang)94e39d9
Chore: use GitHub Actions (#12144) (Toru Nagashima)e88f305
Chore: support es2020 in fuzz (#12180) (薛定谔的猫)00d2c5b
Docs: corrected class extension example (#12176) (Marius M)31e5428
Chore: Fix wrong error object keys in test files (#12162) (Milos Djermanovic)197f443
Fix: func-name-matching crash on descriptor-like arguments (#12100) (Milos Djermanovic)644ce33
Fix: no-self-assign false positive with rest and spread in array (#12099) (Milos Djermanovic)a81d263
Fix: fix message of function-paren-newline (#12136) (Pig Fang)77f8ed1
Chore: update blogpost template (#12154) (Toru Nagashima)6abc7b7
Docs: Document the exception in no-unsafe-negation (#12161) (Milos Djermanovic)v6.2.2
Compare Source
0e0b784
Upgrade: espree@^6.1.1 (#12158) (Kevin Partington)04e859f
Sponsors: Sync README with website (ESLint Jenkins)34783d1
Sponsors: Sync README with website (ESLint Jenkins)b809e72
Docs: Update README team and sponsors (ESLint Jenkins)v6.2.1
Compare Source
8c021b5
Upgrade: eslint-utils 1.4.2 (#12131) (Toru Nagashima)e82388b
Sponsors: Sync README with website (ESLint Jenkins)4aeeeed
Docs: update docs for ecmaVersion 2020 (#12120) (silverwind)6886148
Docs: Add duplicate keys limitation to accessor-pairs (#12124) (Milos Djermanovic)v6.2.0
Compare Source
fee6acb
Update: support bigint and dynamic import (refs #11803) (#11983) (Toru Nagashima)afd8012
New: noInlineConfig setting (refs eslint/rfcs#22) (#12091) (Toru Nagashima)3d12378
Update: Fix accessor-pairs to enforce pairs per property in literals (#12062) (Milos Djermanovic)8cd00b3
New: function-call-argument-newline (#12024) (finico)30ebf92
Fix: prefer-template autofix produces syntax error with octal escapes (#12085) (Milos Djermanovic)13c3988
Fix: Check literal type explicitly in dot-notation (#12095) (Milos Djermanovic)3e5ceca
Fix: Handle empty string property names in getFunctionNameWithKind (#12104) (Milos Djermanovic)9a043ff
Fix: no-duplicate-case false positives on Object.prototype keys (#12107) (Milos Djermanovic)fe631af
Chore: minor typo fix (#12112) (James George)4cb7877
Fix: fix no-extra-parens ignores some nodes (#11909) (Pig Fang)2dc23b8
Update: fix no-dupe-keys false negatives on empty string names (#12069) (Milos Djermanovic)19ab666
Fix: yoda exceptRange false positives on empty string property names (#12071) (Milos Djermanovic)d642150
Update: Check empty string property names in sort-keys (#12073) (Milos Djermanovic)acce6de
Fix: class-methods-use-this reports 'undefined' names (#12103) (Milos Djermanovic)92ec2cb
Fix: Allow bind call with a single spread element in no-extra-bind (#12088) (Milos Djermanovic)bfdb0c9
Fix: no-extra-boolean-cast invalid autofix for Boolean() without args (#12076) (Milos Djermanovic)34ccc0c
Chore: Remove TDZ scope type condition from no-unused-vars (#12055) (Milos Djermanovic)01d38ce
Docs: Remove TDZ scope from the scope manager interface documentation (#12054) (Milos Djermanovic)1aff8fc
Update: warn about mixing ternary and logical operators (fixes #11704) (#12001) (Karthik Priyadarshan)11be2f8
Docs: do not recommend global-installed usage (#12016) (薛定谔的猫)cf31dab
Fix: no-restricted-syntax - correct the schema (#12051) (Brad Zacher)fbec99e
Update: fix class-methods-use-this false negatives with exceptMethods (#12077) (Milos Djermanovic)fb08b7c
Docs: Remove readonly/writable global logic from no-undef (fixes #11963) (#12053) (Milos Djermanovic)5b5934b
Sponsors: Sync README with website (ESLint Jenkins)9156760
Sponsors: Sync README with website (ESLint Jenkins)f5e0cc4
Update: Check computed method keys in no-extra-parens (#11973) (Milos Djermanovic)d961438
Docs: Fix Incorrect Documentation (#12045) (Michael Miceli)887d08c
Sponsors: Sync README with website (ESLint Jenkins)d90183f
Docs: add a case to func-names (#12038) (Chiawen Chen)8a5b62d
Docs: no use eslint.linter in code example (#12037) (薛定谔的猫)5831767
Update: report location of func-names (fixes #12022) (#12028) (Pig Fang)v6.1.0
Compare Source
8f86cca
Upgrade: eslint-scope@^5.0.0 (#12011) (Kevin Partington)d08683e
Fix: glob processing (fixes #11940) (#11986) (Toru Nagashima)bfcf8b2
Fix: dot-location errors with parenthesized objects (fixes #11868) (#11933) (Milos Djermanovic)79e8d09
Fix: add parens for sequence expr in arrow-body-style (fixes #11917) (#11918) (Pig Fang)105c098
Docs: update docs for object-curly-spacing (fixes #11634) (#12009) (Chiawen Chen)c90a12c
Chore: update release script for new website repo (#12006) (Kai Cataldo)e2c08a9
Sponsors: Sync README with website (ESLint Jenkins)b974fcb
Update: Check computed property keys in no-extra-parens (#11952) (Milos Djermanovic)222d27c
Update: Add for-in and for-of checks for props in no-param-reassign (#11941) (Milos Djermanovic)e4c450f
Fix: no-extra-parens autofix within
in a for-loop init (fixes #11706) (#11848) (Milos Djermanovic)2dafe2d
Fix: prefer-const produces invalid autofix (fixes #11699) (#11827) (Milos Djermanovic)cb475fd
Fix: Cache file error handling on read-only file system. (fixes #11945) (#11946) (Cuki)89412c3
Docs: Fixed a typo (fixes #11999) (#12000) (Eddie Olson)6669f78
Fix: --init with Vue.js failed (fixes #11970) (#11985) (Toru Nagashima)93633c2
Upgrade: Upgrade lodash dependency (fixes #11992) (#11994) (Cyd La Luz)776dae7
Docs: fix wrong Node.js version in getting started (#11993) (Toru Nagashima)4448261
Docs: some typos and optimization points (#11960) (Jason Lee)2a10856
Chore: Add temporary test files to .gitignore (#11978) (Milos Djermanovic)d83b233
Chore: update path for release bundles (#11977) (Kai Cataldo)1fb3620
Fix: creating of enabledGlobals object without prototype (fixes #11929) (#11935) (finico)c2f2db9
Docs: Replace global true and false with writable and readonly in rules (#11956) (Milos Djermanovic)19335b8
Fix: actual messageId and expected messageId are switched in rule tester (#11928) (Milos Djermanovic)8b216e0
Docs: Fix incorrect example comments for unicode-bom rule (fixes #11937) (#11938) (Brandon Yeager)cc3885b
Chore: add v8-compile-cache to speed up instantiation time (#11921) (薛定谔的猫)d8f2688
Upgrade: deps (#11904) (薛定谔的猫)e5f1ccc
Docs: add 'stricter rule config validating' in migrating docs (#11905) (薛定谔的猫)v6.0.1
Compare Source
b5bde06
Fix: --rulesdir option didn't work (fixes #11888) (#11890) (Toru Nagashima)13f0418
Fix: improve error message on --print-config (fixes #11874) (#11885) (Toru Nagashima)056c2aa
Fix: improve diagnostics for shareable-config-missing errors (#11880) (Teddy Katz)566b7aa
Docs: Update no-confusing-arrow with the new default option (#11886) (Yuping Zuo)d07f3fa
Fix: CLIEngine#getRules() contains plugin rules (fixes #11871) (#11872) (Toru Nagashima)21f4a80
Docs: Fix inconsistent linking in migration guide (#11881) (Teddy Katz)f3a0774
Docs: Fix typo in 6.0.0 migration guide (#11870) (Kevin Partington)v6.0.0
Compare Source
81aa06b
Upgrade: espree@6.0.0 (#11869) (Teddy Katz)5f022bc
Fix: no-else-return autofix produces name collisions (fixes #11069) (#11867) (Milos Djermanovic)ded9548
Fix: multiline-comment-style incorrect message (#11864) (golopot)cad074d
Docs: Add JSHint W047 compat to no-floating-decimal (#11861) (Timo Tijhof)41f6304
Upgrade: sinon (#11855) (Toru Nagashima)167ce87
Chore: remove unuseable profile command (#11854) (Toru Nagashima)c844c6f
Fix: max-len properly ignore trailing comments (fixes #11838) (#11841) (ZYSzys)1b5661a
Fix: no-var should not fix variables named 'let' (fixes #11830) (#11832) (Milos Djermanovic)4d75956
Build: CI with Azure Pipelines (#11845) (Toru Nagashima)1db3462
Chore: rm superfluous argument & fix perf-multifiles-targets (#11834) (薛定谔的猫)c57a4a4
Upgrade: @babel/polyfill => core-js v3 (#11833) (薛定谔的猫)65faa04
Docs: Clarify prefer-destructuring array/object difference (fixes #9970) (#11851) (Oliver Sieweke)81c3823
Fix: require-atomic-updates reports parameters (fixes #11723) (#11774) (Toru Nagashima)aef8ea1
Sponsors: Sync README with website (ESLint Jenkins)prettier/eslint-config-prettier
v6.4.0
Compare Source
(@yangmingshan)!
cypress-io/eslint-plugin-cypress
v2.7.0
Compare Source
Features
mysticatea/eslint-plugin-node
v10.0.0
Compare Source
This release supports BigInt and Dynamic Imports if you are using ESLint 6.2.0 or later.
💥 Breaking Changes
9ea67c9
updatednode/no-unsupported-features/es-syntax
rule to recognize BigInt literals andimport()
.b91b48d
updatednode/no-unsupported-features/es-builtins
rule to recognizeBigInt
,BigInt64Array
,BigUint64Array
, andPromise.allSettled
.b57a4f9
updatednode/file-extension-in-import
,node/no-extraneous-import
,node/no-missing-import
, andnode/no-unpublished-import
rules to recognizeimport()
.4b9c4d7
updatednode/no-deprecated-api
rule to recognizemodule.createRequireFromPath
.9c574ba
updatedplugin:node/recommended
and the other configs.node/no-exports-assign
rule.exports
global variable writable.node/*-import
rules in CommonJS mode as well.✨ New rules
a0f0ee1
addednode/no-exports-assign
rule that disallowsexports = {}
.Renovate configuration
📅 Schedule: At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "
rebase!
".👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR has been generated by Renovate Bot. View repository job log here.