Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle empty datafeedState #48660

Merged
merged 1 commit into from
Oct 21, 2019
Merged

Handle empty datafeedState #48660

merged 1 commit into from
Oct 21, 2019

Conversation

afgomez
Copy link
Contributor

@afgomez afgomez commented Oct 18, 2019

Closes #48649

Treat an empty datafeedState as a failure instead of silently ignoring it and letting it crash

@afgomez afgomez requested a review from weltenwort October 18, 2019 15:51
@afgomez afgomez requested a review from a team as a code owner October 18, 2019 15:51
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@afgomez afgomez added Feature:Logs UI Logs UI feature release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.5.0 labels Oct 18, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@weltenwort weltenwort mentioned this pull request Oct 18, 2019
Closed
@afgomez afgomez force-pushed the 48649-handle-empty-datafeedstate branch from fc3ee64 to 2cf7cd1 Compare October 21, 2019 07:02
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

weltenwort
weltenwort approved these changes Oct 21, 2019
View reviewed changes
Copy link
Member

@weltenwort weltenwort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, well done 👍

@afgomez afgomez merged commit e4ecfb1 into elastic:master Oct 21, 2019
@afgomez afgomez deleted the 48649-handle-empty-datafeedstate branch October 21, 2019 11:28
This was referenced Oct 21, 2019
Closed
Merged
afgomez pushed a commit to afgomez/kibana that referenced this pull request Oct 21, 2019
Handle empty datafeedState (elastic#48660)
75e754b
afgomez pushed a commit to afgomez/kibana that referenced this pull request Oct 21, 2019
Handle empty datafeedState (elastic#48660)
4870e1a
afgomez pushed a commit that referenced this pull request Oct 21, 2019
[7.5] Handle empty datafeedState (#48660) (#48743)
146b1be
@afgomez afgomez mentioned this pull request Oct 21, 2019
Merged
afgomez pushed a commit to afgomez/kibana that referenced this pull request Oct 21, 2019
Handle empty datafeedState (elastic#48660)
00a3c8f
afgomez pushed a commit that referenced this pull request Oct 22, 2019
Handle empty datafeedState (#48660) (#48765)
f78467b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weltenwort weltenwort weltenwort approved these changes

Assignees
No one assigned
Labels
Feature:Logs UI Logs UI feature release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.5.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Logs UI] Jobs without datafeeds cause analysis job status check to fail
3 participants
@afgomez @elasticmachine @weltenwort