[Metrics UI] Convert layouts to use React components #49134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed
|
💔 Build Failed
|
- This PR closes elastic#48808 - Move all files under pages/metrics
simianhacker
force-pushed
the
issue-48808-react-layouts
branch
from
1c66040
to
64c250f
Compare
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
simianhacker
added
Feature:Metrics UI
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
simianhacker
added
the
release_note:skip
💔 Build Failed |
|
@elasticmachine merge upstream |
phillipb
reviewed
Oct 31, 2019
x-pack/legacy/plugins/infra/public/pages/metrics/components/section.tsx
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/infra/public/pages/metrics/components/section.tsx
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/infra/public/pages/metrics/components/sub_section.tsx
Outdated
Show resolved
Hide resolved
💔 Build Failed |
…ibana into issue-48808-react-layouts
💔 Build Failed |
💚 Build Succeeded |
💔 Build Failed |
|
@elasticmachine merge upstream |
💚 Build Succeeded |
💚 Build Succeeded |
phillipb
approved these changes
Nov 13, 2019
x-pack/legacy/plugins/infra/common/inventory_models/host/detail_page.tsx
Outdated
Show resolved
Hide resolved
💚 Build Succeeded |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Nov 14, 2019
* 'master' of github.com:elastic/kibana: (27 commits) [Rollup] Fix for clone job workflow (elastic#50501) Empty message "No data available" for Labels and User metadata sections missing (elastic#49846) [APM] Duration by Country map doesn't take `transactionName` into account (elastic#50315) Remove react references from core `Notifications` apis (elastic#49573) Updated APM Indices endpoints to use the SavedObjectsClient from the legacy request context, and set the apm-indices schema object to be namspace-agnostic [Metrics UI] Calculate interval based on the dataset's period (elastic#50194) chore(NA): add new platform discovered plugins as entry points to check for dependencies on clean dll tasks (elastic#50610) [Telemetry] change of optin status telemetry (elastic#50158) [SIEM][Detection Engine] REST API Additions (elastic#50514) [DOCS] Removes dashboard-only mode doc (elastic#50441) [Filters] Fix operator overflowing out popover (elastic#50030) Change telemetry optIn to default to true (elastic#50490) [Maps] make grid rectangles the default symbolization for geo grid source (elastic#50169) Allow registered applications to hide Kibana chrome (elastic#49795) Upgrade EUI to v14.9.0 (elastic#49678) [Metrics UI] Convert layouts to use React components (elastic#49134) [Search service] Add support for ES request preference (elastic#49424) [Newsfeed/Lint] fix chained fn lint (elastic#50515) [Monitoring] Fix logstash pipelines page in multi-cluster environment (elastic#50166) [SIEM] Events viewer fixes (elastic#50175) ...
|
Are you planning to backport this to |
|
Yes... must have gotten missed |
simianhacker
added a commit
to simianhacker/kibana
that referenced
this pull request
Nov 18, 2019
* Convert layouts to use React compontents - This PR closes elastic#48808 - Move all files under pages/metrics * Renaming layout files; Fixing some types; Removing unused types * Fixing naming issue * Fixing path * Fixing i18n stuff * [Metrics UI] Move toolbars under inventory models * Fixing imports; wrapping code in useMemo to optimize * removing unused imports * Removing prototype page
simianhacker
added a commit
that referenced
this pull request
Nov 18, 2019
* Convert layouts to use React compontents - This PR closes #48808 - Move all files under pages/metrics * Renaming layout files; Fixing some types; Removing unused types * Fixing naming issue * Fixing path * Fixing i18n stuff * [Metrics UI] Move toolbars under inventory models * Fixing imports; wrapping code in useMemo to optimize * removing unused imports * Removing prototype page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR closes #48808 by converting the JSON layouts to components. From a visual perspective nothing should change. From a code perspective, I moved everything under
public/pages/metricsincluding all thecomponentsandcontainers. I also deleted a bunch of files that are now obsolete. This should make it easier to find everything related to the metrics page. This PR also moves theToolbarItemsinto the inventory models.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosThis was checked for keyboard-only and screenreader accessibility