Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Link to potential docs page #49670

Merged
merged 1 commit into from
Oct 29, 2019
Merged

[Lens] Link to potential docs page #49670

merged 1 commit into from
Oct 29, 2019

Conversation

wylieconlon
Copy link
Contributor

This uses the docs page from #47140 and connects it to the help link:

Screenshot 2019-10-29 15 45 35

@wylieconlon wylieconlon added Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Lens v7.5.0 v7.6.0 labels Oct 29, 2019
@wylieconlon wylieconlon requested review from chrisdavies and a team October 29, 2019 19:46
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@KOTungseth
Copy link
Contributor

To keep terms consistent across the UI and docs, could we change the message to:

Provide feedback on Lens

chrisdavies
chrisdavies approved these changes Oct 29, 2019
View reviewed changes
Copy link
Contributor

@chrisdavies chrisdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I don't see the need for a const. Could just inline it. But no biggie.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@wylieconlon
Copy link
Contributor Author

I didn't make any changes, and this is what it looks like when merged with master:

Screenshot 2019-10-29 17 42 36

Given that this is how it looks locally, I will be merging as-is.

@wylieconlon wylieconlon merged commit c353651 into elastic:master Oct 29, 2019
@wylieconlon wylieconlon deleted the lens/add-docs-link branch October 29, 2019 21:43
This was referenced Oct 29, 2019
Merged
Merged
wylieconlon pushed a commit to wylieconlon/kibana that referenced this pull request Oct 29, 2019
@wylieconlon
[Lens] Link to potential docs page (elastic#49670)
cea17fd
wylieconlon pushed a commit to wylieconlon/kibana that referenced this pull request Oct 29, 2019
@wylieconlon
[Lens] Link to potential docs page (elastic#49670)
ec3bb34
wylieconlon pushed a commit that referenced this pull request Oct 29, 2019
[Lens] Link to potential docs page (#49670) (#49689)
fa0106b
wylieconlon pushed a commit that referenced this pull request Oct 30, 2019
[Lens] Link to potential docs page (#49670) (#49690)
398becc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisdavies chrisdavies chrisdavies approved these changes

Assignees
No one assigned
Labels
Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.5.0 v7.6.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wylieconlon @elasticmachine @KOTungseth @chrisdavies