Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move generateFilters ⇒ NP #50118

Merged
merged 14 commits into from
Nov 14, 2019
Merged

Move generateFilters ⇒ NP #50118

merged 14 commits into from
Nov 14, 2019

Conversation

lizozom
Copy link
Contributor

@lizozom lizozom commented Nov 10, 2019 •
edited by rayafratkina
Loading

Summary

Moved filter generator to NP.

Also:\

  • Deleted unused file doc_table/actions/filter
  • Replaced usage of queryFilter with filterManager in query_parameters/actions.js

Dev Docs

Filter generator is now available a a utility function in the data plugin.

import { generateFilters } from '../plugins/data/public';
const { filterManager } = plugins.data.query;

const filters = generateFilters(filterManager, field, values, negate, indexString);

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@lizozom lizozom requested a review from a team as a code owner November 10, 2019 15:22
@lizozom lizozom self-assigned this Nov 10, 2019
@lizozom lizozom added release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. Feature:NP Migration Team:AppArch v7.6.0 v8.0.0 labels Nov 10, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@lizozom lizozom mentioned this pull request Nov 10, 2019
Closed
26 tasks
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@lizozom lizozom mentioned this pull request Nov 12, 2019
Merged
7 tasks
@lizozom
Copy link
Contributor Author

lizozom commented Nov 12, 2019

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💔 Build Failed

@lizozom
Copy link
Contributor Author

lizozom commented Nov 13, 2019

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

ppisljar
ppisljar approved these changes Nov 14, 2019
View reviewed changes
Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@lizozom lizozom merged commit 6219cfd into elastic:master Nov 14, 2019
@lizozom lizozom mentioned this pull request Nov 14, 2019
Merged
lizozom pushed a commit to lizozom/kibana that referenced this pull request Nov 14, 2019
Moved filter generator ⇒ NP (elastic#50118)
f9ab207 
* Moved filter generator to NP

* Deleted unused test

* Fixed browser test + fix to discover actions

* Added jsdcos
lizozom pushed a commit that referenced this pull request Nov 14, 2019
[7.x] Moved filter generator ⇒ NP (#50118) (#50655)
f2029be 
* Moved filter generator ⇒ NP (#50118)

* Moved filter generator to NP

* Deleted unused test

* Fixed browser test + fix to discover actions

* Added jsdcos

* eslint
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@lizozom lizozom changed the title Moved filter generator ⇒ NP Moved generateFilters ⇒ NP Jan 12, 2020
@lizozom lizozom changed the title Moved generateFilters ⇒ NP Move generateFilters ⇒ NP Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppisljar ppisljar ppisljar approved these changes

Assignees

@lizozom lizozom

Labels
Feature:NP Migration release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. v7.6.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lizozom @elasticmachine @ppisljar