Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [SIEM] [Detection Engine] Adds Rules Table (#50839) #51380

Merged
merged 2 commits into from
Nov 22, 2019

Conversation

spong
Copy link
Member

@spong spong commented Nov 21, 2019

Backports the following commits to 7.x:

This PR wires up the Detection Engine Rules Table and provides the following features:
 * [x] Lists all rules for a given user/space
 * [x] Search/Filtering via `Rule Name`
 * [x] Sorting via `Activate`
 * [x] Pagination
 * [x] Enable/Disable Action
 * [x] Rule Selection / Batch Actions
 * [x] Rule Import w/ validation via `io-ts`
 * [x] Batch Actions
   * [x] Activate selected
   * [x] Deactivate selected
   * [x] Export selected (as `.ndjson`)
   * [ ] ~Edit selected index patterns...~ (Waiting on supported feature)
   * [x] Delete selected
 * [x] Individual Overflow Actions
   * [ ] ~Edit rule settings~ (Waiting on supported feature)
   * [ ] ~Run rule manually...~ (Waiting on supported feature)
   * [x] Duplicate rule...
   * [X] Export rule
   * [x] Delete rule...

![sort_and_filter](https://user-images.githubusercontent.com/2946766/69286404-641d1a80-0bb0-11ea-9930-8eada88b36f6.gif)

![import_and_export](https://user-images.githubusercontent.com/2946766/69286806-79df0f80-0bb1-11ea-99c5-92df0a706f0e.gif)

![import_failed_validation](https://user-images.githubusercontent.com/2946766/69286797-72b80180-0bb1-11ea-9397-71fa0ff0b203.gif)

![batch_activate_deactivate](https://user-images.githubusercontent.com/2946766/69287019-0093ec80-0bb2-11ea-8320-57cc7fec27a8.gif)

![batch_delete](https://user-images.githubusercontent.com/2946766/69287139-6e401880-0bb2-11ea-948c-c5b92ba90e6f.gif)

![dupe_and_delete](https://user-images.githubusercontent.com/2946766/69287143-74ce9000-0bb2-11ea-88b3-db75f66ba666.gif)

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

- [x] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)
- [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)
- [ ] ~[Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~ --
  * Will work with @benskelker on overall Detection Engine documentation
- [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
  * Includes basic tests -- will expand coverage as features solidify
- [ ] ~This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~

- [ ] ~This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~
- [ ] ~This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~
@spong spong added the backport label Nov 21, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

@spong
Copy link
Member Author

spong commented Nov 21, 2019

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@spong spong merged commit ab9c3b0 into elastic:7.x Nov 22, 2019
@spong spong deleted the backport/7.x/pr-50839 branch November 22, 2019 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants