Moves Task manager's interval under a generic schedule field #52727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… whole mocking library
…o task-manager/run-now
|
@elasticmachine merge upstream |
gmmorris
added
the
Team:ResponseOps
mikecote
approved these changes
Dec 16, 2019
| @@ -14,7 +14,9 @@ import { | |||
| RangeBoolClause, | |||
| } from './query_clauses'; | |||
|
|
|||
| export const RecuringTaskWithInterval: ExistsBoolClause = { exists: { field: 'task.interval' } }; | |||
| export const TaskWithRecurringSchedule: ExistsBoolClause = { | |||
There was a problem hiding this comment.
No a nit at all, we changed that name and I missed it :)
Thanks!
| @@ -91,7 +94,7 @@ export function initRoutes(server, taskTestingEvents) { | |||
| payload: Joi.object({ | |||
| task: Joi.object({ | |||
| taskType: Joi.string().required(), | |||
| interval: Joi.string().optional(), | |||
| schedule: Joi.string().optional(), | |||
There was a problem hiding this comment.
Suggested change
| schedule: Joi.string().optional(), | |
| schedule: Joi.object({ | |
| interval: Joi.string(), | |
| }).optional(), |
There was a problem hiding this comment.
eek why wasn't that caught by functional test?? Investigating
There was a problem hiding this comment.
ahhh because we don't send a new interval on the ensure api call.... that's why.
There was a problem hiding this comment.
We don't need that in that API call (our type ensures this is in the actual TM) in our FTs so this'll be removed
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Dec 17, 2019
…#52727) This moves the interval field under a generic schedule object field in preparation for the introduction of richer scheduling options (such as cron). It includes a migration for existing tasks, and we've ensured no existing Task Type Definitions exist in Kibana that rely on Interval. This includes support for the deprecated interval field (which gets mapped to schedule) but that support will be removed in 8.0.0, as it's a breaking change.
gmmorris
added a commit
that referenced
this pull request
Dec 17, 2019
…#53295) This moves the interval field under a generic schedule object field in preparation for the introduction of richer scheduling options (such as cron). It includes a migration for existing tasks, and we've ensured no existing Task Type Definitions exist in Kibana that rely on Interval. This includes support for the deprecated interval field (which gets mapped to schedule) but that support will be removed in 8.0.0, as it's a breaking change.
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Dec 18, 2019
…lastic#52873) Follow up from the elastic#52727 in Task Manager, we want Alerting and Task Manager to align on their schedule api (in the near future, Alerting will actually use Task manager's schedule system to remove this duplication).
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This moves the
intervalfield under a genericscheduleobject field in preparation for the introduction of richer scheduling options (such as cron).It includes a migration for existing tasks, and we've ensured no existing Task Type Definitions exist in Kibana that rely on Interval.
This includes support for the deprecated
intervalfield (which gets mapped toschedule) but that support will be removed in 8.0.0, as it's a breaking change.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportUnit or functional tests were updated or added to match the most common scenariosThis was checked for keyboard-only and screenreader accessibilityFor maintainers