[WIP][APM]Show errors on the timeline instead of under the transaction #52852
Conversation
…sactionById from API.
| } | ||
|
|
||
| interface IWaterfallItemTransaction extends IWaterfallItemBase { | ||
| transaction: Transaction; | ||
| trace: Transaction; // TODO: check this name |
There was a problem hiding this comment.
@sqren I removed most of the properties from getTransactionItem and getSpanItem, and replaced it by the real Transaction and Span. But I changed the name to trace because there are some common properties between them. So I don't have to check the type every time. I can simply do item.trace.timestamp.us.
I'd like to have your insights about this change and about the name trace, don't know if this is the best.
There was a problem hiding this comment.
I think doc is better than trace. trace is normally a list (tree?) or transactions/spans. Whereas this is the actual elasticsearch document for either a span or a transaction.
It also aligns well with docType.
| * start timestamp in us | ||
| */ | ||
| timestamp: number; | ||
| parent?: IWaterfallItem; |
There was a problem hiding this comment.
I added the parent here to remove the getTransactionById from the returned object.
| // the traceroot cannot be found, so we cannot link to it | ||
| if (!waterfall.traceRoot) { | ||
| const { rootTransaction } = waterfall; | ||
| // the traceRootTransaction cannot be found, so we cannot link to it |
There was a problem hiding this comment.
| // the traceRootTransaction cannot be found, so we cannot link to it | |
| // the rootTransaction cannot be found, so we cannot link to it |
| return <EuiIcon type="globe" />; | ||
| } | ||
|
|
||
| // icon for other transactions | ||
| return <EuiIcon type="merge" />; | ||
| // icon for RUM agent transactions |
| } | ||
|
|
||
| interface IWaterfallItemTransaction extends IWaterfallItemBase { | ||
| transaction: Transaction; | ||
| trace: Transaction; // TODO: check this name |
There was a problem hiding this comment.
I think doc is better than trace. trace is normally a list (tree?) or transactions/spans. Whereas this is the actual elasticsearch document for either a span or a transaction.
It also aligns well with docType.
💔 Build FailedTo update your PR or re-run it, just comment with: |
closes #45619