Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grunt config variable name userScriptsDir #5306

Closed
wants to merge 1 commit into from

Conversation

stdweird
Copy link
Contributor

@stdweird stdweird commented Nov 4, 2015

As defined/used in osPackages.js

As defined/used in `osPackages.js`
@elasticsearch-release
Copy link

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'.

@stdweird
Copy link
Contributor Author

stdweird commented Nov 4, 2015

i'm trying to build rpms for 4.2 using grunt build _build:pleaseRun _build:osPackages
the pleaseRun fails without this patch

@stdweird
Copy link
Contributor Author

stdweird commented Nov 4, 2015

probably also need to be applied against master branch

@spalger
Copy link
Contributor

spalger commented Nov 4, 2015

@stdweird have you signed the CLA? I'm not seeing any signatures with your github username or email on my side.

@stdweird
Copy link
Contributor Author

stdweird commented Nov 4, 2015

@spalger i don't understand what you mean. i used the github web editor to create this PR.

@spalger
Copy link
Contributor

spalger commented Nov 4, 2015

Ah, okay. All contributors to the project must sign the CLA before we can merge their changes.

@stdweird stdweird closed this Nov 5, 2015
@stdweird
Copy link
Contributor Author

stdweird commented Nov 5, 2015

replaced by #5322

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants