Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Move agg_types into data shim plugin #53744

Closed
wants to merge 21 commits into from
Closed

WIP: Move agg_types into data shim plugin #53744

wants to merge 21 commits into from

Conversation

lukeelmers
Copy link
Member

No description provided.

@lukeelmers
Move ui/public/courier files to core_plugins/data/public
cdd9705
@lukeelmers
Add search service definition to shim.
ae3e232
@lukeelmers
Fix internal imports.
6bd2b1c
@lukeelmers
Update SASS import.
6128be3
@lukeelmers
Update ui/public imports & add missing ones.
1908425
@lukeelmers
Finish cleaning up data plugin imports.
127dd06
@lukeelmers
Make sure agg_types are using SearchSourceContract.
f9b38c9
@lukeelmers
Revert bad IndexPatterns interface changes.
89b715b
@lukeelmers
Update translation IDs.
6eae078
@lukeelmers
Add default search strategy.
ac1403b
@lukeelmers
Fix jest tests.
ca64402
@lukeelmers
Add comment on legacy mock.
5ae213e
@lukeelmers
Rename SearchSourceContract -> ISearchSource.
0efa388
@lukeelmers
Add all public agg_type items to agg_types/index
0202d03
@lukeelmers
Copy entire ui/agg_types directory to legacy data plugin's search ser…
661b861 
…vice.
@lukeelmers
Update agg_type imports.
55b0100
@lukeelmers
Export static code and types from data plugin.
baf2ce8
@lukeelmers
Export runtime services from data plugin start.
f86aa0f
@lukeelmers
Re-export public contract from ui/agg_types.
2feb69a
@lukeelmers
Delete old ui/agg_types files, and re-export contracts where needed.
4a04087
@lukeelmers
Update translation IDs.
436b33c
@lukeelmers
Copy link
Member Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

merge conflict between base and head

@kibanamachine
Copy link
Contributor

💔 Build Failed

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@streamich streamich added Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) Feature:NP Migration Team:AppArch labels Feb 7, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@lukeelmers
Copy link
Member Author

This was addressed in #56353

@lukeelmers lukeelmers closed this Feb 10, 2020
@lukeelmers lukeelmers deleted the aggtypes/move branch February 10, 2020 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) Feature:NP Migration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lukeelmers @elasticmachine @kibanamachine @streamich