Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discover a11y tests #54209

Merged
merged 9 commits into from
Jan 13, 2020
Merged

Discover a11y tests #54209

merged 9 commits into from
Jan 13, 2020

Conversation

bhavyarm
Copy link
Contributor

@bhavyarm bhavyarm commented Jan 7, 2020 •
edited
Loading

Contains tests for menu actions including including side column
#51456

@bhavyarm bhavyarm requested a review from myasonik January 7, 2020 23:48
@bhavyarm
Copy link
Contributor Author

bhavyarm commented Jan 7, 2020

@myasonik I am getting ```warn
│ UNABLE TO VALIDATE
│ [aria-valid-attr-value]: Ensures all ARIA attributes have valid values
│ Help: https://dequeuniversity.com/rules/axe/3.3/aria-valid-attr-value?application=axeAPI
│ Elements:
│ - .euiPopover__panel

Also savedObjectFinderSearchInput has a violation for missing label.

@bhavyarm bhavyarm self-assigned this Jan 7, 2020
@bhavyarm bhavyarm added v8.0.0 Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes Feature:Discover Discover Application labels Jan 7, 2020
@bhavyarm bhavyarm mentioned this pull request Jan 7, 2020
Open
77 tasks
@myasonik
Copy link
Contributor

myasonik commented Jan 8, 2020

Thoughts on removing the failures it's unable to validate?

Seems like that's just the manual testing we already do...

@bhavyarm bhavyarm requested a review from a team as a code owner January 10, 2020 22:39
@bhavyarm
Copy link
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

merge conflict between base and head

@bhavyarm
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@bhavyarm bhavyarm merged commit f3cdbf2 into elastic:master Jan 13, 2020
@bhavyarm bhavyarm mentioned this pull request Jan 13, 2020
Merged
bhavyarm added a commit to bhavyarm/kibana that referenced this pull request Jan 13, 2020
@bhavyarm
Discover a11y tests (elastic#54209)
c364db0 
Comprehensive discover a11y tests
bhavyarm added a commit that referenced this pull request Jan 14, 2020
@bhavyarm @elasticmachine
Discover a11y tests (#54209) (#54632)
e9fc194 
Comprehensive discover a11y tests

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jkelastic pushed a commit to jkelastic/kibana that referenced this pull request Jan 17, 2020
@bhavyarm @jkelastic
Discover a11y tests (elastic#54209)
ee8dc33 
Comprehensive discover a11y tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lizozom lizozom lizozom approved these changes

@myasonik myasonik myasonik approved these changes

Assignees

@bhavyarm bhavyarm

Labels
Feature:Discover Discover Application Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bhavyarm @myasonik @elasticmachine @kibanamachine @lizozom