Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logs UI] Fix z-index of logs page toolbar #54469

Merged
merged 6 commits into from
Jan 20, 2020
Merged

[Logs UI] Fix z-index of logs page toolbar #54469

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
06f0a37
Fix z-index of logs page toolbar
Jan 10, 2020
19620cd
Merge branch 'master' into 54449-log-datepicker-z-index
elasticmachine Jan 13, 2020
4db7427
Extract `FixedDatePicker` from log setup page, and use it in the stre…
Jan 17, 2020
7030277
Merge branch 'master' into 54449-log-datepicker-z-index
elasticmachine Jan 17, 2020
a92809c
Clean unused import
Jan 20, 2020
aaff4f4
Merge branch 'master' into 54449-log-datepicker-z-index
Jan 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions x-pack/legacy/plugins/infra/public/pages/logs/stream/page_toolbar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,14 @@ import { LogFilterState } from '../../../containers/logs/log_filter';
import { LogPositionState } from '../../../containers/logs/log_position';
import { Source } from '../../../containers/source';
import { WithKueryAutocompletion } from '../../../containers/with_kuery_autocompletion';
import euiStyled from '../../../../../../common/eui_styled_components';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not used anymore.


// We need to raise the z-index of the toolbar, so the datepicker inside is
// above the table header of the log stream.
const LogsToolbarWrapper = euiStyled(Toolbar)`
position: relative;
z-index: 2
`;

export const LogsToolbar = () => {
const { createDerivedIndexPattern } = useContext(Source.Context);
Expand Down Expand Up @@ -62,7 +70,7 @@ export const LogsToolbar = () => {
stopLiveStreaming,
} = useContext(LogPositionState.Context);
return (
<Toolbar>
<LogsToolbarWrapper>
<EuiFlexGroup alignItems="center" justifyContent="spaceBetween" gutterSize="s">
<EuiFlexItem>
<WithKueryAutocompletion indexPattern={derivedIndexPattern}>
Expand Down Expand Up @@ -133,6 +141,6 @@ export const LogsToolbar = () => {
/>
</EuiFlexItem>
</EuiFlexGroup>
</Toolbar>
</LogsToolbarWrapper>
);
};