Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip flakey index template component integration tests. #54878

Merged
merged 2 commits into from
Jan 15, 2020

Conversation

cjcenizal
Copy link
Contributor

@cjcenizal cjcenizal commented Jan 15, 2020

Fixes these intermittent failures:

05:06:30  Summary of all failing tests
05:06:30   FAIL  legacy/plugins/index_management/__jest__/client_integration/template_edit.test.tsx (5.358s)
05:06:30    ● <TemplateEdit /> › with mappings › form payload › should send the correct payload with changed values
05:06:30  
05:06:30      expect(received).toEqual(expected) // deep equality
05:06:30  
05:06:30      Expected: 1
05:06:30      Received: 0
05:06:30  
05:06:30        148 |           component.update();
05:06:30        149 |           // verify edit field flyout
05:06:30      > 150 |           expect(find('mappingsEditorFieldEdit').length).toEqual(1);
05:06:30            |                                                          ^
05:06:30        151 |           // change field name
05:06:30        152 |           form.setInputValue('nameParameterInput', UPDATED_MAPPING_TEXT_FIELD_NAME);
05:06:30        153 |           // Save changes
05:06:30  
05:06:30        at legacy/plugins/index_management/__jest__/client_integration/template_edit.test.tsx:150:58
05:06:30  
05:06:30    ● <TemplateEdit /> › with mappings › form payload › should send the correct payload with changed values
05:06:30  
05:06:30      Method “simulate” is meant to be run on 1 node. 0 found instead.
05:06:30  
05:06:30        32 | 
05:06:30        33 |   const clickSubmitButton = () => {
05:06:30      > 34 |     testBed.find('submitButton').simulate('click');
05:06:30           |                                  ^
05:06:30        35 |   };
05:06:30        36 | 
05:06:30        37 |   const clickEditButtonAtField = (index: number) => {
05:06:30  
05:06:30        at ReactWrapper.single (../node_modules/enzyme/src/ReactWrapper.js:1166:13)
05:06:30        at ReactWrapper.simulate (../node_modules/enzyme/src/ReactWrapper.js:665:17)
05:06:30        at Object.clickSubmitButton (legacy/plugins/index_management/__jest__/client_integration/helpers/template_form.helpers.ts:34:34)
05:06:30        at legacy/plugins/index_management/__jest__/client_integration/template_edit.test.tsx:171:19
05:06:30        at batchedUpdates$1 (../node_modules/react-dom/cjs/react-dom.development.js:24386:12)
05:06:30        at act (../node_modules/react-dom/cjs/react-dom-test-utils.development.js:1092:14)
05:06:30        at Object.it (legacy/plugins/index_management/__jest__/client_integration/template_edit.test.tsx:170:15)

@cjcenizal cjcenizal added chore Feature:Index Management Index and index templates UI v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.6.0 backport:skip This commit does not require backporting labels Jan 15, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@cjcenizal cjcenizal added release_note:skip Skip the PR/issue when compiling release notes and removed backport:skip This commit does not require backporting labels Jan 15, 2020
@cjcenizal
Copy link
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

user doesn't have permission to update head repository

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cjcenizal cjcenizal merged commit 33713cb into elastic:master Jan 15, 2020
@cjcenizal cjcenizal deleted the skip-flakey-index-template-tests branch January 15, 2020 10:28
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 15, 2020
* upstream/master: (72 commits)
  [ML] Calculate model memory limit API integration tests (elastic#54557)
  Skip flakey index template component integration tests. (elastic#54878)
  Add label and icon to nested fields in the doc table (elastic#54199)
  Reverse dependency of home plugin and apm/ml/cloud (elastic#52883)
  [SIEM][Detection Engine] Order JSON keys, fix scripts, update pre-packaged rules
  update invalid snapshot
  add readme note about alerting / manage_api_key cluster privilege (elastic#54639)
  [SIEM] New Overview Page (elastic#54783)
  [Uptime] Feature/refactor context initialization (elastic#54494)
  Upgrade EUI to v18.2.0 (elastic#54786)
  [SIEM] [Detection engine] from signals to timeline (elastic#54769)
  [Index Management] Add Mappings Editor to Index Template Wizard (elastic#47562)
  [SIEM][Detection Engine] Removes deprecated filter from mapping
  [Maps] Add categorical styling (elastic#54408)
  Add mapbox-gl-rtl-text library (elastic#54842)
  [SIEM][Detection Engine] Adds actions to Rule Details (elastic#54828)
  Lexicographically sort location tags (elastic#54832)
  [Maps] expand extent filter to tile boundaries (elastic#54276)
  [Maps] Use v7.6 Elastic Maps Service API (elastic#54399)
  [DOCS] Adds monitoring setting (elastic#54819)
  ...
jkelastic pushed a commit to jkelastic/kibana that referenced this pull request Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Feature:Index Management Index and index templates UI release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.6.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants