Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Storybook support #54970

Merged
merged 1 commit into from
Jan 16, 2020
Merged

[APM] Storybook support #54970

merged 1 commit into from
Jan 16, 2020

Conversation

smith
Copy link
Contributor

@smith smith commented Jan 15, 2020

Add Storybook with help from changes in #43529.

We still need to do some work around having mocks for hooks and HTTP requests but the basics are there.

    Add Storybook with help from changes in elastic#43529.

    We still need to do some work around having mocks for hooks and HTTP requests but the basics are there.
@smith smith requested review from a team as code owners January 15, 2020 21:39
Copy link
Contributor

@ogupte ogupte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!

@smith smith added release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Jan 15, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dgieselaar
Copy link
Member

awesome!

@smith smith merged commit e60289f into elastic:master Jan 16, 2020
@smith smith deleted the nls/apm-storybook branch January 16, 2020 15:27
jkelastic pushed a commit to jkelastic/kibana that referenced this pull request Jan 17, 2020
Add Storybook with help from changes in elastic#43529.

    We still need to do some work around having mocks for hooks and HTTP requests but the basics are there.
smith added a commit to smith/kibana that referenced this pull request Jan 30, 2020
Add Storybook with help from changes in elastic#43529.

    We still need to do some work around having mocks for hooks and HTTP requests but the basics are there.
smith added a commit that referenced this pull request Jan 31, 2020
Add Storybook with help from changes in #43529.

    We still need to do some work around having mocks for hooks and HTTP requests but the basics are there.
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jan 31, 2020
…56356

* '7.x' of github.com:elastic/kibana: (23 commits)
  Fix setting filters without $store value (elastic#56304) (elastic#56475)
  [ML] Fix Data Visualizer responsive layout  (elastic#56372) (elastic#56472)
  [ML] conditional rison encoding for query params (elastic#56380) (elastic#56469)
  kuery_autocomplete -> convert remaining items to TS/Jest (elastic#56316) (elastic#56471)
  [APM] Fit service map to container (elastic#56336) (elastic#56463)
  Add animation to service map layout (elastic#56042) (elastic#56460)
  chore(NA): delete data/optimize with kbn clean (elastic#55890) (elastic#56422)
  [APM] Storybook support (elastic#54970) (elastic#56445)
  [DOCS] Updates example in Timelion doc (elastic#56444) (elastic#56454)
  [Logs UI] Fix Check for New Data button on empty indices screen (elastic#56239) (elastic#56320)
  [DOCS] Adds breaking changes for 7.6 (elastic#56437)
  [Monitoring] Change all configs to `monitoring.*` (elastic#56215) (elastic#56421)
  [skip-ci] Add example for migrating pre-handlers (elastic#56080) (elastic#56436)
  [7.x] System index templates can't be edited (elastic#55229) (elastic#56417)
  Add missing docker settings (elastic#56411)
  [Uptime] Use dynamic index pattern in Uptime (elastic#55446) (elastic#56386)
  fix edit rule for detections (elastic#56333) (elastic#56405)
  [Filter Bar] Remove flickering when opening filter bar popover (elastic#56222) (elastic#56385)
  [ILM] Index Lifecycle Policies show wrong unit in Kibana UI (elastic#55228) (elastic#55757)
  Move tsvb server to new platform (elastic#55310) (elastic#56394)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants