[Uptime] Handle locations with names but no geo data #55234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinkambic
added
bug
|
Pinging @elastic/uptime (Team:uptime) |
justinkambic
force-pushed
the
uptime_fix-named-location-with-missing-lat-lon
branch
from
f40ece0 to
4670f24
Compare
|
@elasticmachine merge upstream |
shahzad31
reviewed
Jan 21, 2020
| @@ -5,7 +5,7 @@ | |||
| */ | |||
|
|
|||
| import lowPolyLayerFeatures from './low_poly_layer.json'; | |||
| import { LocationPoint } from './embedded_map'; | |||
| import { LocationPoint } from './embedded_map.js'; | |||
There was a problem hiding this comment.
My editor automatically did that.. I don't know what the typical convention is but I've seen it elsewhere in Kibana too.
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
|
@justinkambic overall looks good, just left one comment. |
shahzad31
approved these changes
Jan 21, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jan 22, 2020
* master: (38 commits) [ML] Fix counters and percentages for array fields on the Data visualizer page (elastic#55209) [SIEM][Detection Engine] Tags being turned into null rules part deux (elastic#55507) [DOCS] Add tip for using elasticsearch-certutil http command (elastic#55357) [SIEM][Detection Engine] Critical blocker, fixes schema accepting values it should not (elastic#55488) [SIEM] Detections create prepackage rules (elastic#55403) [Reporting] Convert CSV Export libs to Typescript (elastic#55117) [Maps] show field type icons in data driven styling field select (elastic#55166) Adds event log for actions and alerting (elastic#45081) [SIEM][Detection Engine] Fixes critical blocker where signals on signals are not operating [SIEM][Detection Engine] Critical blocker, adds need REST prefix for cloud remove incorrect config (elastic#55427) Retain pinned filters when loading and clearing saved queries (elastic#54307) Resolver zoom, pan, and center controls (elastic#55221) Skip failing endpoint saga tests [skip-ci] Update migration guide to add rendering service example (elastic#54744) [DOCS] Updates to heat map page (elastic#55097) [Endpoint] Fix saga to start only after store is created and stopped on app unmount (elastic#55245) [Logs UI] Use the correct icons and labels in the feature cont… (elastic#55292) [Uptime] Handle locations with names but no geo data (elastic#55234) ...
This was referenced Jan 24, 2020
justinkambic
added a commit
to justinkambic/kibana
that referenced
this pull request
Jan 24, 2020
* Handle locations with names but no geo data. * Fix broken types, add a comment explaining some weird ts-related code. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
justinkambic
added a commit
to justinkambic/kibana
that referenced
this pull request
Jan 24, 2020
* Handle locations with names but no geo data. * Fix broken types, add a comment explaining some weird ts-related code. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
justinkambic
added a commit
that referenced
this pull request
Jan 24, 2020
* Handle locations with names but no geo data. * Fix broken types, add a comment explaining some weird ts-related code. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
justinkambic
added a commit
that referenced
this pull request
Jan 24, 2020
* Handle locations with names but no geo data. * Fix broken types, add a comment explaining some weird ts-related code. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
justinkambic
deleted the
uptime_fix-named-location-with-missing-lat-lon
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #55233.
Testing this PR
Configure a monitor in heartbeat that has a location name, but no geo coordinates. You can ensure is configured correctly by running
masterwithout this patch against that data set.Navigate to the monitor page and ensure that you're prompted to add location data, but are not shown any points on the map. Other location-specific data should be present. See screenshot below.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers