Don't render map icons in IE 11 #55848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As reported in elastic#55184, the service map is completely broken in IE. This is because IE has some bugs around SVG that cause a runtime error. This change detects IE 11 and does not render those problematic icons. The result is a map that has the shapes but no SVG icons in them: https://www.dropbox.com/s/o7hp73yv5klpfqd/Screenshot%202020-01-24%2009.27.54.png?dl=0 We'll follow up in a future release with a fix to show the icons, but this makes it so the map is functional in IE. Fixes elastic#55184.
smith
added
v7.7.0
release_note:skip
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
dgieselaar
approved these changes
Feb 5, 2020
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
smith
added a commit
to smith/kibana
that referenced
this pull request
Feb 5, 2020
As reported in elastic#55184, the service map is completely broken in IE. This is because IE has some bugs around SVG that cause a runtime error. This change detects IE 11 and does not render those problematic icons. The result is a map that has the shapes but no SVG icons in them: https://www.dropbox.com/s/o7hp73yv5klpfqd/Screenshot%202020-01-24%2009.27.54.png?dl=0 We'll follow up in a future release with a fix to show the icons, but this makes it so the map is functional in IE. Fixes elastic#55184. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
smith
added a commit
that referenced
this pull request
Feb 6, 2020
As reported in #55184, the service map is completely broken in IE. This is because IE has some bugs around SVG that cause a runtime error. This change detects IE 11 and does not render those problematic icons. The result is a map that has the shapes but no SVG icons in them: https://www.dropbox.com/s/o7hp73yv5klpfqd/Screenshot%202020-01-24%2009.27.54.png?dl=0 We'll follow up in a future release with a fix to show the icons, but this makes it so the map is functional in IE. Fixes #55184. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #55184, the service map is completely broken in IE. This is because IE has some bugs around SVG that cause a runtime error.
This change detects IE 11 and does not render those problematic icons.
The result is a map that has the shapes but no SVG icons in them:
#55849 has been created to make it so the icons load properly.
Fixes #55184.