Update CONTRIBUTING.md --ssl documentation to mention it covers Elasticsearch as well #55876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikecote
added
Team:Operations
|
Pinging @elastic/kibana-operations (Team:Operations) |
tylersmalley
approved these changes
Jan 24, 2020
💚 Build SucceededTo update your PR or re-run it, just comment with: |
mikecote
added a commit
to mikecote/kibana
that referenced
this pull request
Jan 24, 2020
…icsearch as well (elastic#55876) * Update CONTRIBUTING.md to mention --ssl flag works with Elasticsearch as well * Change while to for
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After facilitating Kibana to communicate to Elasticsearch over SSL (
yarn start --ssl&yarn es snapshot --ssl) #42840. I forgot to update theCONTRIBUTING.mddocument to reflect the mention that Elasticsearch SSL is also required.