Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.5] Update timelion.asciidocs #55993

Merged
merged 4 commits into from
Jan 30, 2020
Merged

[7.5] Update timelion.asciidocs #55993

merged 4 commits into from
Jan 30, 2020

Conversation

mMarzeta
Copy link

@mMarzeta mMarzeta commented Jan 27, 2020

Summary

Update docs to have a valid example of Timelion Network traffic visualization.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

- [ ] This was checked for cross-browser compatibility, including a check against IE11

- [ ] Documentation was added for features that require explanation or tutorials
- [ ] Unit or functional tests were updated or added to match the most common scenarios
- [ ] This was checked for keyboard-only and screenreader accessibility

For maintainers

[skip ci]

Update docs to have a valid example of Timelion Network traffic visualization.
@kibanamachine
Copy link
Contributor

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@mMarzeta mMarzeta requested a review from nik9000 January 27, 2020 12:30
@mMarzeta mMarzeta changed the title Update timelion.asciidocs [7.5] Update timelion.asciidocs Jan 27, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@nik9000 nik9000 removed their request for review January 27, 2020 15:22
Copy link
Member

@nik9000 nik9000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. At first I thought this wasn't for me to review but I think I was the one who broke it. So, yeah. +1

@gchaps
Copy link
Contributor

gchaps commented Jan 27, 2020

@mMarzeta Thank you for your contribution. Please sign our Contributor Agreement so that we can merge this change.

@mMarzeta mMarzeta requested a review from nik9000 January 29, 2020 09:08
@gchaps gchaps added release_note:skip Skip the PR/issue when compiling release notes v7.5.0 labels Jan 29, 2020
@gchaps
Copy link
Contributor

gchaps commented Jan 30, 2020

@elasticmachine merge upstream

@gchaps
Copy link
Contributor

gchaps commented Jan 30, 2020

run elasticsearch-ci/docs

@spalger
Copy link
Contributor

spalger commented Jan 30, 2020

@elasticmachine merge upstream

@spalger
Copy link
Contributor

spalger commented Jan 30, 2020

run elasticsearch-ci/docs

@gchaps gchaps merged commit e6d89f6 into elastic:7.5 Jan 30, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Docs v7.5.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants