Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SIEM] Fix filters on Hosts and Network page #56234

Merged
merged 3 commits into from
Jan 29, 2020
Merged

[SIEM] Fix filters on Hosts and Network page #56234

merged 3 commits into from
Jan 29, 2020

Conversation

patrykkopycinski
Copy link
Contributor

@patrykkopycinski patrykkopycinski commented Jan 28, 2020 •
edited
Loading

Summary

This PR fixes:

  • when accessing the Alerts tab on Hosts/Network page we were applying filters to the whole page instead of just tabs area
  • after styled-components bump styling for ConditionalFlexGroup has stopped working
  • we were hiding histogram when there was no data to show, but we still rendered EuiSpacer, so it caused an inconsistency in Anomalies tab

Thank you @XavierM for help with debugging the issue 🥇💪

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@patrykkopycinski patrykkopycinski added bug Fixes for quality problems that affect the customer experience v8.0.0 v7.6.0 labels Jan 28, 2020
@patrykkopycinski patrykkopycinski self-assigned this Jan 28, 2020
@patrykkopycinski patrykkopycinski added release_note:skip Skip the PR/issue when compiling release notes Team:SIEM labels Jan 28, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@XavierM
Copy link
Contributor

XavierM commented Jan 29, 2020

@elasticmachine merge upstream

XavierM
XavierM approved these changes Jan 29, 2020
View reviewed changes
Copy link
Contributor

@XavierM XavierM left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested locally

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@XavierM XavierM merged commit 0d2ac94 into elastic:master Jan 29, 2020
XavierM pushed a commit to XavierM/kibana that referenced this pull request Jan 29, 2020
@patrykkopycinski @elasticmachine @XavierM
[SIEM] Fix filters on Hosts and Network page (elastic#56234)
4df9a1c 
* [SIEM] Fix Hosts and Network Tabs filters

* cleanup

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@XavierM XavierM mentioned this pull request Jan 29, 2020
Merged
XavierM pushed a commit to XavierM/kibana that referenced this pull request Jan 29, 2020
@patrykkopycinski @elasticmachine @XavierM
[SIEM] Fix filters on Hosts and Network page (elastic#56234)
ebef88e 
* [SIEM] Fix Hosts and Network Tabs filters

* cleanup

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@XavierM XavierM mentioned this pull request Jan 29, 2020
Merged
XavierM added a commit that referenced this pull request Jan 29, 2020
@XavierM @patrykkopycinski @elasticmachine
[SIEM] Fix filters on Hosts and Network page (#56234) (#56267)
fe642ff 
* [SIEM] Fix Hosts and Network Tabs filters

* cleanup

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: patrykkopycinski <contact@patrykkopycinski.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
XavierM added a commit that referenced this pull request Jan 29, 2020
@XavierM @patrykkopycinski @elasticmachine
[SIEM] Fix filters on Hosts and Network page (#56234) (#56268)
cd41d4e 
* [SIEM] Fix Hosts and Network Tabs filters

* cleanup

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: patrykkopycinski <contact@patrykkopycinski.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 29, 2020
@gmmorris
Merge branch 'master' into alerting/details-ui
2961ecd 
* master: (31 commits)
  [SIEM] Overview page feedback (elastic#56261)
  refactor (elastic#56131)
  [NP Cleanup] Remove ui/public/inspector (elastic#55677)
  [SIEM] [TIMELINE] Only add endpoint logo when on event.module === endgame (elastic#56263)
  Basic Functionality Alert List (elastic#55800)
  [SIEM] Fix filters on Hosts and Network page (elastic#56234)
  [SIEM] Adds ability to infer the newsfeed.enabled setting (elastic#56236)
  [SIEM][Detection Engine] critical blocker for updated rules
  [SIEM][Detection Engine] critical blocker, fixes ordering issue that causes rules to not run the first time
  [SIEM] Add link to endpoint app through reference.url (elastic#56211)
  [Metrics UI] Fixing title truncation in Metrics Explorer (elastic#55917)
  [SIEM] Put the notice for rules in comment block (elastic#56123)
  [SIEM][Detection Engine] critical blocker with the UI crashing
  Consistent timeouts for the Space onPostAuth interceptor tests (elastic#56158)
  Skip tests that depend on other skipped test
  [SIEM] [Detection Engine] Timestamps for rules (elastic#56197)
  Sort server-side in SavedObject export (elastic#55128)
  [Reporting] Document the 8.0 breaking changes (elastic#56187)
  Revert "[Monitoring] Change all configs to `monitoring.*`" (elastic#56214)
  add owners for es_archiver (elastic#56184)
  ...
@patrykkopycinski patrykkopycinski deleted the fix/siem-alerts-table-filters branch January 29, 2020 10:14
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jan 29, 2020
@jloleysens
Merge branch '7.x' of github.com:elastic/kibana into backport/7.x/pr-…
e3a4775 
…55831

* '7.x' of github.com:elastic/kibana: (78 commits)
  Re-enable watcher FireFox functional test (elastic#56112) (elastic#56294)
  [Metrics UI] Fixing title truncation in Metrics Explorer (elastic#55917) (elastic#56248)
  [APM] x-axis labels on Error occurrences chart are incorrect based on Kibana timezone (elastic#55686) (elastic#56288)
  Migrate saved_object_save_as_checkbox directive to timelion (elastic#56114) (elastic#56286)
  [APM] Treat error.exception.stacktrace.line as optional (elastic#55733) (elastic#55840)
  Remove alerts and actions from feature catalogue (elastic#56140) (elastic#56208)
  Migrate UI capabilities to use new platform APIs (elastic#56070) (elastic#56207)
  [ML] Add functional tests for analytics UI: creation addition and regression/outlier results (elastic#56059) (elastic#56191)
  [SIEM] Overview page feedback (elastic#56261) (elastic#56276)
  [NP Cleanup] Remove ui/public/inspector (elastic#55677) (elastic#56271)
  [Index template] Fix editor should support mappings types (elastic#55804)
  fixes map index message (elastic#56104) (elastic#56194)
  [SIEM] [TIMELINE] Only add endpoint logo when on event.module === endgame (elastic#56263) (elastic#56269)
  [SIEM] Fix filters on Hosts and Network page (elastic#56234) (elastic#56267)
  [SIEM] Adds ability to infer the newsfeed.enabled setting (elastic#56236) (elastic#56265)
  [SIEM][Detection Engine] critical blocker for updated rules (elastic#56259)
  [SIEM] Put the notice for rules in comment block (elastic#56123) (elastic#56246)
  [SIEM][Detection Engine] critical blocker, fixes ordering issue that causes rules to not run the first time (elastic#56256)
  [Reporting/NP] Migration of Reporting Security dependency (elastic#56046) (elastic#56198)
  [SIEM] Add link to endpoint app through reference.url (elastic#56211) (elastic#56250)
  ...

# Conflicts:
#	x-pack/plugins/watcher/public/plugin.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XavierM XavierM XavierM approved these changes

@angorayc angorayc Awaiting requested review from angorayc

Assignees

@patrykkopycinski patrykkopycinski

Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:SIEM v7.6.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@patrykkopycinski @elasticmachine @XavierM @kibanamachine