Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mappings editor] Bring improvements from #55804 PR to master #56282

Merged
merged 3 commits into from
Jan 30, 2020
Merged

[Mappings editor] Bring improvements from #55804 PR to master #56282

merged 3 commits into from
Jan 30, 2020

Conversation

sebelga
Copy link
Contributor

@sebelga sebelga commented Jan 29, 2020

While working on the fix of the Template editor to support mappings types, I made a few improvements to the mappings editor (mainly tests and some small refactor).

This PR brings those improvements from the #55804 PR (targetting 7.x) to master.

@sebelga sebelga added Feature:Mappings Editor Index mappings editor UI release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Jan 29, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@sebelga sebelga changed the title Mappings editor/improvements from fix [Mappings editor] Bring improvements from #55804 PR to master Jan 29, 2020
@sebelga sebelga added the v8.0.0 label Jan 29, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cjcenizal
cjcenizal approved these changes Jan 29, 2020
View reviewed changes
Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, didn't test locally.

@sebelga
Copy link
Contributor Author

sebelga commented Jan 30, 2020

Thanks for the review @cjcenizal !

@sebelga sebelga merged commit ae9cbfc into elastic:master Jan 30, 2020
@sebelga sebelga deleted the mappings-editor/improvements-from-fix branch January 30, 2020 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcenizal cjcenizal cjcenizal approved these changes

Assignees
No one assigned
Labels
Feature:Mappings Editor Index mappings editor UI release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sebelga @elasticmachine @kibanamachine @cjcenizal