Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Watcher] Follow up on flaky functional test #56384

Merged
merged 5 commits into from
Jan 30, 2020
Merged

[Watcher] Follow up on flaky functional test #56384

merged 5 commits into from
Jan 30, 2020

Conversation

jloleysens
Copy link
Contributor

@jloleysens jloleysens commented Jan 30, 2020 •
edited
Loading

Summary

See the original flaky issue: #56014

First fix attempt: #56112

Additional context

Will try one more fix, before just disabling the test for now.

@jloleysens jloleysens added Feature:Watcher v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Jan 30, 2020
@jloleysens jloleysens requested a review from Dosant January 30, 2020 14:03
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@jloleysens jloleysens mentioned this pull request Jan 30, 2020
Closed
Dosant
Dosant approved these changes Jan 30, 2020
View reviewed changes
Copy link
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just for the record, some fails:

#56361
#56304

@jloleysens jloleysens changed the title Skip (still) flaky watcher FF test [Watcher] Follow up on flaky functional test Jan 30, 2020
@jloleysens jloleysens merged commit ed9cf94 into elastic:master Jan 30, 2020
@jloleysens jloleysens deleted the fix/watcher/skip-flaky-ff branch January 30, 2020 15:31
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jan 30, 2020
@jloleysens
[Watcher] Follow up on flaky functional test (elastic#56384)
b5fb29e 
* Skip flaky watcher FF test

* Give a bit more time for machines on CI

* Update watcher_test.js

* Revert "Update watcher_test.js"

This reverts commit 8a0289f.

* Revert "Give a bit more time for machines on CI"

This reverts commit d11228d.
This was referenced Jan 30, 2020
Merged
Merged
jloleysens added a commit that referenced this pull request Jan 30, 2020
@jloleysens
[Watcher] Follow up on flaky functional test (#56384) (#56392)
1d315e8 
* Skip flaky watcher FF test

* Give a bit more time for machines on CI

* Update watcher_test.js

* Revert "Update watcher_test.js"

This reverts commit 8a0289f.

* Revert "Give a bit more time for machines on CI"

This reverts commit d11228d.
@kibanamachine
Copy link
Contributor

💔 Build Failed

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

gmmorris added a commit to gmmorris/kibana that referenced this pull request Jan 31, 2020
@gmmorris
Merge branch 'master' into alerting/details-ui
467bbc4 
* master: (53 commits)
  Fix setting filters without $store value (elastic#56304)
  kuery_autocomplete -> convert remaining items to TS/Jest (elastic#56316)
  [Reporting] New Platform: moves most of our libs/constants and utils to np shims (elastic#55935)
  [reporting] remove a legacy cross-plugin import (elastic#56354)
  [DOCS] Updates example in Timelion doc (elastic#56444)
  [APM] Service map center button (elastic#56434)
  [skip-ci] Add example for migrating pre-handlers (elastic#56080)
  [ML] Fix Data Visualizer responsive layout  (elastic#56372)
  Add missing docker settings (elastic#56411)
  [Endpoint] Add Endpoint Details route (elastic#55746)
  chore(NA): delete data/optimize with kbn clean (elastic#55890)
  System index templates can't be edited (elastic#55229)
  Sync badge (elastic#55113)
  Only fire appState changes when there is a change (elastic#56183)
  Import appropriate files to setup plugin system at the correct time (elastic#55956)
  [Monitoring] Change all configs to `monitoring.*` (elastic#56215)
  [ML] conditional rison encoding for query params (elastic#56380)
  Move tsvb server to new platform (elastic#55310)
  exclude tutorial resources from code ownership (elastic#55987)
  [Watcher] Follow up on flaky functional test (elastic#56384)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dosant Dosant Dosant approved these changes

Assignees
No one assigned
Labels
Feature:Watcher release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jloleysens @elasticmachine @kibanamachine @Dosant