Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIEM] Fixes FTUE when APM node is present #56574

Merged
merged 4 commits into from
Feb 3, 2020

Conversation

spong
Copy link
Member

@spong spong commented Feb 1, 2020

Summary

This PR resolves #56363 found in 7.6 BC4, where configuring a cloud instance with an APM node would circumvent our FTUE checks and would show the Overview Page when no data is present.

As detailed in the above issue, this resolves the problem by performing a similar check as to what APM performs to determine their empty data state.

As can be observed in the gifs below, this check adds additional latency to the full-app flicker, which is not ideal... Perhaps we can tweak the query further to improve this?

Deployment w/o APM node:

ftue_no_apm

Deployment w/ APM node:

ftue_with_apm

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@spong spong added bug Fixes for quality problems that affect the customer experience Team:SIEM v8.0.0 v7.7.0 v7.6.0 labels Feb 1, 2020
@spong spong requested a review from XavierM February 1, 2020 01:38
@spong spong self-assigned this Feb 1, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@spong spong added the release_note:skip Skip the PR/issue when compiling release notes label Feb 1, 2020
@tsg
Copy link
Contributor

tsg commented Feb 1, 2020

About the flicker, does that mean that there's no extra delay on normal load? If yes, then I'd say that's a reasonable compromise, we want to optimize for the normal operation.

@XavierM
Copy link
Contributor

XavierM commented Feb 1, 2020

Not for this PR ;) I am wondering with the new platform life cycle set up and start if we can try to put this query/hook in the set up life cycle to get all this information when we have the Kibana loader. So when we start SIEM this query is already done with all the data need it.

@spong
Copy link
Member Author

spong commented Feb 1, 2020

@XavierM -- @andrew-goldstein and I were contemplating how we could tighten this up with some new platform magic like you mentioned. Having all this information gathered by the time SIEM starts would be ideal 🙂

For now though, another option would be to not do these checks in parallel, but rather just do the SIEM specific check first since it's so quick (just checking for shard count), and then only do the APM check if that returns 0. This would ensure the same speedy normal load throughout the app when there's SIEM data, and keep the FTUE flicker to around the same as it is in the second gif above (since that SIEM specific check is so quick).

@spong
Copy link
Member Author

spong commented Feb 1, 2020

FYI: I've updated the flow here as as detailed in the second half of my comment above. This will keep normal app usage snappy on initial loads (or at least as it is currently), while not ballooning the FTUE flicker too much since the SIEM index check is so quick.

@XavierM
Copy link
Contributor

XavierM commented Feb 3, 2020

during my review, I was wondering if we will be better later on to do a special empty prompt where we used the APM data. To differentiate it to the end-user. Instead to make it globally.

Copy link
Contributor

@XavierM XavierM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed/Tested LGTM

@spong
Copy link
Member Author

spong commented Feb 3, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spong spong merged commit f443d8a into elastic:master Feb 3, 2020
@spong spong deleted the fix-ftue-with-apm branch February 3, 2020 22:35
spong added a commit to spong/kibana that referenced this pull request Feb 3, 2020
## Summary

This PR resolves elastic#56363 found in `7.6 BC4`, where configuring a cloud instance with an APM node would circumvent our FTUE checks and would show the Overview Page when no data is present.

As detailed in the above issue, this resolves the problem by performing a similar check as to what APM performs to determine their `empty data` state.

As can be observed in the gifs below, this check adds additional latency to the full-app flicker, which is not ideal... Perhaps we can tweak the query further to improve this?

#### Deployment w/o APM node:
![ftue_no_apm](https://user-images.githubusercontent.com/2946766/73584819-a7212700-4458-11ea-9df8-f600fd6b1434.gif)


#### Deployment w/ APM node:
![ftue_with_apm](https://user-images.githubusercontent.com/2946766/73584817-a38da000-4458-11ea-824c-c42924c58fa0.gif)




### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

- [ ] ~This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~
- [ ] ~Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~
- [ ] ~[Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~
- [ ] ~[Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~
- [ ] ~This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
spong added a commit to spong/kibana that referenced this pull request Feb 3, 2020
## Summary

This PR resolves elastic#56363 found in `7.6 BC4`, where configuring a cloud instance with an APM node would circumvent our FTUE checks and would show the Overview Page when no data is present.

As detailed in the above issue, this resolves the problem by performing a similar check as to what APM performs to determine their `empty data` state.

As can be observed in the gifs below, this check adds additional latency to the full-app flicker, which is not ideal... Perhaps we can tweak the query further to improve this?

#### Deployment w/o APM node:
![ftue_no_apm](https://user-images.githubusercontent.com/2946766/73584819-a7212700-4458-11ea-9df8-f600fd6b1434.gif)


#### Deployment w/ APM node:
![ftue_with_apm](https://user-images.githubusercontent.com/2946766/73584817-a38da000-4458-11ea-824c-c42924c58fa0.gif)




### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

- [ ] ~This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~
- [ ] ~Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~
- [ ] ~[Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~
- [ ] ~[Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~
- [ ] ~This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
spong added a commit that referenced this pull request Feb 4, 2020
## Summary

This PR resolves #56363 found in `7.6 BC4`, where configuring a cloud instance with an APM node would circumvent our FTUE checks and would show the Overview Page when no data is present.

As detailed in the above issue, this resolves the problem by performing a similar check as to what APM performs to determine their `empty data` state.

As can be observed in the gifs below, this check adds additional latency to the full-app flicker, which is not ideal... Perhaps we can tweak the query further to improve this?

#### Deployment w/o APM node:
![ftue_no_apm](https://user-images.githubusercontent.com/2946766/73584819-a7212700-4458-11ea-9df8-f600fd6b1434.gif)


#### Deployment w/ APM node:
![ftue_with_apm](https://user-images.githubusercontent.com/2946766/73584817-a38da000-4458-11ea-824c-c42924c58fa0.gif)




### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

- [ ] ~This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~
- [ ] ~Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~
- [ ] ~[Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~
- [ ] ~[Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~
- [ ] ~This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
spong added a commit that referenced this pull request Feb 4, 2020
## Summary

This PR resolves #56363 found in `7.6 BC4`, where configuring a cloud instance with an APM node would circumvent our FTUE checks and would show the Overview Page when no data is present.

As detailed in the above issue, this resolves the problem by performing a similar check as to what APM performs to determine their `empty data` state.

As can be observed in the gifs below, this check adds additional latency to the full-app flicker, which is not ideal... Perhaps we can tweak the query further to improve this?

#### Deployment w/o APM node:
![ftue_no_apm](https://user-images.githubusercontent.com/2946766/73584819-a7212700-4458-11ea-9df8-f600fd6b1434.gif)


#### Deployment w/ APM node:
![ftue_with_apm](https://user-images.githubusercontent.com/2946766/73584817-a38da000-4458-11ea-824c-c42924c58fa0.gif)




### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

- [ ] ~This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~
- [ ] ~Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~
- [ ] ~[Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~
- [ ] ~[Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~
- [ ] ~This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
gmmorris added a commit to gmmorris/kibana that referenced this pull request Feb 4, 2020
* master: (42 commits)
  Move kuery_autocomplete ⇒ NP (elastic#56607)
  [ML] Functional tests - stabilize job row and analytics result view assertions (elastic#56595)
  [Discover] Inline angular directives only used in this plugin (elastic#56119)
  [Discover] Migrate get_sort.js test from mocha to TypeScript (elastic#56011)
  [SIEM] Enable flow_target_select_connected unit tests (elastic#55618)
  Start consuming np logging config (elastic#56480)
  [SIEM] Add eslint-plugin-react-perf (elastic#55960)
  Mention changed SAML ACS endpoint URL in breaking changes doc. (elastic#56613)
  Add `getServerInfo` API to http setup contract (elastic#56636)
  Updates Monitoring alert Jest snapshots
  Kibana property config migrations (elastic#55937)
  Vislib replacement toggle (elastic#56439)
  [Uptime] Add unit tests for QueryContext time calculation (elastic#56671)
  [SIEM][Detection Engine] Critical blocker, fixes pre-packaged rule miscounts
  Upgrade EUI to v18.3.0 (elastic#56228)
  [Maps] Fix server log (elastic#56679)
  [SIEM] Fixes FTUE when APM node is present (elastic#56574)
  [Reporting/FieldFormats] expose `setFieldFormats` and call from ReportingPlugin.start (elastic#56563)
  Update EMS API urls for production (elastic#56657)
  Ability to delete alerts even when AAD is out of sync (elastic#56543)
  ...
cauemarcondes pushed a commit to cauemarcondes/kibana that referenced this pull request Feb 5, 2020
## Summary

This PR resolves elastic#56363 found in `7.6 BC4`, where configuring a cloud instance with an APM node would circumvent our FTUE checks and would show the Overview Page when no data is present.

As detailed in the above issue, this resolves the problem by performing a similar check as to what APM performs to determine their `empty data` state.

As can be observed in the gifs below, this check adds additional latency to the full-app flicker, which is not ideal... Perhaps we can tweak the query further to improve this?

#### Deployment w/o APM node:
![ftue_no_apm](https://user-images.githubusercontent.com/2946766/73584819-a7212700-4458-11ea-9df8-f600fd6b1434.gif)


#### Deployment w/ APM node:
![ftue_with_apm](https://user-images.githubusercontent.com/2946766/73584817-a38da000-4458-11ea-824c-c42924c58fa0.gif)




### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

- [ ] ~This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~
- [ ] ~Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~
- [ ] ~[Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~
- [ ] ~[Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~
- [ ] ~This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
majagrubic pushed a commit to majagrubic/kibana that referenced this pull request Feb 10, 2020
## Summary

This PR resolves elastic#56363 found in `7.6 BC4`, where configuring a cloud instance with an APM node would circumvent our FTUE checks and would show the Overview Page when no data is present.

As detailed in the above issue, this resolves the problem by performing a similar check as to what APM performs to determine their `empty data` state.

As can be observed in the gifs below, this check adds additional latency to the full-app flicker, which is not ideal... Perhaps we can tweak the query further to improve this?

#### Deployment w/o APM node:
![ftue_no_apm](https://user-images.githubusercontent.com/2946766/73584819-a7212700-4458-11ea-9df8-f600fd6b1434.gif)


#### Deployment w/ APM node:
![ftue_with_apm](https://user-images.githubusercontent.com/2946766/73584817-a38da000-4458-11ea-824c-c42924c58fa0.gif)




### Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

- [ ] ~This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~
- [ ] ~Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~
- [ ] ~[Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~
- [ ] ~[Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~
- [ ] ~This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
- [ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)
@aisantos
Copy link

SIEM/Security dashboard appears one second or so before the "Add Data" splash page. Adding the Slack thread link here for reference on further discussion.
Screen Shot 2020-07-28 at 11 19 28 PM
Screen Shot 2020-07-28 at 11 15 07 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:SIEM v7.6.0 v7.7.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SIEM] Missing welcome screen in 7.6 BC4
6 participants