Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update @elastic/good to fix log file rotation #56660

Closed
wants to merge 11 commits into from
Closed

update @elastic/good to fix log file rotation #56660

wants to merge 11 commits into from

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Feb 3, 2020 •
edited
Loading

Fixes #43513

@elastic/good was updated to avoid an incompatibility with node 10, but the fix was incomplete and prevented reporters from being torn down correctly when we reconfigure on SIGHUP. This change uses the latest version of @elastic/good which reverts that fix and upgrades pumpify to be compatible with the latest node versions and restore the ability to rotate log files by renaming the log file and then sending SIGHUP to the process.

Release note: Sending SIGHUP to the Kibana server properly reopens the log file, recreating it if the old file has been renamed.

@spalger spalger requested review from mshustov and joshdover February 3, 2020 18:40
@spalger spalger added release_note:fix Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.6.0 v7.7.0 v8.0.0 labels Feb 3, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@spalger spalger marked this pull request as ready for review February 3, 2020 18:40
@spalger spalger requested a review from a team as a code owner February 3, 2020 22:24
@spalger
Copy link
Contributor Author

spalger commented Feb 3, 2020

@elasticmachine merge upstream

@spalger spalger mentioned this pull request Feb 4, 2020
Closed
@LeeDr LeeDr removed the v7.6.0 label Feb 4, 2020
@elasticmachine
Copy link
Contributor

💔 Build Failed

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@elastic elastic deleted a comment from kibanamachine Feb 7, 2020
mshustov
mshustov approved these changes Feb 7, 2020
View reviewed changes
Copy link
Contributor

@mshustov mshustov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I commented on the parent issue that it doesn't solve the problem. But it doesn't harm to update the package anyway

@spalger spalger closed this Feb 14, 2020
@spalger spalger deleted the fix/43513 branch August 18, 2020 17:59
@lucabelluccini lucabelluccini mentioned this pull request Dec 14, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshustov mshustov mshustov approved these changes

@joshdover joshdover Awaiting requested review from joshdover

Assignees
No one assigned
Labels
release_note:fix Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SIGHUP does not reload logging configuration
4 participants
@spalger @elasticmachine @mshustov @LeeDr