Don't start pollEsNodesVersion unless someone subscribes #56923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
streamich
added
the
Team:Core
|
Pinging @elastic/kibana-platform (Team:Platform) |
By not polling until subscribed to, we prevent verbose error logs when the optimizer is run (which automatically skips migrations).
rudolf
force-pushed
the
quiet-version-check-during-optimize
branch
from
22cbc8b
to
52d03e3
Compare
mshustov
reviewed
Feb 17, 2020
| this.log.error(message); | ||
| } | ||
| }); | ||
| }).pipe(shareReplay({ refCount: true, bufferSize: 1 })); |
There was a problem hiding this comment.
Do you use bufferSize: 1 to reduce memory footprint?
There was a problem hiding this comment.
The buffer size is the size of the replay subject that shareReplay uses internally. As long as there are subscribers, any new subscribers will get the last 1 values. So as long as we're polling, any new subscribers will immediately get the latest version check results.
When there are no subscribers, refCount drops to 0 and the internal replay subject will unsubscribe from pollEsNodesVersion$. When there's no subscriptions and then we get one new subscriber, that subscriber won't get any buffered/replayed version checks since these could be very old. Only once pollEsNodesVersion$ emits a value again will the first subscriber get a result.
rudolf
added
release_note:skip
|
@elasticmachine merge upstream |
mshustov
approved these changes
Feb 24, 2020
|
@elasticmachine merge upstream |
|
retest |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
This was referenced Feb 28, 2020
rudolf
added a commit
to rudolf/kibana
that referenced
this pull request
Feb 28, 2020
* Don't start pollEsNodesVersion unless someone subscribes By not polling until subscribed to, we prevent verbose error logs when the optimizer is run (which automatically skips migrations). * Test pollEsNodeVersions behaviour * Cleanup unused code * PR Feedback * Make test more stable Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
kibanamachine
added
the
backport missing
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
1 similar comment
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Mar 2, 2020
…dex-server-side * 'master' of github.com:elastic/kibana: (34 commits) [Upgrade Assistant] Remove "boom" from reindex service (elastic#58715) [data] Clean up QueryStringInput unit tests (elastic#58704) [SIEM] Detection Fix typo in Adobe Hijack Persistence rule (elastic#58804) Restores [SIEM][CASE] Init Configure Case Page (elastic#58121) (elastic#58924) Skips additional failing Ingest Manager integration tests Skips failing Ingest Manager integration tests Move dev tools styles to NP (elastic#58855) change to have kibana --ssl cli option use more recent certs (elastic#57933) disable failing suite (elastic#58942) Don't start pollEsNodesVersion unless someone subscribes (elastic#56923) Do not write UUID file during optimize process (elastic#58899) [Endpoint] Task/add nav bar (elastic#58604) [Metric Alerts] Add backend support for multiple expressions per alert (elastic#58672) [Metrics Alerts] Fix alerting on a rate aggregation (elastic#58789) disable flaky suite (elastic#55953) Revert "[SIEM] apollo@3 (elastic#51926)" and "[SIEM][CASE] Init Confi… (elastic#58806) [resubmit] Prep agg types for new platform (elastic#58893) [Lens] Allow number formatting within Lens (elastic#56253) [Autocomplete] Use settings from config rather than UI settings (elastic#58784) Improve action and trigger types (elastic#58657) ... # Conflicts: # x-pack/plugins/upgrade_assistant/server/routes/reindex_indices/reindex_indices.ts
rudolf
added a commit
that referenced
this pull request
Mar 2, 2020
…8947) * Don't start pollEsNodesVersion unless someone subscribes By not polling until subscribed to, we prevent verbose error logs when the optimizer is run (which automatically skips migrations). * Test pollEsNodeVersions behaviour * Cleanup unused code * PR Feedback * Make test more stable Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
rudolf
added a commit
that referenced
this pull request
Mar 2, 2020
…8946) * Don't start pollEsNodesVersion unless someone subscribes By not polling until subscribed to, we prevent verbose error logs when the optimizer is run (which automatically skips migrations). * Test pollEsNodeVersions behaviour * Cleanup unused code * PR Feedback * Make test more stable Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
kibanamachine
removed
the
backport missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By not polling until subscribed to, we prevent verbose error logs when
the optimizer is run (which automatically skips migrations).
Summary
Summarize your PR. If it involves visual changes include a screenshot or gif.
Checklist
Delete any items that are not applicable to this PR.
For maintainers