Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent Discover from fetching twice on initial load #57010

Closed
wants to merge 2 commits into from
Closed

Prevent Discover from fetching twice on initial load #57010

wants to merge 2 commits into from

Conversation

myasonik
Copy link
Contributor

@myasonik myasonik commented Feb 6, 2020 •
edited
Loading

Summary

Fixes #56999

Refetch on sort change didn't know about the default sort so it was refetch immediately on page load assuming that the initial fetch didn't have a sort set on it.

This PR bring getSortArray in line with getSortForSearchSource which is the thing that's ultimately responsible for firing the _search requests.

Screen Shot 2020-02-06 at 11 56 00

CC @flash1293

For maintainers

@myasonik myasonik added Feature:Discover Discover Application release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 v7.7.0 labels Feb 6, 2020
@myasonik myasonik requested a review from a team February 6, 2020 17:05
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@kertal kertal self-requested a review February 6, 2020 18:45
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@myasonik
Copy link
Contributor Author

myasonik commented Feb 7, 2020

This issue was fixed by #56160

@myasonik myasonik closed this Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kertal kertal Awaiting requested review from kertal

Assignees
No one assigned
Labels
Feature:Discover Discover Application release_note:fix Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Discover: Double fetch on initial load
2 participants
@myasonik @elasticmachine