Fix paths for kibana packages used by plugins

[shaileshcheke]

Summary

When we try to install kibana plugin, This plugin is using link: dependencies for non-Kibana packages is thrown by prepare_project_dependencies.ts.
The reason is kibana plugins uses link dependencies in package.json for kibana packages ex: "@kbn/i18n": "link:../../packages/kbn-i18n".
When we try to install such plugins, function prepareExternalProjectDependencies from prepare_project_dependencies.ts(@kbn-pm) is executed which check for dependencies that are listed in package.json.
and it throws error mentioned above if we use link dependencies for non kibana package. It checks if dependency is kibana package in function isKibanaDep which checks if ../../kibana is there in dependency version string.
When issue #33728 was resolved, paths in package_template.json in plugin generator("@kbn/i18n": "link:../../kibana/packages/kbn-i18n") was replaced by @kbn/i18n": "link:../../packages/kbn-i18n".
It seems from #33728 and respective pull request that kibana packages path is ../../packages(since v7.2.0). Hence path in prepare_project_dependencies.ts needs to be fixed. #

[elasticmachine]

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

[elasticmachine]

Pinging @elastic/kibana-operations (Team:Operations)

[mistic]

@shaileshcheke could you please run yarn kbn run build -i @kbn/pm and also commit the changes resulting from that operation please?

[shaileshcheke]

@mistic When I executed yarn kbn run build -i @kbn/pm first time, build was successful. I executed it again and getting Error: Cannot find module 'static-extend'. When I googled it, I came across https://discuss.elastic.co/t/error-while-building-package-from-source-code/188432/3. @LeeDr suggested to git reset --hard HEAD and then execute build on windows. I followed steps and committed results. But still CI/Build is failing. I am using Windows 10. Is it because of windows 10?

[mistic]

@shaileshcheke try to run git reset --hard HEAD, then yarn kbn bootstrap and finally yarn kbn run build -i @kbn/pm. Let me know the results

[shaileshcheke]

@mistic I executed git reset --hard HEAD followed by yarn kbn bootstrap. After that I executed yarn kbn run build -i @kbn/pm and it worked successfully. But when I executed yarn kbn run build -i @kbn/pm again, it fails with Error: Cannot find module 'static-extend'.

[mistic]

@shaileshcheke let's try to do one last thing please, if that fails, I'll try to reproduce the PR.
Can we do the following please?

1 - git reset --hard 889a5cc && git push --force
2 - yarn kbn bootstrap
3 - cd packages/kbn-pm && yarn build
4 - git add -A && git commit...

[shaileshcheke]

@mistic Please check.

[mistic]

@shaileshcheke you are doing everything well. Probably there is some probably when generating that file from windows that we need to look at. Meanwhile, could you please cherry pick the commit 985c85c I have in https://github.com/mistic/kibana/tree/recreation-of-57097 and push it to that PR? That would make the build to pass and allow us to move on with that PR.

Thank you very much for your help!

[shaileshcheke]

@mistic Committed changes after cherry-pick. Please check.

Thanks

[mistic]

@elasticmachine merge upstream

[mistic]

Jenkins test this

[mistic]

LGTM

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: b4cabab

History

• 💔 Build #25666 failed 1be43f0
• 💔 Build #25595 failed 7c41982f3ce1e0509f4b1043373c725063ffe282
• 💔 Build #25407 failed e38e50083212419ea6404cee959d761e5e16797a
• 💔 Build #25300 failed cee5c9ee9ea64d1483ad9e746cd512409e8d065f
• 💔 Build #25280 failed 63a33759faea800265504c80132255ab97743674

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[tylersmalley]

@joshdover I want to check with you before moving forward with this, since I know we have gone back and forth with where 3rd party plugins should live while in development. This PR looks to solve plugins being generated with scripts/generate_plugin which live in plugins/*, but I believe it would then break those still residing in kibana-extra/*.

[elasticmachine]

Pinging @elastic/kibana-platform (Team:Platform)

[mistic]

7.x: ebb49b7
7.6: e1fdb21

[joshdover]

@joshdover I want to check with you before moving forward with this, since I know we have gone back and forth with where 3rd party plugins should live while in development. This PR looks to solve plugins being generated with scripts/generate_plugin which live in plugins/*, but I believe it would then break those still residing in kibana-extra/*.

Kibana Platform plugins are only supported in plugins/*, but maybe we should change this to work for both new and legacy plugins until legacy plugin support is removed (#56205). Maybe this:

const isKibanaDep = (depVersion: string) =>
  // For ../kibana-extra/ directory (legacy only)
  depVersion.includes('../../kibana/packages/') ||
  // For plugins/ directory
  depVersion.includes('../../packages/');

[mistic]

Thanks for the feedback @joshdover, I'll make that change and add you as a reviewer 😃

[shaileshcheke]

@joshdover Thanks for feedback. Thanks @mistic.