Fix auto refresh in visualizations and lens #57667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flash1293
added
Feature:Visualizations
flash1293
commented
Feb 14, 2020
| @@ -441,14 +441,6 @@ function VisualizeAppController( | |||
| }) | |||
| ); | |||
|
|
|||
| subscriptions.add( | |||
There was a problem hiding this comment.
Not necessary anymore, the embeddable handles that from now on.
flash1293
added
Team:AppArch
Team:Visualizations
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
|
@elasticmachine merge upstream |
kertal
approved these changes
Feb 17, 2020
src/legacy/core_plugins/visualizations/public/embeddable/visualize_embeddable.ts
Outdated
Show resolved
Hide resolved
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Feb 17, 2020
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Feb 17, 2020
flash1293
added a commit
that referenced
this pull request
Feb 17, 2020
flash1293
added a commit
that referenced
this pull request
Feb 17, 2020
This was referenced Feb 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57536
This PR subscribes to the auto refresh observable provided by the timefilter service from the data plugin to reload the lens and visualization embeddable when a new value is emitted. This does not fix the same issue in the lens editor, this is tracked separately here: #57671
This is an interim solution to fix this for the 7.6.1, mid term this logic will be centralized in an embeddable super class.