Fix agg type shims and move paginated table to kibana_legacy #57695
Conversation
flash1293
added
Feature:NP Migration
release_note:skip
flash1293
added
the
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
| services: { | ||
| dataShim: { | ||
| search: { | ||
| aggs: { types: aggTypes, aggTypeFieldFilters }, |
There was a problem hiding this comment.
What do you think about getting rid of aggTypeFieldFilters in the data search services?
The only thing it is responsible for is adding a filter in rollup and using it in the default editor.
This is pretty the same thing as we've already got rid of editorConfig registry in #56501
This is maybe a question to @lukeelmers
There was a problem hiding this comment.
I agree, this would simplify the setup as more stuff becomes static. We still need a stateful plugin for types to keep it extensible, but it takes away complexity. Also cc @ppisljar
Have there been thoughts about this already?
There was a problem hiding this comment.
I'm currently working out the long term interface for agg types in #57064, which I'm hoping should be ready to merge by next week.
So far the items we will for sure be keeping in the lifecycle contract are types (registry of agg types) and createAggConfigs (a function that returns a new AggConfigs(), which will make the AggConfigs class itself internal to the data plugin).
Everything else is temporarily under a __LEGACY namespace while work out whether they are required or if they can be relocated/removed. For example, aggTypeFieldFilters is currently data.search.aggs.__LEGACY.aggTypeFieldFilters, but I agree @sulemanof, it may not be necessary to keep at all.
#57064 will be the best place to follow along, as many of these details should be sorted out in the coming days. Would welcome any input you have on that @sulemanof @flash1293 ... I'll probably add you as reviewers once I get it wrapped up 😄
There was a problem hiding this comment.
As it's not urgent I will postpone work on this PR till @lukeelmer's is merged. @kertal I will ping you once it becomes ready again :)
There was a problem hiding this comment.
Just as an update here: #58462 and #58805 have both been merged this week, and I'm actively working now on the PR to cutover agg types to the new platform.
Since doing the cutover is the highest priority in terms of unblocking teams, we decided to postpone sorting out aggTypeFieldFilters and some of the other items under __LEGACY as it should be possible to address them after the service is in the new platform, since they are no longer relying on legacy world functionality.
As we clean up those APIs we will upstream affected downstream applications accordingly.
There was a problem hiding this comment.
Makes sense, as there are some parts that definitely will stay stateful anyway it's a very small change to make later on.
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
|
Due to |
This PR fixes the default editor shim (some parts of legacy imports around agg types were actually stateful) and changes import from
ui/agg_typestocore_plugins/datawhere possible.Additionally it moves the paginate directive to
kibana_legacyto unblock the table directive in this regard.