Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unskip flaky tests #57715

Merged
merged 27 commits into from
Feb 19, 2020
Merged

Unskip flaky tests #57715

merged 27 commits into from
Feb 19, 2020

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Feb 14, 2020

Closes #44631
Closes #45244
Closes #45348
Closes #50018
Closes #56816
Closes #57377
Closes #57413
Closes #57601

Since merging #53976 a number of tests have proven pretty flaky. Those tests all seem to be flaky in Firefox only (for the most part) and by tweaking some timeouts we can reduce flakiness enough to re-enable those tests (just not the Firefox smoke tests, for now).

@spalger
Copy link
Contributor Author

spalger commented Feb 15, 2020

@elasticmachine merge upstream

@spalger
Copy link
Contributor Author

spalger commented Feb 15, 2020

@elasticmachine merge upstream

@spalger
Copy link
Contributor Author

spalger commented Feb 15, 2020

@elasticmachine merge upstream

@spalger
Copy link
Contributor Author

spalger commented Feb 16, 2020

@elasticmachine merge upstream

@spalger
Copy link
Contributor Author

spalger commented Feb 18, 2020

@elasticmachine merge upstream

@spalger
Copy link
Contributor Author

spalger commented Feb 18, 2020

@elasticmachine merge upstream

@spalger
Copy link
Contributor Author

spalger commented Feb 18, 2020

@elasticmachine merge upstream

@spalger
Copy link
Contributor Author

spalger commented Feb 18, 2020

@elasticmachine merge upstream

@spalger
Copy link
Contributor Author

spalger commented Feb 18, 2020

@elasticmachine merge upstream

@spalger spalger added release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.7.0 v8.0.0 labels Feb 18, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@spalger spalger marked this pull request as ready for review February 18, 2020 22:33
@spalger spalger requested a review from a team as a code owner February 18, 2020 22:33
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@spalger spalger merged commit 8f37f6e into elastic:master Feb 19, 2020
spalger pushed a commit to spalger/kibana that referenced this pull request Feb 19, 2020
* Revert "Skip flaky test (elastic#57675)"

This reverts commit c965a9e.

* Revert "disable firefox smoke tests so we can fix flakiness out of band"

This reverts commit fe38642.

* Revert "skip flaky tests (elastic#57643)"

This reverts commit b220454.

* Revert "skip flaky suite (elastic#50018)"

This reverts commit b058dc2.

* Revert "skip settings tests (elastic#57608)"

This reverts commit 64625b2.

* Revert "skip failing suite (elastic#44631)"

This reverts commit 8aa718d.

* Revert "skip flaky suite (elastic#44631)"

This reverts commit 6e4efdf.

* Revert "skip flaky test (elastic#57377)"

This reverts commit 59672ab.

* Revert "Skip save query tests (elastic#57589)"

This reverts commit 431a1e9.

* remove hard coded timeouts

* Revert "Revert "disable firefox smoke tests so we can fix flakiness out of band""

This reverts commit 271f881.

* Revert "remove hard coded timeouts"

This reverts commit 8b843d0.

* wait for managementHome to exist, don't bail early if it's missing

* Revert "skip flaky suite (elastic#45244)"

This reverts commit 0cee1a4.

* extend timeouts for common existsOrFail() calls

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
spalger pushed a commit that referenced this pull request Feb 19, 2020
* Revert "Skip flaky test (#57675)"

This reverts commit c965a9e.

* Revert "disable firefox smoke tests so we can fix flakiness out of band"

This reverts commit fe38642.

* Revert "skip flaky tests (#57643)"

This reverts commit b220454.

* Revert "skip flaky suite (#50018)"

This reverts commit b058dc2.

* Revert "skip settings tests (#57608)"

This reverts commit 64625b2.

* Revert "skip failing suite (#44631)"

This reverts commit 8aa718d.

* Revert "skip flaky suite (#44631)"

This reverts commit 6e4efdf.

* Revert "skip flaky test (#57377)"

This reverts commit 59672ab.

* Revert "Skip save query tests (#57589)"

This reverts commit 431a1e9.

* remove hard coded timeouts

* Revert "Revert "disable firefox smoke tests so we can fix flakiness out of band""

This reverts commit 271f881.

* Revert "remove hard coded timeouts"

This reverts commit 8b843d0.

* wait for managementHome to exist, don't bail early if it's missing

* Revert "skip flaky suite (#45244)"

This reverts commit 0cee1a4.

* extend timeouts for common existsOrFail() calls

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@spalger
Copy link
Contributor Author

spalger commented Feb 19, 2020

7.x/7.7: deea4d9

@spalger spalger deleted the unskip-flaky-tests branch February 19, 2020 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.7.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/rollup_job/tsvb·js - rollup app tsvb integration create rollup tsvb Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/visualize/feature_controls/visualize_security·ts - Visualize feature controls security global visualize all privileges allow saving via the saved query management component popover with no saved query loaded Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/discover/feature_controls/discover_security·ts - discover feature controls security global discover all privileges allow saving via the saved query management component popover with no query loaded Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/visualize/feature_controls/visualize_spaces·ts - Visualize visualize space with no features disabled can view existing Visualization Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/dashboard/feature_controls/dashboard_security·ts - dashboard feature controls dashboard security global dashboard & embeddable all privileges allow saving via the saved query management component popover with no query loaded
4 participants