Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Types #57801

Merged
merged 5 commits into from
Feb 18, 2020
Merged

Types #57801

merged 5 commits into from
Feb 18, 2020

Conversation

streamich
Copy link
Contributor

Summary

Partially addresses #46699

Add these types to @kbn/utility-types:

  • PublicContract<T> — Returns an object with public keys only.
  • PublicKeys<T> — Returns public keys of an object.
  • UnionToIntersection<T> — Converts a union of types into an intersection.
  • Values<T> — Returns object or array value types.

Checklist

Delete any items that are not applicable to this PR.

@streamich streamich requested a review from a team as a code owner February 17, 2020 13:20
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@streamich streamich added the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Feb 17, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas (Team:Canvas)

@streamich streamich added the release_note:skip Skip the PR/issue when compiling release notes label Feb 17, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

crob611
crob611 approved these changes Feb 18, 2020
View reviewed changes
Copy link
Contributor

@crob611 crob611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@streamich streamich merged commit 6436862 into elastic:master Feb 18, 2020
@streamich streamich mentioned this pull request Feb 18, 2020
Merged
streamich added a commit that referenced this pull request Feb 18, 2020
@streamich
Types (#57801) (#57904)
0a082c3 
* feat: 🎸 add Values<T>

* feat: 🎸 add UnionToIntersection<T> type

* refactor: 💡 use UnionToIntersection<T> in Canvas from @kbn/

* feat: 🎸 add PublicKeys<T> and PublicContract<T> types

* style: 💄 fix ESLint errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crob611 crob611 crob611 approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes review Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@streamich @elasticmachine @kibanamachine @crob611