Csv export support

[bobrik]

This patch enables csv export support for histogram panel. I'd like to see some feedback.

#205 is affected.

[johntdyer]

awesome !

[bobrik]

Maybe it would be better to make whole panels "csv enabled", like "inspectable" to make it more universal.

[rashidkpc]

I agree that the best way to go about this would be in a more generic fashion. My concern with merging this now is that people would expect every panel to support CSV export.

For things like the table panel, we'll need Elasticsearch support for CSV output to be able to export a useful number of records.

[bobrik]

I think it could be done in iterations, one panel at a time, starting with histogram panel.

Do you have any advice how to make this pull request better? Should we have "enable export to csv" option or it should be always available if panel supports it? How to make it more universal in code? I don't want to make changes blindly :)

I think I can add support for terms and pie in this request too. I'm not sure about table panel, it could be tricky.

[bobrik]

I've added terms panel support and redesigned the whole thing a bit. Now panels have button in the right top corner to trigger csv popup that has csv preview and download buttons.

@rashidkpc what do you think?

[rashidkpc]

Looks good. A few notes:

• {{ to_csv() }} in the modal. This should probably be changed to point at a populated scope object instead, as to_csv() will end up being run several times by angular when rendering the view. Might want to consider if the panel buttons should be changed to use a click handler instead of always assuming they'll open a modal. Modals can be triggered from controllers.
• Inspect was renamed Inspect2? Guessing a debugging leftover
• The time format should probably be ISO8601

[bobrik]

I renamed Inspect2 back to Inspect.

As I see ISO8601, it should be something like 2013-10-22T23:58:19. Am I right about this?

[rashidkpc]

yep

[bobrik]

@rashidkpc I moved csv calculation to results processing, csv.html is using variable instead of function call. Is that what you meant?

[rashidkpc]

The way the current panel buttons are designed they must trigger a modal. I'm wondering if we don't want to redesign that aspect of the system to point to a function that could perform other functions instead of a modal that can really only pop up a window. This would allow you to calculate the CSV data on demand, instead of everytime a search is performed.

[bobrik]

@rashidkpc I can't fix that aspect of kibana, sorry. I could only fix this pull request if someone could show me an example. Frankly speaking, I'm not even front-end developer and I have no idea how to do what you want from panel buttons.

[bobrik]

@rashidkpc what's the status of this request then?

[rashidkpc]

I really want to make sure this happens globally and in a scaleable manner before implementing the feature. That means refactoring the way panel buttons work and perhaps working with the Elasticsearch core team to get a CSV output to queries.

[bobrik]

@rashidkpc I added ng-click handler for panel buttons, now csv is calculated only if panel button clicked, see d24bc27

[bobrik]

@rashidkpc you're right, I updated request.

[bobrik]

Changed pre to textarea, now cmd+a works as expected — selecting csv instead of selecting the whole page.

[bobrik]

@rashidkpc is there anything else that should be fixed?

[pprpst]

Hi Guys,

Export is something I really need before setting up on production.
I have latest version of Kibana, and this is not included. Any idea when it will be included in official release ?
Or maybe anyone can instruct me how to deploy this "PATH" on my working setup ? ... I'm quite new in this ...

[pprpst]

Thanks guys !
I used "git" and "curl" to apply patch on kibana main.
Works fine. Great work with this CVS export.

[cdeck]

@bobrik : I tried to patch using this pull request and was unsuccessful (using the instructions you provided a few comments ago). Did a Kibana master change create a conflict?

[tkuther]

Just use git, like

git clone https://github.com/Topface/kibana
cd kibana
git remote add upstream https://github.com/elasticsearch/kibana
git fetch upstream
git checkout csv-export
git merge upstream/master

[cdeck]

@tkuther : Thanks - I'm obviously not git-savvy. :)

[bobrik]

@cdeck

git clone https://github.com/Topface/kibana -b csv-export

Use this to get clean up-to-date version of csv-export branch. Kibana development is pretty slow, therefore it shouldn't be too far away from master.

[daniilyar]

awesome! Much appreciated!

[swb13]

This is excellent, and efficient, as it reformats what Kibana has already retrieved. Thank you.

In my organization I'd say that most people are looking for a way to capture a few events/messages from the table and paste them into an e-mail or document as text. CSV export is a slightly indirect, but effective way of adding this capability.

[dumip]

This feature should be part of the Kibana main branch. Even if it might not be implemented in the most optimal manner, it is a lot, lot better that nothing!

Thank you @bobrik for your work!

[blysik]

Any chance this can make it into the main kibana release?

[rameyst]

Hi all - i'd like to use this add on, however, using the cloning instructions above, kibana throws an error message about using the latest version of it - it suggests to download the latest version from their website and not to clone it.

any idea how i can merge this add on with the latest release of kibana?

--git newbiie

[orangey]

With ISO8601 timestamps it is always much nicer to include sub-seconds and a timezone indicator; systems usually do more than one thing a second and many operate in numerous timezones, for example in UTC: 2014-05-29T15:41:42.005Z

[linux-devil]

Really wonderful thanks , I was told to this task in my organisation , only problem is how to download complete document object

[mweltman]

Great work! One minor comment: I think you will need to escape double-quotes in the values.

[Pytlicek]

Hello. Great work 👍
Please it is possible to add CSV export support to multifieldhistogram panel ( #1296 ) ?
Many users using this awesome panel but without your extension it is bad to export values.

I tried to change code on mulfifieldhistogram but without cuccess :(
I'm not the programmer. Please if you have some time please look at this panel. Many thanks. Tomas

[richyyy]

I already have Kibana in my Linux, however when I try to clone and curl the cmd as shown on the above comments. There was errors in curling the file, and my kibana did not appear to have the download button. Anyone knows whats going on?

[german23]

Thumbs Up for this great work! Hopefully it will get to the next main release.

[SuperveS]

Guys,

can anyone please describe shortly how to download and get the CSV export enhancement working on windows?

Thanks,
Newbie

[spalger]

Woops! Sorry about that! We recently replaced the master branch with Kibana 4. This action force closed all of the old pull requests against master. We will be reviewing these on a case-by-case basis and creating new tickets as necessary.

The good news is that many long requested features can be found in Kibana 4, and we're being entirely open about our roadmap. Check out the roadmap tickets (which we're still filling in) here.

If you're looking for the old Kibana 3 code you can find it here.

[w33ble]

CSV export is available in Kibana 4 now, so I'm going to leave this closed - thanks for the contribution

[ssoto]

It is amazing how some people try to "privatize" an open source project.
Thank you @bobrik and others for your effort.

[kibanaco]

I merged and tested this for this fork of kibana3: https://github.com/kibana-community/kibana3
I'll try to keep pulling other kibana 3 community improvements into that single tracking package.