Vega 5 upgrade

[wylieconlon]

Draft for collaboration

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

• Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
• Documentation was added for features that require explanation or tutorials
• Unit or functional tests were updated or added to match the most common scenarios
• This was checked for keyboard-only and screenreader accessibility
• This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
• This was checked for cross-browser compatibility, including a check against IE11

For maintainers

• This was checked for breaking API changes and was labeled appropriately

[flash1293]

It seems like you are also upgrading vega-lite, isn't this the problem @nyurik mentioned about it not being ready yet? vega/vega-lite#5920

[wylieconlon]

Tested locally with the IE11 fix I was developing in parallel (#58943), and found that vega-lite can't be upgraded as far as vega like you pointed out. But vega 5 does run in IE11!

[flash1293]

It should be possible to just upgrade vega and stick with the current outdated vega-lite version, right? If yes I think we should go for it, having vega Upgraded is the most important part because it’s always possible to compile vega-lite down somewhere else and then just use vega within Kibana if a user really needs the features of upgraded vega lite.

[wylieconlon]

Yes, exactly. Once we fix IE11, we can upgrade vega by itself.

[wylieconlon]

This work is currently blocked by another IE11 issue, I will return to focus on it soon.

[wylieconlon]

I've submitted a PR to vega-lite which I tested against this PR: vega/vega-lite#6249

With the combination of these things, I was able to use both vega and vega-lite in IE11:

[wylieconlon]

The best way to test this is:

yarn es snapshot --license oss
BROWSERSLIST_ENV=production node --max-old-space-size=4096 scripts/kibana --dev --server.basePath=/abc --oss

The OSS build is smaller, and is able to run in IE11. IE11 testing also requires:

csp.strict: false
server.host: '0.0.0.0'

[wylieconlon]

@elasticmachine merge upstream

[kibanamachine]

💔 Build Failed

• continuous-integration/kibana-ci/pull-request
• Commit: e39a711
• Pipeline Steps (look for red circles / failed steps)
• Interpreting CI Failures

Failed CI Steps

• Execute xpack-accessibility
• Execute xpack-kibana-ciGroup10
• Execute xpack-kibana-ciGroup9
• Execute xpack-kibana-ciGroup8
• Execute xpack-kibana-ciGroup7
• Execute xpack-kibana-ciGroup6
• Execute xpack-kibana-ciGroup5
• Execute xpack-kibana-ciGroup5
• Execute xpack-kibana-ciGroup4
• Execute xpack-kibana-ciGroup3
• Execute xpack-kibana-ciGroup2
• Execute xpack-kibana-ciGroup1
• Execute kibana-intake

History

• 💔 Build #39407 failed 9cfbf6a
• 💔 Build #39302 failed 5c989bd
• 💔 Build #39089 failed 75233d3
• 💔 Build #39085 failed b299835
• 💔 Build #38561 failed 32f4ca4

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream