Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Further improve type checking for actions and triggers #58765

Merged
merged 13 commits into from
Mar 4, 2020
Merged

Further improve type checking for actions and triggers #58765

merged 13 commits into from
Mar 4, 2020

Commits on Feb 29, 2020

  1. wip

    @stacey-gammon
    stacey-gammon committed Feb 29, 2020
    Configuration menu
    Copy the full SHA
    223a9d3 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2020

  1. review follow up

    @stacey-gammon
    stacey-gammon committed Mar 2, 2020
    Configuration menu
    Copy the full SHA
    80f5761 View commit details
    Browse the repository at this point in the history

  2. make ACTION a prefix, not SUFFIX

    @stacey-gammon
    stacey-gammon committed Mar 2, 2020
    Configuration menu
    Copy the full SHA
    dec2ceb View commit details
    Browse the repository at this point in the history

  3. fix path

    @stacey-gammon
    stacey-gammon committed Mar 2, 2020
    Configuration menu
    Copy the full SHA
    4cffe80 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' of github.com:elastic/kibana into 2020-02-26-ac… 

    …tion-types-2
    @stacey-gammon
    stacey-gammon committed Mar 2, 2020
    Configuration menu
    Copy the full SHA
    d58dcbb View commit details
    Browse the repository at this point in the history

  5. add warnings about casting to ActionType

    @stacey-gammon
    stacey-gammon committed Mar 2, 2020
    Configuration menu
    Copy the full SHA
    e950e1d View commit details
    Browse the repository at this point in the history

  6. Make context an object in examples, not a string

    @stacey-gammon
    stacey-gammon committed Mar 2, 2020
    Configuration menu
    Copy the full SHA
    f97c9c3 View commit details
    Browse the repository at this point in the history

  7. require object context, which seems to fix the partial requirement in… 

    … type and thus the type issue
    @stacey-gammon
    stacey-gammon committed Mar 2, 2020
    Configuration menu
    Copy the full SHA
    5e50447 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2020

  1. mistake

    @stacey-gammon
    stacey-gammon committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    fb29e4e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into 2020-02-26-action-types-2

    @elasticmachine
    elasticmachine authored Mar 3, 2020
    Configuration menu
    Copy the full SHA
    689dbc5 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' of github.com:elastic/kibana into 2020-02-26-ac… 

    …tion-types-2
    @stacey-gammon
    stacey-gammon committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    dcdec80 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' of github.com:elastic/kibana into 2020-02-26-ac… 

    …tion-types-2
    @stacey-gammon
    stacey-gammon committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    4b29831 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2020

  1. Merge branch 'master' of github.com:elastic/kibana into 2020-02-26-ac… 

    …tion-types-2
    @stacey-gammon
    stacey-gammon committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    40c51f8 View commit details
    Browse the repository at this point in the history