Backport 5532 to 4.x #5877
Merged
Backport 5532 to 4.x #5877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…clude metric vis from showing no results. The metric vis should fall through to its own controller. (cherry picked from commit 7f7be3c)
… 0 or ? for empty sets where appropropriate. (cherry picked from commit 39bc45f)
…and cleaning up code in the metric vis controller. (cherry picked from commit 2b0b9ff)
(cherry picked from commit 576cb3f)
…that null and NaN values can be returned and needed to be handled. I re-organized the code to handle null, undefined, and NaN values in the metric controller. (cherry picked from commit 99a2fa9)
…lues. (cherry picked from commit f023e4b)
(cherry picked from commit 348d2fc)
(cherry picked from commit 55ebeb2)
…e vis type handles no results. (cherry picked from commit 7a0c4f2)
…ic vis (cherry picked from commit 16f3dc3)
(cherry picked from commit 6daa528)
(cherry picked from commit 504c7c3)
(cherry picked from commit 8c90fff)
(cherry picked from commit 3269b02)
(cherry picked from commit 4e74cc2)
|
jenkins, test it |
1 similar comment
|
jenkins, test it |
|
The job isn't finished yet, but there are test failures on this. |
|
I am checking this out and will work on fixing the tests. |
|
jenkins, test it |
|
@epixa ok, this looks ready to go. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #5532 to 4.x branch for release with 4.5.0