Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SIEM] Fix rule delete/duplicate actions #59306

Merged
merged 6 commits into from
Mar 4, 2020
Merged

[SIEM] Fix rule delete/duplicate actions #59306

merged 6 commits into from
Mar 4, 2020

Conversation

patrykkopycinski
Copy link
Contributor

@patrykkopycinski patrykkopycinski commented Mar 4, 2020 •
edited
Loading

Summary

reFetchRules is called before the rule is deleted/duplicated, so we refetch the old data

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@patrykkopycinski patrykkopycinski added bug Fixes for quality problems that affect the customer experience Team:SIEM v8.0.0 v7.7.0 labels Mar 4, 2020
@patrykkopycinski patrykkopycinski self-assigned this Mar 4, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@patrykkopycinski
Copy link
Contributor Author

@elasticmachine merge upstream

dhurley14
dhurley14 approved these changes Mar 4, 2020
View reviewed changes
Copy link
Contributor

@dhurley14 dhurley14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left some optional nits. Thanks for the fixes!

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@patrykkopycinski patrykkopycinski merged commit ac4f8f4 into elastic:master Mar 4, 2020
@patrykkopycinski patrykkopycinski deleted the fix/siem-rule-delete branch March 4, 2020 20:40
This was referenced Mar 4, 2020
Merged
Merged
patrykkopycinski added a commit to patrykkopycinski/kibana that referenced this pull request Mar 4, 2020
@patrykkopycinski
[SIEM] Fix rule delete/duplicate actions (elastic#59306)
ef5e095
patrykkopycinski added a commit to patrykkopycinski/kibana that referenced this pull request Mar 4, 2020
@patrykkopycinski
[SIEM] Fix rule delete/duplicate actions (elastic#59306)
cf31023
patrykkopycinski added a commit that referenced this pull request Mar 5, 2020
@patrykkopycinski @elasticmachine
[SIEM] Fix rule delete/duplicate actions (#59306) (#59368)
f3f8672 
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jloleysens added a commit to jloleysens/kibana that referenced this pull request Mar 5, 2020
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into console/featu…
ce71db9 
…re/files-and-filetree

* 'master' of github.com:elastic/kibana: (254 commits)
  Convert discover_page to ts, remove redundunt methods (elastic#59312)
  [Fix for Vis Editor] Revert setting time field to empty string when it's undefined (elastic#58873)
  Delete legacy search endpoint (elastic#59341)
  [Uptime] Improve duration chart (elastic#58404)
  [Snapshot & Restore] NP migration (elastic#59109)
  [ML] Add support for date_nanos time field in anomaly job wizard (elastic#59017)
  Revert "Makes alerting and actions optional properties for interface RequestH… (elastic#59264)"
  Change remote_clusters ID to remoteClusters (elastic#59246)
  Makes alerting and actions optional properties for interface RequestH… (elastic#59264)
  Clean up date histogram agg type. (elastic#58805)
  [ML] Management: fix license unsubscribe (elastic#59365)
  Remove documentation for server.cors settings (elastic#59096)
  Edit alert flyout (elastic#58964)
  [SIEM] Fix rule delete/duplicate actions (elastic#59306)
  move mouse to close obstructing tooltip (elastic#59214)
  Reset page after deleting (elastic#59310)
  Make sure phrases input filter triggers autosuggestons (elastic#59299)
  Add loading count source for http requests (elastic#59245)
  Revert "[ML] Transforms: Deprecate custom KibanaContext. (elastic#59133)"
  Expose metrics service to public API (elastic#59294)
  ...

# Conflicts:
#	src/plugins/console/public/application/containers/editor/legacy/console_editor/editor.tsx
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 5, 2020
@kibanamachine
Copy link
Contributor

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 5, 2020
patrykkopycinski added a commit that referenced this pull request Mar 5, 2020
@patrykkopycinski
[SIEM] Fix rule delete/duplicate actions (#59306) (#59369)
47094cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhurley14 dhurley14 dhurley14 approved these changes

@XavierM XavierM Awaiting requested review from XavierM

Assignees

@patrykkopycinski patrykkopycinski

Labels
bug Fixes for quality problems that affect the customer experience release_note:fix Team:SIEM v7.6.2 v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@patrykkopycinski @elasticmachine @kibanamachine @dhurley14