Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Transforms: Use EuiInMemoryTable instead of custom typed table. #59782

Merged

Conversation

walterra
Copy link
Contributor

@walterra walterra commented Mar 10, 2020

Summary

Before EuiInMemoryTable had TypeScript support we used our own typings and some state & CSS fixes. This is now all solved by the original EUI component.

  • Use EuiInMemoryTable instead of custom typed table.
  • Deletes some legacy leftover files.

Note for kibana-design: No SCSS files where modified, just deleted some overrides.

Checklist

For maintainers

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM.

@@ -186,52 +182,46 @@ export const TransformList: FC<Props> = ({
// Before the transforms have been loaded for the first time, display the loading indicator only.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment still valid?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that's still relevant.

@kibanamachine
Copy link
Contributor

💔 Build Failed


Test Failures

Kibana Pipeline / x-pack-intake-agent / X-Pack Jest Tests.x-pack/plugins/transform/public/app/sections/transform_management/components/transform_list.Transform: Transform List Minimal initialization

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches


Stack Trace

Error: expect(received).toMatchSnapshot()

Snapshot name: `Transform: Transform List <TransformList /> Minimal initialization 1`

- Snapshot
+ Received

- <Fragment>
-   <ProgressBar
-     isLoading={false}
-   />
-   <EuiEmptyPrompt
-     actions={
-       Array [
-         <EuiButtonEmpty
-           data-test-subj="transformCreateFirstButton"
-           isDisabled={true}
-           onClick={[MockFunction]}
-         >
-           Create your first transform
-         </EuiButtonEmpty>,
-       ]
-     }
-     data-test-subj="transformNoTransformsFound"
-     title={
-       <h2>
-         No transforms found
-       </h2>
-     }
-   />
- </Fragment>
+ <EuiEmptyPrompt
+   actions={
+     Array [
+       <EuiButtonEmpty
+         data-test-subj="transformCreateFirstButton"
+         isDisabled={true}
+         onClick={[MockFunction]}
+       >
+         Create your first transform
+       </EuiButtonEmpty>,
+     ]
+   }
+   data-test-subj="transformNoTransformsFound"
+   title={
+     <h2>
+       No transforms found
+     </h2>
+   }
+ />
    at Object.test (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/x-pack/plugins/transform/public/app/sections/transform_management/components/transform_list/transform_list.test.tsx:26:21)
    at Object.asyncJestTest (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:102:37)
    at resolve (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/queueRunner.js:43:12)
    at new Promise (<anonymous>)
    at mapper (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/queueRunner.js:26:19)
    at promise.then (/var/lib/jenkins/workspace/elastic+kibana+pipeline-pull-request/kibana/node_modules/jest-jasmine2/build/queueRunner.js:73:41)

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM ⚡️

@walterra walterra merged commit ce6029b into elastic:master Mar 11, 2020
walterra added a commit to walterra/kibana that referenced this pull request Mar 11, 2020
…lastic#59782)

Before EuiInMemoryTable had TypeScript support we used our own typings and some state & CSS fixes. This is now all solved by the original EUI component.
- Use EuiInMemoryTable instead of custom typed table.
- Deletes some legacy leftover files.
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 11, 2020
* master:
  [ML] Transforms: Use EuiInMemoryTable instead of custom typed table. (elastic#59782)
  Alerting/fix flaky instance test (elastic#58994)
  ci: disable all Mocha rules for tape tests (elastic#59798)
  Fix UX in alerting UI forms when errors occur (elastic#59444)
  [DOCS] Updated and added jump tables (elastic#59774)
  [DOCS] Moved rolled up index content (elastic#59372)
  Regenerate core api docs (elastic#59814)
  [Lens] remove react warnings (elastic#59574)
  The scripts/backport.js file isn't an executable (elastic#59800)
  [Alerting] add more alert properties to action parameter templating (elastic#59718)
  [Design] Branding changes in Elastic to focus more towards the Elastic brand (elastic#58160)
  [SIEM] Adds 'Create new rule' Cypress test (elastic#59790)
  Updating svgo -> css-tree -> mdn-data, all so we get mdn-data > 2.0 (elastic#58913)
  Use EUI test environment build with Jest (elastic#55877)
  update typescript version in all packages to avoid warnings (elastic#59787)
  [SIEM] [Case] Insert timeline into case textarea (elastic#59586)
  [ML] Functional tests - stabilize saved search tests (elastic#59652)
@walterra walterra deleted the ml-transforms-deprecate-custom-table branch March 11, 2020 13:57
tylersmalley pushed a commit that referenced this pull request Mar 11, 2020
#59782 was merged with failing test.

Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
walterra added a commit that referenced this pull request Mar 11, 2020
…able. (#59782) (#59868)

Before EuiInMemoryTable had TypeScript support we used our own typings and some state & CSS fixes. This is now all solved by the original EUI component.
- Use EuiInMemoryTable instead of custom typed table.
- Deletes some legacy leftover files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants