Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the input type for @kbn/config-schema to work with more schemas #60007

Merged
merged 1 commit into from
Mar 12, 2020
Merged

Change the input type for @kbn/config-schema to work with more schemas #60007

merged 1 commit into from
Mar 12, 2020

Conversation

oatkiller
Copy link
Contributor

@oatkiller oatkiller commented Mar 12, 2020 •
edited
Loading

Summary

This PR modifies the 'input type' we use to type query params and POST bodies when hitting the API from the client. @kbn/config-schema sometimes returns types with deeply nested Type types, and sometimes it does not. This will always use TypeOf first, and then modify that type.

This is also good because now we only rely on the parts of @kbn/config-schema that were intended to be public, and our types take normal TS types, not special @kbn/config-schema ones.

For maintainers

@oatkiller oatkiller requested a review from a team as a code owner March 12, 2020 14:30
@oatkiller oatkiller added the Feature:Endpoint Elastic Endpoint feature label Mar 12, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/endpoint-app-team (Feature:Endpoint)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@oatkiller oatkiller added release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v8.0.0 labels Mar 12, 2020
@oatkiller oatkiller merged commit 9cd6e32 into elastic:master Mar 12, 2020
@oatkiller oatkiller deleted the config-schema-input-type-changes branch March 12, 2020 19:14
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 12, 2020
@gmmorris
Merge branch 'master' into alerting/view-in-app
62c10f8 
* master:
  Endpoint: Change the input type for @kbn/config-schema to work with more schemas (elastic#60007)
  Using re2 for Timelion regular expressions (elastic#55208)
  [Monitoring] Re-enable logstash tests (elastic#59815)
  fix karma debug typo (elastic#60029)
  Adds telemetry support to alerting and actions plugins (elastic#58081)
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 13, 2020
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 60007 or prevent reminders by adding the backport:skip label.

5 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 60007 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 60007 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 60007 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 60007 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 60007 or prevent reminders by adding the backport:skip label.

@oatkiller oatkiller mentioned this pull request Mar 19, 2020
Merged
oatkiller pushed a commit that referenced this pull request Mar 19, 2020
Endpoint: Change the input type for @kbn/config-schema to work with m…
c7b472f 
…ore schemas (#60007) (#60629)
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peluja1012 peluja1012 peluja1012 approved these changes

@dplumlee dplumlee dplumlee approved these changes

@kevinlog kevinlog kevinlog approved these changes

Assignees
No one assigned
Labels
Feature:Endpoint Elastic Endpoint feature release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@oatkiller @elasticmachine @kibanamachine @peluja1012 @dplumlee @kevinlog