Use const/let instead of var in all core plugins #6012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once all of the core code in Kibana is moved over, we should add a rule to flag any use of |
|
Compiles, runs, and didn't see any missing vars. LGTM pending jenkins, letting you decide timing on merging. |
epixa
added a commit
that referenced
this pull request
Feb 2, 2016
Use const/let instead of var in all core plugins
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also adds a rule to our linter to flag attempts to override
constvariables.I made no attempt to clean up any of the logic or code. There are definitely a few
places where with a minor refactor we'd be able to use
constinstead oflet, aswell as a few unused variables in the mix, but this change is already significant
enough without having to verify any changes like that.