Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configurable test users for xpack -homepage tests. #60808

Merged
merged 14 commits into from
Mar 26, 2020
Merged

configurable test users for xpack -homepage tests. #60808

merged 14 commits into from
Mar 26, 2020

Conversation

rashmivkulkarni
Copy link
Contributor

@rashmivkulkarni rashmivkulkarni commented Mar 20, 2020 •
edited
Loading

  • This test checks the user with limited privileges to access the api_keys gets the appropriate error message
  • This test also checks the user with right set of privileges is able to access the api_keys under Management.

@rashmivkulkarni rashmivkulkarni self-assigned this Mar 20, 2020
@rashmivkulkarni rashmivkulkarni added the Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! label Mar 20, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@rashmivkulkarni rashmivkulkarni added the Team:QA Team label for QA Team label Mar 20, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-qa (Team:QA)

@rashmivkulkarni rashmivkulkarni added the release_note:skip Skip the PR/issue when compiling release notes label Mar 20, 2020
@rashmivkulkarni rashmivkulkarni mentioned this pull request Mar 20, 2020
Closed
68 tasks
@LeeDr LeeDr removed the v7.6.0 label Mar 20, 2020
@rashmivkulkarni rashmivkulkarni requested a review from a team as a code owner March 23, 2020 19:07
@rashmivkulkarni
Copy link
Contributor Author

@elasticmachine merge upstream

LeeDr
LeeDr approved these changes Mar 25, 2020
View reviewed changes
Copy link

@LeeDr LeeDr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rashmivkulkarni
Copy link
Contributor Author

@elasticmachine merge upstream

@rashmivkulkarni
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

bhavyarm
bhavyarm reviewed Mar 26, 2020
View reviewed changes
Copy link
Contributor

@bhavyarm bhavyarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Pulled the code and ran it locally!

@rashmivkulkarni rashmivkulkarni merged commit c4df77e into elastic:master Mar 26, 2020
@rashmivkulkarni rashmivkulkarni mentioned this pull request Mar 26, 2020
Merged
rashmivkulkarni added a commit to rashmivkulkarni/kibana that referenced this pull request Mar 26, 2020
@rashmivkulkarni @elasticmachine
configurable test users for xpack -homepage tests. (elastic#60808)
373f1cc 
* configurable test users for xpack

* removed exclusive tests

* added data-test-subj for the access denied page

* updated the JEST snapshot, cleaned up the test

* changes to the test_api_keys role

* more changes to consolidate the page object function

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
rashmivkulkarni added a commit to rashmivkulkarni/kibana that referenced this pull request Mar 26, 2020
@rashmivkulkarni @elasticmachine
configurable test users for xpack -homepage tests. (elastic#60808)
8237b34 
* configurable test users for xpack

* removed exclusive tests

* added data-test-subj for the access denied page

* updated the JEST snapshot, cleaned up the test

* changes to the test_api_keys role

* more changes to consolidate the page object function

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
@rashmivkulkarni rashmivkulkarni mentioned this pull request Mar 26, 2020
Merged
rashmivkulkarni added a commit that referenced this pull request Mar 26, 2020
@rashmivkulkarni @elasticmachine
configurable test users for xpack -homepage tests. (#60808) (#61541)
22e550c 
* configurable test users for xpack

* removed exclusive tests

* added data-test-subj for the access denied page

* updated the JEST snapshot, cleaned up the test

* changes to the test_api_keys role

* more changes to consolidate the page object function

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
rashmivkulkarni added a commit that referenced this pull request Mar 27, 2020
@rashmivkulkarni @elasticmachine
configurable test users for xpack -homepage tests. (#60808) (#61551)
7c5c768 
* configurable test users for xpack

* removed exclusive tests

* added data-test-subj for the access denied page

* updated the JEST snapshot, cleaned up the test

* changes to the test_api_keys role

* more changes to consolidate the page object function

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhavyarm bhavyarm bhavyarm left review comments

@LeeDr LeeDr LeeDr approved these changes

@legrego legrego legrego approved these changes

@cuff-links cuff-links Awaiting requested review from cuff-links

Assignees

@rashmivkulkarni rashmivkulkarni

Labels
automation release_note:skip Skip the PR/issue when compiling release notes Team:QA Team label for QA Team Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rashmivkulkarni @elasticmachine @kibanamachine @legrego @bhavyarm @LeeDr