[search source] Stop building invalid queries and then rewriting them

[wylieconlon]

It appears that this was a compatibility layer added many years ago, but never removed. This finally removes it.

Checklist

• Unit or functional tests were updated or added to match the most common scenarios

[elasticmachine]

Pinging @elastic/kibana-app-arch (Team:AppArch)

[lizozom]

@wylieconlon code seems LGTM, however would you mind giving some pointers on how to test this?

[wylieconlon]

@lizozom Sure, the way to test this is by using the Filters aggregation. I tested with two steps:

• Create a bar chart visualization using the Filters aggregation
• For filters, use both KQL and Lucene syntax
  • For example, bytes > 1000 and bytes: {1000 TO *}
• You should see 2 bars with the same data
• Also, if you click on one of the bars, a filter should be added to the filter manager

It's also a good idea to test a migration, such as from 7.6 to this snapshot, using the same configuration. The filters should all work.

[wylieconlon]

@elasticmachine merge upstream

[lukeelmers]

Code LGTM. Tested locally (Chrome macOS):

✔️ created filters agg in a bar chart using both kql and lucene, same results.
✔️ verified filters manager still works when clicking on a bar for both kql and lucene.
✔️ exported vis with same configuration from 6.8.8 cloud instance. imported into this branch. verified all of the above still work as expected.

@wylieconlon Thanks for this cleanup!

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: e8e5291

History

• 💚 Build #41884 succeeded 815f02a
• 💚 Build #41746 succeeded 0c570b2
• 💚 Build #41619 succeeded 0c570b2
• 💔 Build #41400 failed bfff079
• 💔 Build #35634 failed fb42f3f

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream