Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Functional tests - adjust permissions for ml_ui_extras role #61055

Merged
merged 2 commits into from
Mar 25, 2020
Merged

[ML] Functional tests - adjust permissions for ml_ui_extras role #61055

merged 2 commits into from
Mar 25, 2020

Conversation

pheyos
Copy link
Member

@pheyos pheyos commented Mar 24, 2020

Summary

This PR removes the cluster:manage permission from the ml_ui_extras role as this is no longer needed.

Related to #57375

@pheyos pheyos added :ml test_ui_functional v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Mar 24, 2020
@pheyos pheyos requested a review from a team as a code owner March 24, 2020 12:15
@pheyos pheyos self-assigned this Mar 24, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

peteharverson
peteharverson approved these changes Mar 24, 2020
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pheyos
Copy link
Member Author

pheyos commented Mar 24, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

walterra
walterra approved these changes Mar 25, 2020
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pheyos pheyos merged commit 90f0032 into elastic:master Mar 25, 2020
@pheyos pheyos deleted the adjust_user_permissions branch March 25, 2020 09:00
pheyos added a commit to pheyos/kibana that referenced this pull request Mar 25, 2020
@pheyos
[ML] Adjust permissions for ml_ui_extras role (elastic#61055)
828549d 
This PR removes the cluster:manage permission from the ml_ui_extras role as this is no longer needed.
@pheyos pheyos mentioned this pull request Mar 25, 2020
Merged
pheyos added a commit that referenced this pull request Mar 25, 2020
@pheyos
[ML] Adjust permissions for ml_ui_extras role (#61055) (#61221)
1e6ac70 
This PR removes the cluster:manage permission from the ml_ui_extras role as this is no longer needed.
pheyos added a commit to pheyos/kibana that referenced this pull request Mar 25, 2020
@pheyos
[ML] Adjust permissions for ml_ui_extras role (elastic#61055)
574a0d9 
This PR removes the cluster:manage permission from the ml_ui_extras role as this is no longer needed.
@pheyos pheyos mentioned this pull request Mar 25, 2020
Merged
pheyos added a commit that referenced this pull request Mar 25, 2020
@pheyos
[ML] Adjust permissions for ml_ui_extras role (#61055) (#61277)
c3ba4c1 
This PR removes the cluster:manage permission from the ml_ui_extras role as this is no longer needed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walterra walterra walterra approved these changes

@peteharverson peteharverson peteharverson approved these changes

@darnautov darnautov Awaiting requested review from darnautov

Assignees

@pheyos pheyos

Labels
:ml release_note:skip Skip the PR/issue when compiling release notes test_ui_functional v7.7.0 v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pheyos @elasticmachine @kibanamachine @walterra @peteharverson