Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graph: Migrate feature registration #61419

Merged
merged 4 commits into from
Mar 30, 2020
Merged

Graph: Migrate feature registration #61419

merged 4 commits into from
Mar 30, 2020

Conversation

flash1293
Copy link
Contributor

This PR moves the feature control feature registration to the new platform.

it simply switches the call from server.plugins.xpack_main.registerFeature to setupPlugins. features

@flash1293 flash1293 marked this pull request as ready for review March 26, 2020 14:37
@flash1293 flash1293 requested a review from a team March 26, 2020 14:37
@flash1293 flash1293 added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Mar 26, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293 flash1293 added the release_note:skip Skip the PR/issue when compiling release notes label Mar 26, 2020
@kertal
Copy link
Member

kertal commented Mar 30, 2020

@elasticmachine merge upstream

kertal
kertal approved these changes Mar 30, 2020
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, tested locally in Chrome, works as expected

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@flash1293 flash1293 merged commit b6101f0 into elastic:master Mar 30, 2020
@flash1293 flash1293 deleted the move-graph-feature-registration branch March 30, 2020 09:11
flash1293 added a commit to flash1293/kibana that referenced this pull request Mar 30, 2020
@flash1293
Graph: Migrate feature registration (elastic#61419)
f6bef0c
@flash1293 flash1293 mentioned this pull request Mar 30, 2020
Merged
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 1, 2020
flash1293 added a commit that referenced this pull request Apr 1, 2020
@flash1293
Graph: Migrate feature registration (#61419) (#61765)
4863208
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kertal kertal kertal approved these changes

Assignees
No one assigned
Labels
Feature:Graph Graph application feature Feature:NP Migration release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@flash1293 @elasticmachine @kertal @kibanamachine