Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] DF Analytics Classification: clarify subset of data used in confusion matrix #61548

Merged
merged 2 commits into from
Mar 30, 2020
Merged

[ML] DF Analytics Classification: clarify subset of data used in confusion matrix #61548

merged 2 commits into from
Mar 30, 2020

Conversation

alvarezmelissa87
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 commented Mar 26, 2020 •
edited
Loading

Summary

Related issue #58596

Indicates which of the three subsets is used for the confusion matrix - entire/training/testing.

image

Checklist

Delete any items that are not applicable to this PR.

@alvarezmelissa87 alvarezmelissa87 added :ml v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:Data Frame Analytics ML data frame analytics features v7.7.0 labels Mar 26, 2020
@alvarezmelissa87 alvarezmelissa87 requested a review from a team as a code owner March 26, 2020 21:41
@alvarezmelissa87 alvarezmelissa87 self-assigned this Mar 26, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@peteharverson
Copy link
Contributor

peteharverson commented Mar 27, 2020 •
edited by alvarezmelissa87
Loading

This labelling looks wrong. I did the steps

  • Open results for a classification job on the seeds data
  • Click on 'Testing' - label shows Normalized confusion matrix for testing dataset correctly
  • Then edit the filter to seed_class:3 - results are over the entire data set, but the label still says 'testing'

image

Thanks for catching this - fixed in d2c30615535280c1a9d223069615c20a098daf4c cc @peteharverson

peteharverson
peteharverson approved these changes Mar 27, 2020
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested latest edit and LGTM

@alvarezmelissa87 alvarezmelissa87 mentioned this pull request Mar 27, 2020
Closed
@alvarezmelissa87 alvarezmelissa87 force-pushed the ml-df-class-matrix-clarity branch from d2c3061 to 7e6d9b2 Compare March 30, 2020 13:47
walterra
walterra approved these changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, added just one nit suggestion.

...alytics/pages/analytics_exploration/components/classification_exploration/evaluate_panel.tsx
Comment on lines +85 to +91
let helpText = entireDatasetHelpText;
if (dataSubsetTitle === SUBSET_TITLE.TESTING) {
helpText = testingDatasetHelpText;
} else if (dataSubsetTitle === SUBSET_TITLE.TRAINING) {
helpText = trainingDatasetHelpText;
}
return helpText;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Might be a rare case where a switch statement could make this more clear :)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

  • 💚 Build #36796 succeeded d2c30615535280c1a9d223069615c20a098daf4c
  • 💚 Build #36675 succeeded 14bebb0c5353251e544f593b92951cad43d28606

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alvarezmelissa87 alvarezmelissa87 merged commit b844fc5 into elastic:master Mar 30, 2020
This was referenced Mar 30, 2020
Merged
Merged
alvarezmelissa87 added a commit to alvarezmelissa87/kibana that referenced this pull request Mar 30, 2020
@alvarezmelissa87
[ML] DF Analytics Classification: clarify subset of data used in conf…
248cd91 
…usion matrix (elastic#61548)

* clarify which subset of data is being used in confusion matrix

* ensure dataSubsetTitle updates correctly
@alvarezmelissa87 alvarezmelissa87 deleted the ml-df-class-matrix-clarity branch March 30, 2020 17:08
alvarezmelissa87 added a commit that referenced this pull request Mar 30, 2020
@alvarezmelissa87
[ML] DF Analytics Classification: clarify subset of data used in conf…
a902c72 
…usion matrix (#61548) (#61851)

* clarify which subset of data is being used in confusion matrix

* ensure dataSubsetTitle updates correctly
alvarezmelissa87 added a commit to alvarezmelissa87/kibana that referenced this pull request Mar 31, 2020
@alvarezmelissa87
[ML] DF Analytics Classification: clarify subset of data used in conf…
8bc3461 
…usion matrix (elastic#61548)

* clarify which subset of data is being used in confusion matrix

* ensure dataSubsetTitle updates correctly
jgowdyelastic pushed a commit that referenced this pull request Mar 31, 2020
@alvarezmelissa87
[ML] DF Analytics Classification: clarify subset of data used in conf…
f1d038b 
…usion matrix (#61548) (#61852)

* clarify which subset of data is being used in confusion matrix

* ensure dataSubsetTitle updates correctly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walterra walterra walterra approved these changes

@peteharverson peteharverson peteharverson approved these changes

@jgowdyelastic jgowdyelastic Awaiting requested review from jgowdyelastic

@darnautov darnautov Awaiting requested review from darnautov

Assignees

@alvarezmelissa87 alvarezmelissa87

Labels
Feature:Data Frame Analytics ML data frame analytics features :ml release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alvarezmelissa87 @elasticmachine @peteharverson @kibanamachine @walterra