FTR: add chromium-based Edge browser support #61684

dmlemeshko · 2020-03-27T18:56:18Z

Summary

Add new chromium-based Edge browser in FTR

node scripts/functional_test_runner --config test/functional/config.edge.js

LeeDr · 2020-03-30T17:30:36Z

I'm running on Windows 10. It doesn't look like it's finding my Edge version in the registry;

$ node scripts/functional_test_runner --config test/functional/config.edge.js
 debg Loading config file from "C:\\Users\\LeeDr\\git\\kibana\\x-pack\\test\\functional\\config.edge.js"
 debg Loading config file from "C:\\Users\\LeeDr\\git\\kibana\\x-pack\\test\\functional\\config.js"
 debg Loading config file from "C:\\Users\\LeeDr\\git\\kibana\\test\\common\\config.js"
 debg Loading config file from "C:\\Users\\LeeDr\\git\\kibana\\test\\functional\\config.js"
 info Config loaded
 debg randomness seed: 1585588805194
 debg [webdriver] Creating session
MS Edge browser is not found in registry: undefined
 debg randomness seed: 1585588805363
Getting the latest driver version
Downloading MS Edge Driver 80.0.361.69...
Extracting driver binary...
Done.

DevTools listening on ws://127.0.0.1:53986/devtools/browser/2002eeea-7840-4e74-af43-4e833fee7d78
 info Remote initialized: msedge 80.0.361.69
 debg applying update to kibana config: {"accessibility:disableAnimations":true,"dateFormat:tz":"UTC"}
 info Starting tests

I do have Version 80.0.361.69 (Official build) (64-bit)

The next time it runs the output is a little different as it skips these steps;

Getting the latest driver version
Downloading MS Edge Driver 80.0.361.69...
Extracting driver binary...
Done.

Output:

$ node scripts/functional_test_runner --config test/functional/config.edge.js
 debg Loading config file from "C:\\Users\\LeeDr\\git\\kibana\\test\\functional\\config.edge.js"
 debg Loading config file from "C:\\Users\\LeeDr\\git\\kibana\\test\\functional\\config.js"
 debg Loading config file from "C:\\Users\\LeeDr\\git\\kibana\\test\\common\\config.js"
 info Config loaded
 debg randomness seed: 1585589275727
 debg [webdriver] Creating session
MS Edge browser is not found in registry: undefined

DevTools listening on ws://127.0.0.1:54442/devtools/browser/56541bab-a962-484d-bc0f-157f2d7c081f
 info Remote initialized: msedge 80.0.361.69
 debg applying update to kibana config: {"accessibility:disableAnimations":true,"dateFormat:tz":"UTC"}
 info Starting tests

Tests are running and passing. I'm just concerned that it didn't find my version in the registry.

UPDATE: For the OSS tests running locally I got these results on the first pass;

 │526 passing (3.0h)
 │85 pending
 │10 failing

I re-ran one of those 10 failing tests and it passed.

LeeDr · 2020-03-30T21:09:32Z

The last ci failure on this PR was;

00:08:57.667  ERROR: 'yarn kbn run build -i @kbn/pm' caused changes to the following files:
00:08:57.667  
00:08:57.667  packages/kbn-pm/dist/index.js

…edge-support

LeeDr · 2020-04-02T23:26:24Z

This isn't on your last commit. But I wanted to log these were the only 4 OSS test failures I hit.

        └- × fail: "discover app discover test query should modify the time range when a bar is clicked"
         └- × fail: "discover app discover test query should modify the time range when the histogram is brushed"
         └- × fail: "management  index pattern filter should filter indexed fields"
         └- × fail: "management  index pattern filter "after each" hook for "should filter indexed fields""

This reverts commit 87e7fdd.

…edge-support

dmlemeshko · 2020-04-07T14:59:30Z

@elasticmachine merge upstream

kibanamachine · 2020-04-07T19:22:59Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 10f22a7

History

💚 Build #39296 succeeded 7a4197e
💚 Build #39240 succeeded 3dc5d6f
💚 Build #38452 succeeded 87e7fdd
💚 Build #38265 succeeded a248566
💚 Build #37957 succeeded 9a55461

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

spalger

LGTM, thanks Dima!

* bump dependency, add edge support in ftr services * add config files * fix browser version for msedge * use npm ms-chromium-edge-driver * download edge driver aside from session creation * move dependency to dev * update dist/index file * bump edge-driver version * change type to msedge to match w3c spec * fix discover tests for Edge * Revert "fix discover tests for Edge" This reverts commit 87e7fdd. * bump driver version up Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

…chore/put-all-xjson-together * 'master' of github.com:elastic/kibana: (35 commits) [SIEM] [Detection Engine] Fixes bug when notification doesn't… (elastic#63013) [SIEM][Detection Engine] Fix rule notification critical bugs Add Error Exception Type Column (elastic#59596) [APM] Agent remote configuration: changes in Java property descriptions (elastic#62282) [Alerting] Displays warning when a permanent encryption key is missing and hides alerting UI appropriately (elastic#62772) FTR: add chromium-based Edge browser support (elastic#61684) [Ingest] Data source configuration validation UI (elastic#61180) restore empty_kibana after saved objects test (elastic#62951) Index pattern management plugin - src/legacy/core_plugins/management => new platform plugin (elastic#62594) Add basic StatusService (elastic#60335) [kbn/optimizer] link to kibanaReact/kibanaUtils plugins (elastic#62720) [APM] Service map - fixes layout issues for maps with no rum services (elastic#62887) Exclude disabled datasources and streams from agent config (elastic#62869) [Alerting] Fix validation support for nested IErrorObjects (elastic#62833) [Metrics UI] Invalidate non-count alerts which have no metrics (elastic#62837) Add --filter option to API docs script (elastic#62888) [Maps] fix attribution overflow with exit full screen button (elastic#62699) [Uptime]Alerting UI text in case filter is selected (elastic#62570) [Maps] Show create filter button for top-term tooltip property (elastic#62461) skip flaky suite (elastic#59030) ... # Conflicts: # src/plugins/es_ui_shared/public/index.ts

* bump dependency, add edge support in ftr services * add config files * fix browser version for msedge * use npm ms-chromium-edge-driver * download edge driver aside from session creation * move dependency to dev * update dist/index file * bump edge-driver version * change type to msedge to match w3c spec * fix discover tests for Edge * Revert "fix discover tests for Edge" This reverts commit 87e7fdd. * bump driver version up Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* master: (40 commits) [ML] Functional transform tests - stabilize source selection (elastic#63087) add embed flag to saved object url as well (elastic#62926) [SIEM] [Detection Engine] Fixes bug when notification doesn't… (elastic#63013) [SIEM][Detection Engine] Fix rule notification critical bugs Add Error Exception Type Column (elastic#59596) [APM] Agent remote configuration: changes in Java property descriptions (elastic#62282) [Alerting] Displays warning when a permanent encryption key is missing and hides alerting UI appropriately (elastic#62772) FTR: add chromium-based Edge browser support (elastic#61684) [Ingest] Data source configuration validation UI (elastic#61180) restore empty_kibana after saved objects test (elastic#62951) Index pattern management plugin - src/legacy/core_plugins/management => new platform plugin (elastic#62594) Add basic StatusService (elastic#60335) [kbn/optimizer] link to kibanaReact/kibanaUtils plugins (elastic#62720) [APM] Service map - fixes layout issues for maps with no rum services (elastic#62887) Exclude disabled datasources and streams from agent config (elastic#62869) [Alerting] Fix validation support for nested IErrorObjects (elastic#62833) [Metrics UI] Invalidate non-count alerts which have no metrics (elastic#62837) Add --filter option to API docs script (elastic#62888) [Maps] fix attribution overflow with exit full screen button (elastic#62699) [Uptime]Alerting UI text in case filter is selected (elastic#62570) ...

watson · 2020-04-14T08:45:52Z

⚠️ TL;DR: This PR introduces a node-gyp compilation issue in some dev environments.

This PR adds the dependency ms-chromium-edge-driver which in turn depends on windows-registry which in turn depends on ref. The ref package isn't supported on newer versions of Node.js - including the version we're on. This results in compilation issues for some people:

yarn kbn bootstrap log

error /Users/watson/code/elastic/kibana/node_modules/ffi: Command failed.
Exit code: 1
Command: node-gyp rebuild
Arguments:
Directory: /Users/watson/code/elastic/kibana/node_modules/ffi
Output:
gyp info it worked if it ends with ok
gyp info using node-gyp@3.8.0
gyp info using node@10.19.0 | darwin | x64
gyp info spawn /usr/bin/python
gyp info spawn args [ '/Users/watson/code/elastic/kibana/node_modules/node-gyp/gyp/gyp_main.py',
gyp info spawn args   'binding.gyp',
gyp info spawn args   '-f',
gyp info spawn args   'make',
gyp info spawn args   '-I',
gyp info spawn args   '/Users/watson/code/elastic/kibana/node_modules/ffi/build/config.gypi',
gyp info spawn args   '-I',
gyp info spawn args   '/Users/watson/code/elastic/kibana/node_modules/node-gyp/addon.gypi',
gyp info spawn args   '-I',
gyp info spawn args   '/Users/watson/.node-gyp/10.19.0/include/node/common.gypi',
gyp info spawn args   '-Dlibrary=shared_library',
gyp info spawn args   '-Dvisibility=default',
gyp info spawn args   '-Dnode_root_dir=/Users/watson/.node-gyp/10.19.0',
gyp info spawn args   '-Dnode_gyp_dir=/Users/watson/code/elastic/kibana/node_modules/node-gyp',
gyp info spawn args   '-Dnode_lib_file=/Users/watson/.node-gyp/10.19.0/<(target_arch)/node.lib',
gyp info spawn args   '-Dmodule_root_dir=/Users/watson/code/elastic/kibana/node_modules/ffi',
gyp info spawn args   '-Dnode_engine=v8',
gyp info spawn args   '--depth=.',
gyp info spawn args   '--no-parallel',
gyp info spawn args   '--generator-output',
gyp info spawn args   'build',
gyp info spawn args   '-Goutput_dir=.' ]
gyp info spawn make
gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]
  CC(target) Release/obj.target/ffi/deps/libffi/src/prep_cif.o
  CC(target) Release/obj.target/ffi/deps/libffi/src/types.o
  CC(target) Release/obj.target/ffi/deps/libffi/src/raw_api.o
  CC(target) Release/obj.target/ffi/deps/libffi/src/java_raw_api.o
  CC(target) Release/obj.target/ffi/deps/libffi/src/closures.o
In file included from ../deps/libffi/src/closures.c:210:
../deps/libffi/src/dlmalloc.c:2932:33: warning: arithmetic on a null pointer treated as a cast from integer to pointer is a GNU extension [-Wnull-pointer-arithmetic]
      used = fp - (m->topsize + TOP_FOOT_SIZE);
                                ^~~~~~~~~~~~~
../deps/libffi/src/dlmalloc.c:2188:17: note: expanded from macro 'TOP_FOOT_SIZE'
  (align_offset(chunk2mem(0))+pad_request(sizeof(struct malloc_segment))+MIN_CHUNK_SIZE)
   ~~~~~~~~~~~~~^~~~~~~~~~~~~
../deps/libffi/src/dlmalloc.c:1688:55: note: expanded from macro 'chunk2mem'
#define chunk2mem(p)        ((void*)((char*)(p)       + TWO_SIZE_T_SIZES))
                                                      ^
../deps/libffi/src/dlmalloc.c:1275:14: note: expanded from macro 'align_offset'
 ((((size_t)(A) & CHUNK_ALIGN_MASK) == 0)? 0 :\
             ^
../deps/libffi/src/dlmalloc.c:2932:33: warning: arithmetic on a null pointer treated as a cast from integer to pointer is a GNU extension [-Wnull-pointer-arithmetic]
      used = fp - (m->topsize + TOP_FOOT_SIZE);
                                ^~~~~~~~~~~~~
../deps/libffi/src/dlmalloc.c:2188:17: note: expanded from macro 'TOP_FOOT_SIZE'
  (align_offset(chunk2mem(0))+pad_request(sizeof(struct malloc_segment))+MIN_CHUNK_SIZE)
   ~~~~~~~~~~~~~^~~~~~~~~~~~~
../deps/libffi/src/dlmalloc.c:1688:55: note: expanded from macro 'chunk2mem'
#define chunk2mem(p)        ((void*)((char*)(p)       + TWO_SIZE_T_SIZES))
                                                      ^
../deps/libffi/src/dlmalloc.c:1276:34: note: expanded from macro 'align_offset'
  ((MALLOC_ALIGNMENT - ((size_t)(A) & CHUNK_ALIGN_MASK)) & CHUNK_ALIGN_MASK))
                                 ^
../deps/libffi/src/dlmalloc.c:3289:39: warning: arithmetic on a null pointer treated as a cast from integer to pointer is a GNU extension [-Wnull-pointer-arithmetic]
  chunk_plus_offset(p, psize)->head = TOP_FOOT_SIZE;
                                      ^~~~~~~~~~~~~
../deps/libffi/src/dlmalloc.c:2188:17: note: expanded from macro 'TOP_FOOT_SIZE'
  (align_offset(chunk2mem(0))+pad_request(sizeof(struct malloc_segment))+MIN_CHUNK_SIZE)
   ~~~~~~~~~~~~~^~~~~~~~~~~~~
../deps/libffi/src/dlmalloc.c:1688:55: note: expanded from macro 'chunk2mem'
#define chunk2mem(p)        ((void*)((char*)(p)       + TWO_SIZE_T_SIZES))
                                                      ^
../deps/libffi/src/dlmalloc.c:1275:14: note: expanded from macro 'align_offset'
 ((((size_t)(A) & CHUNK_ALIGN_MASK) == 0)? 0 :\
             ^
../deps/libffi/src/dlmalloc.c:3289:39: warning: arithmetic on a null pointer treated as a cast from integer to pointer is a GNU extension [-Wnull-pointer-arithmetic]
  chunk_plus_offset(p, psize)->head = TOP_FOOT_SIZE;
                                      ^~~~~~~~~~~~~
../deps/libffi/src/dlmalloc.c:2188:17: note: expanded from macro 'TOP_FOOT_SIZE'
  (align_offset(chunk2mem(0))+pad_request(sizeof(struct malloc_segment))+MIN_CHUNK_SIZE)
   ~~~~~~~~~~~~~^~~~~~~~~~~~~
../deps/libffi/src/dlmalloc.c:1688:55: note: expanded from macro 'chunk2mem'
#define chunk2mem(p)        ((void*)((char*)(p)       + TWO_SIZE_T_SIZES))
                                                      ^
../deps/libffi/src/dlmalloc.c:1276:34: note: expanded from macro 'align_offset'
  ((MALLOC_ALIGNMENT - ((size_t)(A) & CHUNK_ALIGN_MASK)) & CHUNK_ALIGN_MASK))
                                 ^
../deps/libffi/src/dlmalloc.c:3383:41: warning: arithmetic on a null pointer treated as a cast from integer to pointer is a GNU extension [-Wnull-pointer-arithmetic]
  init_top(m, (mchunkptr)tbase, tsize - TOP_FOOT_SIZE);
                                        ^~~~~~~~~~~~~
../deps/libffi/src/dlmalloc.c:2188:17: note: expanded from macro 'TOP_FOOT_SIZE'
  (align_offset(chunk2mem(0))+pad_request(sizeof(struct malloc_segment))+MIN_CHUNK_SIZE)
   ~~~~~~~~~~~~~^~~~~~~~~~~~~
../deps/libffi/src/dlmalloc.c:1688:55: note: expanded from macro 'chunk2mem'
#define chunk2mem(p)        ((void*)((char*)(p)       + TWO_SIZE_T_SIZES))
                                                      ^
../deps/libffi/src/dlmalloc.c:1275:14: note: expanded from macro 'align_offset'
 ((((size_t)(A) & CHUNK_ALIGN_MASK) == 0)? 0 :\
             ^
../deps/libffi/src/dlmalloc.c:3383:41: warning: arithmetic on a null pointer treated as a cast from integer to pointer is a GNU extension [-Wnull-pointer-arithmetic]
  init_top(m, (mchunkptr)tbase, tsize - TOP_FOOT_SIZE);
                                        ^~~~~~~~~~~~~
../deps/libffi/src/dlmalloc.c:2188:17: note: expanded from macro 'TOP_FOOT_SIZE'
  (align_offset(chunk2mem(0))+pad_request(sizeof(struct malloc_segment))+MIN_CHUNK_SIZE)
   ~~~~~~~~~~~~~^~~~~~~~~~~~~
../deps/libffi/src/dlmalloc.c:1688:55: note: expanded from macro 'chunk2mem'
#define chunk2mem(p)        ((void*)((char*)(p)       + TWO_SIZE_T_SIZES))
                                                      ^
../deps/libffi/src/dlmalloc.c:1276:34: note: expanded from macro 'align_offset'
  ((MALLOC_ALIGNMENT - ((size_t)(A) & CHUNK_ALIGN_MASK)) & CHUNK_ALIGN_MASK))
                                 ^
../deps/libffi/src/dlmalloc.c:3461:40: warning: arithmetic on a null pointer treated as a cast from integer to pointer is a GNU extension [-Wnull-pointer-arithmetic]
        asize = granularity_align(nb + TOP_FOOT_SIZE + SIZE_T_ONE);
                ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
../deps/libffi/src/dlmalloc.c:2188:17: note: expanded from macro 'TOP_FOOT_SIZE'
  (align_offset(chunk2mem(0))+pad_request(sizeof(struct malloc_segment))+MIN_CHUNK_SIZE)
                ^
../deps/libffi/src/dlmalloc.c:1688:55: note: expanded from macro 'chunk2mem'
#define chunk2mem(p)        ((void*)((char*)(p)       + TWO_SIZE_T_SIZES))
                                                      ^
../deps/libffi/src/dlmalloc.c:1275:14: note: expanded from macro 'align_offset'
 ((((size_t)(A) & CHUNK_ALIGN_MASK) == 0)? 0 :\
             ^
../deps/libffi/src/dlmalloc.c:2143:6: note: expanded from macro 'granularity_align'
  (((S) + (mparams.granularity)) & ~(mparams.granularity - SIZE_T_ONE))
     ^
../deps/libffi/src/dlmalloc.c:3461:40: warning: arithmetic on a null pointer treated as a cast from integer to pointer is a GNU extension [-Wnull-pointer-arithmetic]
        asize = granularity_align(nb + TOP_FOOT_SIZE + SIZE_T_ONE);
                ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
../deps/libffi/src/dlmalloc.c:2188:17: note: expanded from macro 'TOP_FOOT_SIZE'
  (align_offset(chunk2mem(0))+pad_request(sizeof(struct malloc_segment))+MIN_CHUNK_SIZE)
                ^
../deps/libffi/src/dlmalloc.c:1688:55: note: expanded from macro 'chunk2mem'
#define chunk2mem(p)        ((void*)((char*)(p)       + TWO_SIZE_T_SIZES))
                                                      ^
../deps/libffi/src/dlmalloc.c:1276:34: note: expanded from macro 'align_offset'
  ((MALLOC_ALIGNMENT - ((size_t)(A) & CHUNK_ALIGN_MASK)) & CHUNK_ALIGN_MASK))
                                 ^
../deps/libffi/src/dlmalloc.c:2143:6: note: expanded from macro 'granularity_align'
  (((S) + (mparams.granularity)) & ~(mparams.granularity - SIZE_T_ONE))
     ^
../deps/libffi/src/dlmalloc.c:3475:51: warning: arithmetic on a null pointer treated as a cast from integer to pointer is a GNU extension [-Wnull-pointer-arithmetic]
      asize = granularity_align(nb - m->topsize + TOP_FOOT_SIZE + SIZE_T_ONE);
              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
../deps/libffi/src/dlmalloc.c:2188:17: note: expanded from macro 'TOP_FOOT_SIZE'
  (align_offset(chunk2mem(0))+pad_request(sizeof(struct malloc_segment))+MIN_CHUNK_SIZE)
                ^
../deps/libffi/src/dlmalloc.c:1688:55: note: expanded from macro 'chunk2mem'
#define chunk2mem(p)        ((void*)((char*)(p)       + TWO_SIZE_T_SIZES))
                                                      ^
../deps/libffi/src/dlmalloc.c:1275:14: note: expanded from macro 'align_offset'
 ((((size_t)(A) & CHUNK_ALIGN_MASK) == 0)? 0 :\
             ^
../deps/libffi/src/dlmalloc.c:2143:6: note: expanded from macro 'granularity_align'
  (((S) + (mparams.granularity)) & ~(mparams.granularity - SIZE_T_ONE))
     ^
../deps/libffi/src/dlmalloc.c:3475:51: warning: arithmetic on a null pointer treated as a cast from integer to pointer is a GNU extension [-Wnull-pointer-arithmetic]
      asize = granularity_align(nb - m->topsize + TOP_FOOT_SIZE + SIZE_T_ONE);
              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
../deps/libffi/src/dlmalloc.c:2188:17: note: expanded from macro 'TOP_FOOT_SIZE'
  (align_offset(chunk2mem(0))+pad_request(sizeof(struct malloc_segment))+MIN_CHUNK_SIZE)
                ^
../deps/libffi/src/dlmalloc.c:1688:55: note: expanded from macro 'chunk2mem'
#define chunk2mem(p)        ((void*)((char*)(p)       + TWO_SIZE_T_SIZES))
                                                      ^
../deps/libffi/src/dlmalloc.c:1276:34: note: expanded from macro 'align_offset'
  ((MALLOC_ALIGNMENT - ((size_t)(A) & CHUNK_ALIGN_MASK)) & CHUNK_ALIGN_MASK))
                                 ^
../deps/libffi/src/dlmalloc.c:2143:6: note: expanded from macro 'granularity_align'
  (((S) + (mparams.granularity)) & ~(mparams.granularity - SIZE_T_ONE))
     ^
../deps/libffi/src/dlmalloc.c:3487:26: warning: arithmetic on a null pointer treated as a cast from integer to pointer is a GNU extension [-Wnull-pointer-arithmetic]
            asize < nb + TOP_FOOT_SIZE + SIZE_T_ONE) {
                         ^~~~~~~~~~~~~
../deps/libffi/src/dlmalloc.c:2188:17: note: expanded from macro 'TOP_FOOT_SIZE'
  (align_offset(chunk2mem(0))+pad_request(sizeof(struct malloc_segment))+MIN_CHUNK_SIZE)
   ~~~~~~~~~~~~~^~~~~~~~~~~~~
../deps/libffi/src/dlmalloc.c:1688:55: note: expanded from macro 'chunk2mem'
#define chunk2mem(p)        ((void*)((char*)(p)       + TWO_SIZE_T_SIZES))
                                                      ^
../deps/libffi/src/dlmalloc.c:1275:14: note: expanded from macro 'align_offset'
 ((((size_t)(A) & CHUNK_ALIGN_MASK) == 0)? 0 :\
             ^
../deps/libffi/src/dlmalloc.c:3487:26: warning: arithmetic on a null pointer treated as a cast from integer to pointer is a GNU extension [-Wnull-pointer-arithmetic]
            asize < nb + TOP_FOOT_SIZE + SIZE_T_ONE) {
                         ^~~~~~~~~~~~~
../deps/libffi/src/dlmalloc.c:2188:17: note: expanded from macro 'TOP_FOOT_SIZE'
  (align_offset(chunk2mem(0))+pad_request(sizeof(struct malloc_segment))+MIN_CHUNK_SIZE)
   ~~~~~~~~~~~~~^~~~~~~~~~~~~
../deps/libffi/src/dlmalloc.c:1688:55: note: expanded from macro 'chunk2mem'
#define chunk2mem(p)        ((void*)((char*)(p)       + TWO_SIZE_T_SIZES))
                                                      ^
../deps/libffi/src/dlmalloc.c:1276:34: note: expanded from macro 'align_offset'
  ((MALLOC_ALIGNMENT - ((size_t)(A) & CHUNK_ALIGN_MASK)) & CHUNK_ALIGN_MASK))
                                 ^
../deps/libffi/src/dlmalloc.c:3488:49: warning: arithmetic on a null pointer treated as a cast from integer to pointer is a GNU extension [-Wnull-pointer-arithmetic]
          size_t esize = granularity_align(nb + TOP_FOOT_SIZE + SIZE_T_ONE - asize);
                         ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../deps/libffi/src/dlmalloc.c:2188:17: note: expanded from macro 'TOP_FOOT_SIZE'
  (align_offset(chunk2mem(0))+pad_request(sizeof(struct malloc_segment))+MIN_CHUNK_SIZE)
                ^
../deps/libffi/src/dlmalloc.c:1688:55: note: expanded from macro 'chunk2mem'
#define chunk2mem(p)        ((void*)((char*)(p)       + TWO_SIZE_T_SIZES))
                                                      ^
../deps/libffi/src/dlmalloc.c:1275:14: note: expanded from macro 'align_offset'
 ((((size_t)(A) & CHUNK_ALIGN_MASK) == 0)? 0 :\
             ^
../deps/libffi/src/dlmalloc.c:2143:6: note: expanded from macro 'granularity_align'
  (((S) + (mparams.granularity)) & ~(mparams.granularity - SIZE_T_ONE))
     ^
../deps/libffi/src/dlmalloc.c:3488:49: warning: arithmetic on a null pointer treated as a cast from integer to pointer is a GNU extension [-Wnull-pointer-arithmetic]
          size_t esize = granularity_align(nb + TOP_FOOT_SIZE + SIZE_T_ONE - asize);
                         ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../deps/libffi/src/dlmalloc.c:2188:17: note: expanded from macro 'TOP_FOOT_SIZE'
  (align_offset(chunk2mem(0))+pad_request(sizeof(struct malloc_segment))+MIN_CHUNK_SIZE)
                ^
../deps/libffi/src/dlmalloc.c:1688:55: note: expanded from macro 'chunk2mem'
#define chunk2mem(p)        ((void*)((char*)(p)       + TWO_SIZE_T_SIZES))
                                                      ^
../deps/libffi/src/dlmalloc.c:1276:34: note: expanded from macro 'align_offset'
  ((MALLOC_ALIGNMENT - ((size_t)(A) & CHUNK_ALIGN_MASK)) & CHUNK_ALIGN_MASK))
                                 ^
../deps/libffi/src/dlmalloc.c:2143:6: note: expanded from macro 'granularity_align'
  (((S) + (mparams.granularity)) & ~(mparams.granularity - SIZE_T_ONE))
     ^
../deps/libffi/src/dlmalloc.c:3512:23: warning: arithmetic on a null pointer treated as a cast from integer to pointer is a GNU extension [-Wnull-pointer-arithmetic]
    size_t req = nb + TOP_FOOT_SIZE + SIZE_T_ONE;
                      ^~~~~~~~~~~~~
../deps/libffi/src/dlmalloc.c:2188:17: note: expanded from macro 'TOP_FOOT_SIZE'
  (align_offset(chunk2mem(0))+pad_request(sizeof(struct malloc_segment))+MIN_CHUNK_SIZE)
   ~~~~~~~~~~~~~^~~~~~~~~~~~~
../deps/libffi/src/dlmalloc.c:1688:55: note: expanded from macro 'chunk2mem'
#define chunk2mem(p)        ((void*)((char*)(p)       + TWO_SIZE_T_SIZES))
                                                      ^
../deps/libffi/src/dlmalloc.c:1275:14: note: expanded from macro 'align_offset'
 ((((size_t)(A) & CHUNK_ALIGN_MASK) == 0)? 0 :\
             ^
../deps/libffi/src/dlmalloc.c:3512:23: warning: arithmetic on a null pointer treated as a cast from integer to pointer is a GNU extension [-Wnull-pointer-arithmetic]
    size_t req = nb + TOP_FOOT_SIZE + SIZE_T_ONE;
                      ^~~~~~~~~~~~~
../deps/libffi/src/dlmalloc.c:2188:17: note: expanded from macro 'TOP_FOOT_SIZE'
  (align_offset(chunk2mem(0))+pad_request(sizeof(struct malloc_segment))+MIN_CHUNK_SIZE)
   ~~~~~~~~~~~~~^~~~~~~~~~~~~
../deps/libffi/src/dlmalloc.c:1688:55: note: expanded from macro 'chunk2mem'
#define chunk2mem(p)        ((void*)((char*)(p)       + TWO_SIZE_T_SIZES))
                                                      ^
../deps/libffi/src/dlmalloc.c:1276:34: note: expanded from macro 'align_offset'
  ((MALLOC_ALIGNMENT - ((size_t)(A) & CHUNK_ALIGN_MASK)) & CHUNK_ALIGN_MASK))
                                 ^
../deps/libffi/src/dlmalloc.c:3525:43: warning: arithmetic on a null pointer treated as a cast from integer to pointer is a GNU extension [-Wnull-pointer-arithmetic]
    size_t asize = granularity_align(nb + TOP_FOOT_SIZE + SIZE_T_ONE);
                   ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
../deps/libffi/src/dlmalloc.c:2188:17: note: expanded from macro 'TOP_FOOT_SIZE'
  (align_offset(chunk2mem(0))+pad_request(sizeof(struct malloc_segment))+MIN_CHUNK_SIZE)
                ^
../deps/libffi/src/dlmalloc.c:1688:55: note: expanded from macro 'chunk2mem'
#define chunk2mem(p)        ((void*)((char*)(p)       + TWO_SIZE_T_SIZES))
                                                      ^
../deps/libffi/src/dlmalloc.c:1275:14: note: expanded from macro 'align_offset'
 ((((size_t)(A) & CHUNK_ALIGN_MASK) == 0)? 0 :\
             ^
../deps/libffi/src/dlmalloc.c:2143:6: note: expanded from macro 'granularity_align'
  (((S) + (mparams.granularity)) & ~(mparams.granularity - SIZE_T_ONE))
     ^
../deps/libffi/src/dlmalloc.c:3525:43: warning: arithmetic on a null pointer treated as a cast from integer to pointer is a GNU extension [-Wnull-pointer-arithmetic]
    size_t asize = granularity_align(nb + TOP_FOOT_SIZE + SIZE_T_ONE);
                   ~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
../deps/libffi/src/dlmalloc.c:2188:17: note: expanded from macro 'TOP_FOOT_SIZE'
  (align_offset(chunk2mem(0))+pad_request(sizeof(struct malloc_segment))+MIN_CHUNK_SIZE)
                ^
../deps/libffi/src/dlmalloc.c:1688:55: note: expanded from macro 'chunk2mem'
#define chunk2mem(p)        ((void*)((char*)(p)       + TWO_SIZE_T_SIZES))
                                                      ^
../deps/libffi/src/dlmalloc.c:1276:34: note: expanded from macro 'align_offset'
  ((MALLOC_ALIGNMENT - ((size_t)(A) & CHUNK_ALIGN_MASK)) & CHUNK_ALIGN_MASK))
                                 ^
../deps/libffi/src/dlmalloc.c:2143:6: note: expanded from macro 'granularity_align'
  (((S) + (mparams.granularity)) & ~(mparams.granularity - SIZE_T_ONE))
     ^
../deps/libffi/src/dlmalloc.c:3535:26: warning: arithmetic on a null pointer treated as a cast from integer to pointer is a GNU extension [-Wnull-pointer-arithmetic]
        if (ssize > nb + TOP_FOOT_SIZE) {
                         ^~~~~~~~~~~~~
../deps/libffi/src/dlmalloc.c:2188:17: note: expanded from macro 'TOP_FOOT_SIZE'
  (align_offset(chunk2mem(0))+pad_request(sizeof(struct malloc_segment))+MIN_CHUNK_SIZE)
   ~~~~~~~~~~~~~^~~~~~~~~~~~~
../deps/libffi/src/dlmalloc.c:1688:55: note: expanded from macro 'chunk2mem'
#define chunk2mem(p)        ((void*)((char*)(p)       + TWO_SIZE_T_SIZES))
                                                      ^
../deps/libffi/src/dlmalloc.c:1275:14: note: expanded from macro 'align_offset'
 ((((size_t)(A) & CHUNK_ALIGN_MASK) == 0)? 0 :\
             ^
../deps/libffi/src/dlmalloc.c:3535:26: warning: arithmetic on a null pointer treated as a cast from integer to pointer is a GNU extension [-Wnull-pointer-arithmetic]
        if (ssize > nb + TOP_FOOT_SIZE) {
                         ^~~~~~~~~~~~~
../deps/libffi/src/dlmalloc.c:2188:17: note: expanded from macro 'TOP_FOOT_SIZE'
  (align_offset(chunk2mem(0))+pad_request(sizeof(struct malloc_segment))+MIN_CHUNK_SIZE)
   ~~~~~~~~~~~~~^~~~~~~~~~~~~
../deps/libffi/src/dlmalloc.c:1688:55: note: expanded from macro 'chunk2mem'
#define chunk2mem(p)        ((void*)((char*)(p)       + TWO_SIZE_T_SIZES))
                                                      ^
../deps/libffi/src/dlmalloc.c:1276:34: note: expanded from macro 'align_offset'
  ((MALLOC_ALIGNMENT - ((size_t)(A) & CHUNK_ALIGN_MASK)) & CHUNK_ALIGN_MASK))
                                 ^
../deps/libffi/src/dlmalloc.c:3555:47: warning: arithmetic on a null pointer treated as a cast from integer to pointer is a GNU extension [-Wnull-pointer-arithmetic]
        init_top(m, (mchunkptr)tbase, tsize - TOP_FOOT_SIZE);
                                              ^~~~~~~~~~~~~
../deps/libffi/src/dlmalloc.c:2188:17: note: expanded from macro 'TOP_FOOT_SIZE'
  (align_offset(chunk2mem(0))+pad_request(sizeof(struct malloc_segment))+MIN_CHUNK_SIZE)
   ~~~~~~~~~~~~~^~~~~~~~~~~~~
../deps/libffi/src/dlmalloc.c:1688:55: note: expanded from macro 'chunk2mem'
#define chunk2mem(p)        ((void*)((char*)(p)       + TWO_SIZE_T_SIZES))
                                                      ^
../deps/libffi/src/dlmalloc.c:1275:14: note: expanded from macro 'align_offset'
 ((((size_t)(A) & CHUNK_ALIGN_MASK) == 0)? 0 :\
             ^
../deps/libffi/src/dlmalloc.c:3555:47: warning: arithmetic on a null pointer treated as a cast from integer to pointer is a GNU extension [-Wnull-pointer-arithmetic]
        init_top(m, (mchunkptr)tbase, tsize - TOP_FOOT_SIZE);
                                              ^~~~~~~~~~~~~
../deps/libffi/src/dlmalloc.c:2188:17: note: expanded from macro 'TOP_FOOT_SIZE'
  (align_offset(chunk2mem(0))+pad_request(sizeof(struct malloc_segment))+MIN_CHUNK_SIZE)
   ~~~~~~~~~~~~~^~~~~~~~~~~~~
../deps/libffi/src/dlmalloc.c:1688:55: note: expanded from macro 'chunk2mem'
#define chunk2mem(p)        ((void*)((char*)(p)       + TWO_SIZE_T_SIZES))
                                                      ^
../deps/libffi/src/dlmalloc.c:1276:34: note: expanded from macro 'align_offset'
  ((MALLOC_ALIGNMENT - ((size_t)(A) & CHUNK_ALIGN_MASK)) & CHUNK_ALIGN_MASK))
                                 ^
../deps/libffi/src/dlmalloc.c:3559:64: warning: arithmetic on a null pointer treated as a cast from integer to pointer is a GNU extension [-Wnull-pointer-arithmetic]
        init_top(m, mn, (size_t)((tbase + tsize) - (char*)mn) -TOP_FOOT_SIZE);
                                                               ^~~~~~~~~~~~~
../deps/libffi/src/dlmalloc.c:2188:17: note: expanded from macro 'TOP_FOOT_SIZE'
  (align_offset(chunk2mem(0))+pad_request(sizeof(struct malloc_segment))+MIN_CHUNK_SIZE)
   ~~~~~~~~~~~~~^~~~~~~~~~~~~
../deps/libffi/src/dlmalloc.c:1688:55: note: expanded from macro 'chunk2mem'
#define chunk2mem(p)        ((void*)((char*)(p)       + TWO_SIZE_T_SIZES))
                                                      ^
../deps/libffi/src/dlmalloc.c:1275:14: note: expanded from macro 'align_offset'
 ((((size_t)(A) & CHUNK_ALIGN_MASK) == 0)? 0 :\
             ^
../deps/libffi/src/dlmalloc.c:3559:64: warning: arithmetic on a null pointer treated as a cast from integer to pointer is a GNU extension [-Wnull-pointer-arithmetic]
        init_top(m, mn, (size_t)((tbase + tsize) - (char*)mn) -TOP_FOOT_SIZE);
                                                               ^~~~~~~~~~~~~
../deps/libffi/src/dlmalloc.c:2188:17: note: expanded from macro 'TOP_FOOT_SIZE'
  (align_offset(chunk2mem(0))+pad_request(sizeof(struct malloc_segment))+MIN_CHUNK_SIZE)
   ~~~~~~~~~~~~~^~~~~~~~~~~~~
../deps/libffi/src/dlmalloc.c:1688:55: note: expanded from macro 'chunk2mem'
#define chunk2mem(p)        ((void*)((char*)(p)       + TWO_SIZE_T_SIZES))
                                                      ^
../deps/libffi/src/dlmalloc.c:1276:34: note: expanded from macro 'align_offset'
  ((MALLOC_ALIGNMENT - ((size_t)(A) & CHUNK_ALIGN_MASK)) & CHUNK_ALIGN_MASK))
                                 ^
../deps/libffi/src/dlmalloc.c:3627:59: warning: arithmetic on a null pointer treated as a cast from integer to pointer is a GNU extension [-Wnull-pointer-arithmetic]
      if (!cinuse(p) && (char*)p + psize >= base + size - TOP_FOOT_SIZE) {
                                                          ^~~~~~~~~~~~~
../deps/libffi/src/dlmalloc.c:2188:17: note: expanded from macro 'TOP_FOOT_SIZE'
  (align_offset(chunk2mem(0))+pad_request(sizeof(struct malloc_segment))+MIN_CHUNK_SIZE)
   ~~~~~~~~~~~~~^~~~~~~~~~~~~
../deps/libffi/src/dlmalloc.c:1688:55: note: expanded from macro 'chunk2mem'
#define chunk2mem(p)        ((void*)((char*)(p)       + TWO_SIZE_T_SIZES))
                                                      ^
../deps/libffi/src/dlmalloc.c:1275:14: note: expanded from macro 'align_offset'
 ((((size_t)(A) & CHUNK_ALIGN_MASK) == 0)? 0 :\
             ^
../deps/libffi/src/dlmalloc.c:3627:59: warning: arithmetic on a null pointer treated as a cast from integer to pointer is a GNU extension [-Wnull-pointer-arithmetic]
      if (!cinuse(p) && (char*)p + psize >= base + size - TOP_FOOT_SIZE) {
                                                          ^~~~~~~~~~~~~
../deps/libffi/src/dlmalloc.c:2188:17: note: expanded from macro 'TOP_FOOT_SIZE'
  (align_offset(chunk2mem(0))+pad_request(sizeof(struct malloc_segment))+MIN_CHUNK_SIZE)
   ~~~~~~~~~~~~~^~~~~~~~~~~~~
../deps/libffi/src/dlmalloc.c:1688:55: note: expanded from macro 'chunk2mem'
#define chunk2mem(p)        ((void*)((char*)(p)       + TWO_SIZE_T_SIZES))
                                                      ^
../deps/libffi/src/dlmalloc.c:1276:34: note: expanded from macro 'align_offset'
  ((MALLOC_ALIGNMENT - ((size_t)(A) & CHUNK_ALIGN_MASK)) & CHUNK_ALIGN_MASK))
                                 ^
../deps/libffi/src/dlmalloc.c:3658:12: warning: arithmetic on a null pointer treated as a cast from integer to pointer is a GNU extension [-Wnull-pointer-arithmetic]
    pad += TOP_FOOT_SIZE; /* ensure enough room for segment overhead */
           ^~~~~~~~~~~~~
../deps/libffi/src/dlmalloc.c:2188:17: note: expanded from macro 'TOP_FOOT_SIZE'
  (align_offset(chunk2mem(0))+pad_request(sizeof(struct malloc_segment))+MIN_CHUNK_SIZE)
   ~~~~~~~~~~~~~^~~~~~~~~~~~~
../deps/libffi/src/dlmalloc.c:1688:55: note: expanded from macro 'chunk2mem'
#define chunk2mem(p)        ((void*)((char*)(p)       + TWO_SIZE_T_SIZES))
                                                      ^
../deps/libffi/src/dlmalloc.c:1275:14: note: expanded from macro 'align_offset'
 ((((size_t)(A) & CHUNK_ALIGN_MASK) == 0)? 0 :\
             ^
../deps/libffi/src/dlmalloc.c:3658:12: warning: arithmetic on a null pointer treated as a cast from integer to pointer is a GNU extension [-Wnull-pointer-arithmetic]
    pad += TOP_FOOT_SIZE; /* ensure enough room for segment overhead */
           ^~~~~~~~~~~~~
../deps/libffi/src/dlmalloc.c:2188:17: note: expanded from macro 'TOP_FOOT_SIZE'
  (align_offset(chunk2mem(0))+pad_request(sizeof(struct malloc_segment))+MIN_CHUNK_SIZE)
   ~~~~~~~~~~~~~^~~~~~~~~~~~~
../deps/libffi/src/dlmalloc.c:1688:55: note: expanded from macro 'chunk2mem'
#define chunk2mem(p)        ((void*)((char*)(p)       + TWO_SIZE_T_SIZES))
                                                      ^
../deps/libffi/src/dlmalloc.c:1276:34: note: expanded from macro 'align_offset'
  ((MALLOC_ALIGNMENT - ((size_t)(A) & CHUNK_ALIGN_MASK)) & CHUNK_ALIGN_MASK))
                                 ^
28 warnings generated.
  CC(target) Release/obj.target/ffi/deps/libffi/src/x86/ffi.o
  CC(target) Release/obj.target/ffi/deps/libffi/src/x86/ffi64.o
  CC(target) Release/obj.target/ffi/deps/libffi/src/x86/darwin.o
  CC(target) Release/obj.target/ffi/deps/libffi/src/x86/darwin64.o
  LIBTOOL-STATIC Release/libffi.a
Traceback (most recent call last):
  File "./gyp-mac-tool", line 611, in 
    sys.exit(main(sys.argv[1:]))
  File "./gyp-mac-tool", line 28, in main
    exit_code = executor.Dispatch(args)
  File "./gyp-mac-tool", line 43, in Dispatch
    return getattr(self, method)(*args[1:])
  File "./gyp-mac-tool", line 246, in ExecFilterLibtool
    if not libtool_re.match(line) and not libtool_re5.match(line):
TypeError: cannot use a string pattern on a bytes-like object
make: *** [Release/libffi.a] Error 1
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/Users/watson/code/elastic/kibana/node_modules/node-gyp/lib/build.js:262:23)
gyp ERR! stack     at ChildProcess.emit (events.js:198:13)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:248:12)
gyp ERR! System Darwin 19.3.0
gyp ERR! command "/Users/watson/.nvm/versions/node/v10.19.0/bin/node" "/Users/watson/code/elastic/kibana/node_modules/.bin/node-gyp" "rebuild"
gyp ERR! cwd /Users/watson/code/elastic/kibana/node_modules/ffi
[bootstrap] failed:
Error: Command failed with exit code 1: yarn install --non-interactive

at makeError (/Users/watson/code/elastic/kibana/packages/kbn-pm/dist/index.js:33442:11)

at handlePromise (/Users/watson/code/elastic/kibana/packages/kbn-pm/dist/index.js:32378:26)

at process._tickCallback (internal/process/next_tick.js:68:7)

error Command failed with exit code 1.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

This is a know issue with ref: TooTallNate/ref#125

The proposed solution is to either downgrade Node.js or use ref-napi instead. We can't do either of those things, so I propose that we revert this PR until we find a solution so that master isn't broken on some dev-environments.

Update

The issue is related to the version of Python installed. The ref package cannot be installed on a modern version of Node.js if the default Python is v3. If you downgrade your default Python to v2, the installation succeeds.

But since Python 3 is the preferred version of Python to be running, it would be best if we could find a solution that didn't require us to downgrade Python.

…lastic#63063)

…lastic#63068)" This reverts commit e8caa06.

…#63462) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

…63063) (#63485) * Revert "FTR: add chromium-based Edge browser support (#61684) (#63068)" This reverts commit e8caa06. * update lock file

* alerting/alert-services-mock: (107 commits) removed unused import added alert services mock and use it in siem [Metrics UI] Refactor With* containers to hooks (elastic#59503) [NP] Migrate logstash server side code to NP (elastic#63135) Clicking cancel in saved query save modal doesn't close it (elastic#62774) [Lens] Migration from 7.7 (elastic#62879) [Lens] Fix bug where suggestions didn't use filters (elastic#63293) Task/linux events (elastic#63400) [Remote clusters] guard against usageCollection plugin if unav… (elastic#63284) [Uptime] Remove pings graphql (elastic#59392) Index Pattern Field class - factor out copy_field code for future typescripting (elastic#63083) [EPM] add/remove package in package settings page (elastic#63389) Adjust API authorization logging (elastic#63350) Revert FTR: add chromium-based Edge browser support (elastic#61684) (elastic#63448) [Event Log] Adds namespace into save objects (elastic#62974) document code splitting for client code (elastic#62593) Escape single quotes surrounded by double quotes (elastic#63229) [Endpoint] Update cli mapping to match endpoint package (elastic#63372) update in-app links to metricbeat configuration docs (elastic#63295) investigation notes field (documentation / metadata) (elastic#63386) ...

…edge-support [7.7] Revert FTR: add chromium-based Edge browser support (elastic#61684) (elastic#63063)

* Revert "FTR: add chromium-based Edge browser support (#61684) (#63068)" This reverts commit e8caa06. * update lock file * [Reporting] Improve functional test steps (#63259) * Start of refactoring * remove unused fixtuers * fix the refactoring bugs * update archive with better dashboard * important comment Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> * get tests to pass * get more tests to pass * reduce branch diffs * reduce loc change Co-authored-by: Dzmitry Lemechko <dzmitry.lemechko@elastic.co> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

dmlemeshko added 4 commits March 6, 2020 00:51

bump dependency, add edge support in ftr services

01e7668

add config files

6dee7e4

fix browser version for msedge

a237137

use npm ms-chromium-edge-driver

a9f48c1

dmlemeshko added 5 commits April 1, 2020 19:23

download edge driver aside from session creation

27d2e58

Merge remote-tracking branch 'upstream/master' into ftr/add-chromium-…

0b2f47a

…edge-support

move dependency to dev

e3ec489

update dist/index file

9a55461

bump edge-driver version

a248566

dmlemeshko added 2 commits April 3, 2020 17:39

change type to msedge to match w3c spec

67d3afe

fix discover tests for Edge

87e7fdd

dmlemeshko mentioned this pull request Apr 5, 2020

FTR: Enable w3c for chromedriver #62542

Merged

7 tasks

dmlemeshko added 2 commits April 7, 2020 16:11

Revert "fix discover tests for Edge"

513547d

This reverts commit 87e7fdd.

Merge remote-tracking branch 'upstream/master' into ftr/add-chromium-…

3dc5d6f

…edge-support

Merge branch 'master' into ftr/add-chromium-edge-support

7a4197e

dmlemeshko added the test_ui_functional label Apr 7, 2020

dmlemeshko added v8.0.0 v7.8.0 labels Apr 7, 2020

bump driver version up

10f22a7

dmlemeshko requested review from spalger and LeeDr April 7, 2020 17:41

dmlemeshko marked this pull request as ready for review April 7, 2020 17:41

dmlemeshko requested a review from a team as a code owner April 7, 2020 17:41

dmlemeshko added the release_note:skip Skip the PR/issue when compiling release notes label Apr 7, 2020

spalger approved these changes Apr 8, 2020

View reviewed changes

dmlemeshko merged commit 578e443 into elastic:master Apr 8, 2020

dmlemeshko mentioned this pull request Apr 8, 2020

[7.x] FTR: add chromium-based Edge browser support (#61684) #63063

Merged

dmlemeshko mentioned this pull request Apr 8, 2020

[7.7] FTR: add chromium-based Edge browser support (#61684) #63068

Merged

dmlemeshko added the v7.7.0 label Apr 9, 2020

dmlemeshko added a commit to dmlemeshko/kibana that referenced this pull request Apr 14, 2020

Revert FTR: add chromium-based Edge browser support (elastic#61684)

e632a5c

dmlemeshko mentioned this pull request Apr 14, 2020

Revert FTR: add chromium-based Edge browser support (#61684) #63448

Merged

watson pushed a commit that referenced this pull request Apr 14, 2020

Revert FTR: add chromium-based Edge browser support (#61684) (#63448)

637a9e1

dmlemeshko added a commit to dmlemeshko/kibana that referenced this pull request Apr 14, 2020

Revert FTR: add chromium-based Edge browser support (elastic#61684) (e…

c70faed

…lastic#63063)

dmlemeshko mentioned this pull request Apr 14, 2020

[7.x] Revert FTR: add chromium-based Edge browser support (#61684) (#63063) #63462

Merged

dmlemeshko added a commit to dmlemeshko/kibana that referenced this pull request Apr 14, 2020

Revert "FTR: add chromium-based Edge browser support (elastic#61684) (e…

33e9036

…lastic#63068)" This reverts commit e8caa06.

dmlemeshko mentioned this pull request Apr 14, 2020

[7.7] Revert FTR: add chromium-based Edge browser support (#61684) (#63063) #63485

Merged

dmlemeshko added a commit that referenced this pull request Apr 15, 2020

Revert FTR: add chromium-based Edge browser support (#61684) (#63063) (…

9e4a7bd

…#63462) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

dmlemeshko mentioned this pull request Apr 15, 2020

[FTR]: add chromium-based Edge browser support #63566

Merged

wayneseymour pushed a commit that referenced this pull request Apr 15, 2020

Revert FTR: add chromium-based Edge browser support (#61684) (#63448)

69c26a1

tsullivan added a commit to tsullivan/kibana that referenced this pull request Apr 15, 2020

Merge pull request elastic#63485 from dmlemeshko/7.7-revert-chromium-…

fec2324

…edge-support [7.7] Revert FTR: add chromium-based Edge browser support (elastic#61684) (elastic#63063)

dmlemeshko deleted the ftr/add-chromium-edge-support branch January 31, 2022 12:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

FTR: add chromium-based Edge browser support #61684

FTR: add chromium-based Edge browser support #61684

dmlemeshko commented Mar 27, 2020

LeeDr commented Mar 30, 2020 •

edited

Loading

LeeDr commented Mar 30, 2020

LeeDr commented Apr 2, 2020

dmlemeshko commented Apr 7, 2020

kibanamachine commented Apr 7, 2020

spalger left a comment

watson commented Apr 14, 2020 •

edited

Loading

FTR: add chromium-based Edge browser support #61684

FTR: add chromium-based Edge browser support #61684

Conversation

dmlemeshko commented Mar 27, 2020

Summary

LeeDr commented Mar 30, 2020 • edited Loading

LeeDr commented Mar 30, 2020

LeeDr commented Apr 2, 2020

dmlemeshko commented Apr 7, 2020

kibanamachine commented Apr 7, 2020

💚 Build Succeeded

History

spalger left a comment

Choose a reason for hiding this comment

watson commented Apr 14, 2020 • edited Loading

Update

LeeDr commented Mar 30, 2020 •

edited

Loading

watson commented Apr 14, 2020 •

edited

Loading