[Reporting/New Platform Migration] Use a new config service on server-side (re-do) #61696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 25, 2020 10:10
…ation-server-config
…ation-server-config
…ation-server-config
joelgriffith
added
(Deprecated) Feature:Reporting
|
Goal here is to re-run the full CI process a few times. |
|
@elasticmachine merge upstream |
1 similar comment
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
tsullivan
changed the title
|
@elasticmachine merge upstream |
2 tasks
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
afharo
reviewed
Apr 3, 2020
| @@ -11,16 +11,17 @@ import { PluginStart as DataPluginStart } from '../../../../../src/plugins/data/ | |||
| import { SecurityPluginSetup } from '../../../../plugins/security/server'; | |||
| import { XPackMainPlugin } from '../../xpack_main/server/xpack_main'; | |||
| import { ReportingPluginSpecOptions } from '../types'; | |||
| import { ReportingConfig, ReportingConfigType } from './core'; | |||
|
|
|||
| export interface ReportingSetupDeps { | |||
| elasticsearch: ElasticsearchServiceSetup; | |||
| security: SecurityPluginSetup; | |||
| usageCollection: UsageCollectionSetup; | |||
There was a problem hiding this comment.
In the kibana.json, usageCollection is an "optionalDependency", which is the way to go.
ReportingSetupDeps should define it as an optional dependency.
| exportTypesRegistry, | ||
| collectionIsReady | ||
| ); | ||
| usageCollection.registerCollector(collector); | ||
| plugins.usageCollection.registerCollector(collector); |
There was a problem hiding this comment.
plugins.usageCollection might be undefined
| @@ -93,51 +90,6 @@ export type ReportingResponseToolkit = Legacy.ResponseToolkit; | |||
|
|
|||
| export type ESCallCluster = CallCluster; | |||
There was a problem hiding this comment.
Type-wise it should be the same and there shouldn't be any issues but CallCluster is now APICaller in NP from 'src/core/server'
3 tasks
|
Replaced with #62500 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Re-introduces the reporting config change that was reverted mid-week: #61075
Original PR: #55882.
This PR has successfully undergone the flaky-test runner: https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/312/testReport/