[ML] Fixing reporting of http request errors #61811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgowdyelastic
added
bug
jgowdyelastic
requested review from
walterra,
darnautov,
alvarezmelissa87 and
peteharverson
|
Pinging @elastic/ml-ui (:ml) |
| @@ -7420,7 +7420,6 @@ | |||
| "xpack.ml.calendarsEdit.newEventModal.startDateAriaLabel": "開始日", | |||
| "xpack.ml.calendarsEdit.newEventModal.toLabel": "終了:", | |||
| "xpack.ml.calendarsList.deleteCalendars.calendarsLabel": "{calendarsToDeleteCount} 件のカレンダー", | |||
| "xpack.ml.calendarsList.deleteCalendars.deletingCalendarErrorMessage": "カレンダー {calendarId} の削除中にエラーが発生しました: {errorMessage}", | |||
There was a problem hiding this comment.
Isn't this translation still being used?
There was a problem hiding this comment.
yes, but the text has changed. so i think it's marked it as removed so the translated text can be remade.
alvarezmelissa87
approved these changes
Mar 30, 2020
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Mar 31, 2020
* [ML] Fixing reporting of http request errors * fixing types * updating translations Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Mar 31, 2020
* [ML] Fixing reporting of http request errors * fixing types * updating translations Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jgowdyelastic
added a commit
that referenced
this pull request
Mar 31, 2020
* [ML] Fixing reporting of http request errors * fixing types * updating translations Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jgowdyelastic
added a commit
that referenced
this pull request
Mar 31, 2020
* [ML] Fixing reporting of http request errors * fixing types * updating translations Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows on from the changes made in #60249
Job wizard request errors also need to be wrapped in
getErrorMessageFurther work is needed to add consistency to all http errors. Possibly removing the very old
mlMessageBarServiceand calling toasts directly in all places.Also observable based
http$requests return a different error tohttp, these should be made consistent.