Use docLinks API for APM doc links #61880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove `packageInfo` (from ui/metadata package from the legacy platform) and replace with `core.dockLinks` in the `ElasticDocsLink` component. Fixes elastic#56453 Fixes elastic#60945
smith
added
bug
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
ogupte
approved these changes
Mar 30, 2020
smith
added a commit
to smith/kibana
that referenced
this pull request
Mar 30, 2020
* Use docLinks API for APM doc links Remove `packageInfo` (from ui/metadata package from the legacy platform) and replace with `core.dockLinks` in the `ElasticDocsLink` component. Fixes elastic#56453 Fixes elastic#60945
smith
added a commit
to smith/kibana
that referenced
this pull request
Mar 30, 2020
* Use docLinks API for APM doc links Remove `packageInfo` (from ui/metadata package from the legacy platform) and replace with `core.dockLinks` in the `ElasticDocsLink` component. Fixes elastic#56453 Fixes elastic#60945
smith
added a commit
that referenced
this pull request
Mar 31, 2020
kibanamachine
added
the
backport missing
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
kibanamachine
removed
the
backport missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
packageInfo(from ui/metadata package from the legacy platform) and replace withcore.dockLinksin theElasticDocsLinkcomponent.Fixes cases where documentation links were not working because the version we were using in the URL is not the same version as the what the docs use.
Fixes #56453
Fixes #60945