Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Endpoint: Add ts-node dev dependency (#61884)" #62197

Merged
merged 1 commit into from
Apr 1, 2020

Conversation

oatkiller
Copy link
Contributor

@oatkiller oatkiller commented Apr 1, 2020

This reverts commit 4899aaf.

Summary

Adding ts-node caused build issues. The original commit was low value and this should not disrupt our workflow at all. @spalger has ideas on how we can achieve the effect (not needing to globally install ts-node) without causing issues. Will follow up w/ that in another issue/PR

For maintainers

@oatkiller oatkiller requested a review from a team as a code owner April 1, 2020 17:02
@oatkiller oatkiller added release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v8.0.0 labels Apr 1, 2020
Copy link
Contributor

@tylersmalley tylersmalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding another review for good measure

Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@spalger spalger merged commit 3fdddea into elastic:master Apr 1, 2020
@spalger spalger added v7.8.0 and removed v7.7.0 labels Apr 1, 2020
spalger pushed a commit to spalger/kibana that referenced this pull request Apr 1, 2020
@oatkiller oatkiller deleted the revert-ts-node-dep branch April 1, 2020 18:58
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 2, 2020
* master:
  [HomeApp] Set breadcrumbs when coming back from add data dir (elastic#62186)
  [Lens] fix error for minInterval>computedInterval for XYChart (elastic#61931)
  ci: remove AppArch label from ProBot path-labeler (elastic#62211)
  [Uptime] Optimize get latest monitor API (elastic#61820)
  [Maps] Separate layer wizards for Clusters and heatmap (elastic#60870)
  Remove polling delay (elastic#62099)
  accessibility tests for dashboard panel ( OSS)  (elastic#62055)
  rename README.md to readme, avoiding issues with case change
  [SIEM] [Detection Engine] Fixes all rules sorting (elastic#62039)
  [SIEM] CASES Bugs BC2 (elastic#62170)
  Revert "Endpoint: Add ts-node dev dependency (elastic#61884)" (elastic#62197)
  Closes elastic#60173 by turning off client caching for the main service map API call (elastic#62111)
  [SIEM] Restores the _External alert count_ widget's subtitle (elastic#62094)
  [Maps] Update ems client dependency to 7.8.0 (elastic#62181)
  [Metrics Alerts] Fix action variables, default message, and EU… (elastic#62061)
  Update CODEOWNERS with ES-UI apps, including grok debugger. (elastic#62045)
  Update ILM node attributes blacklist. (elastic#62093)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.8.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants