[Console] Handle the case where saving to history may throw an error

[jloleysens]

Summary

We should still show the request result even if localStorage is full (or any other save error occurs).

Fix #62203

How to test

Run the following script in browser console:

const prefix = 'THIS_IS_GARBAGE_DATA_'

function fillLocalStorage() {
  const data = 'FFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF'
  let idx = 0
  while(true) {
    localStorage[prefix + ++idx] = data
  }
}

function undoFillLocalStorage() {
  Object.keys(localStorage).forEach(k => {
    if (k.startsWith(prefix)) {
      localStorage.removeItem(k)
    }
  })
}

Then run fillLocalStorage() and wait for the localStorage quota error to appear.

Run a request in Console and see the error notification appear, the request result should still appear in the output pane.

Run undoFillLocalStorage(). Then run a Console request again, this time there should be no error about localStorage quota.

Gif of request with history error

Release Note

We fixed an issue where Console would not render the request output if localStorage quota was reached.

[elasticmachine]

Pinging @elastic/es-ui (Team:Elasticsearch UI)

[alisonelizabeth]

LGTM. Tested locally. Thanks for fixing this @jloleysens!

[jloleysens]

@elasticmachine merge upstream

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 34f0388

History

• 💚 Build #38501 succeeded afc2042
• 💚 Build #38381 succeeded 359ca4f

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream