-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NP] Get rid of ui/i18n in Discover #62799
Conversation
Pinging @elastic/kibana-app (Team:KibanaApp) |
💚 Build SucceededTo update your PR or re-run it, just comment with: |
@maryia-lapata thx! ACK, will review today |
@@ -201,7 +201,6 @@ function createDocTableModule() { | |||
.directive('docTable', createDocTableDirective) | |||
.directive('kbnTableHeader', createTableHeaderDirective) | |||
.directive('toolBarPagerText', createToolBarPagerTextDirective) | |||
.directive('toolBarPagerText', createToolBarPagerTextDirective) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx for cleaning this up !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and couldn't find any problems, LGTM.
A side note: To also have phrases within EUI components translated properly (e.g. for the EuiBasicTable
component), everything should theoretically be wrapped into a I18nContext
returned from core.i18n.Context
. In this particular case I couldn't find an instance of this, so this looks good to me for now (especially since passing down the context component will be a lot of work as they are a lot of roots).
When we are denagularizing the rest of the application, it will be sufficient to place a single I18nContext in the root of the react app.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM 👍 , thx for the cleanups! Tested locally in Chrome 80, macOs 10.14.6
✅ Discover Main
✅ Discover Context
✅ Discover Doc view
All work as expected
Summary
Part of #60097.
Checklist
Delete any items that are not applicable to this PR.
For maintainers